Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(84)

Issue 179002: product_variant - first draft

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 10 months ago by JGras
Modified:
2 years, 8 months ago
Reviewers:
yangoon, udono, ced
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Fix error if seperator not set #

Patch Set 3 : complete patchset #

Total comments: 58

Patch Set 4 : changes according to comments #

Patch Set 5 : split generate_variants into methods for better customizing #

Total comments: 39

Patch Set 6 : Other approach to set inherited fields readonly #

Total comments: 6

Patch Set 7 : Lost in space - but it works locally #

Patch Set 8 : Syntax #

Total comments: 1

Patch Set 9 : Variant should not be searchable in product tree #

Total comments: 4

Patch Set 10 : added view vor attribute values #

Patch Set 11 : Fixed typo, fixed variant_search #

Total comments: 38

Patch Set 12 : Changes according comments #

Total comments: 1

Patch Set 13 : Fix search_variants #

Total comments: 1

Patch Set 14 : Fixing ident in product.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -244 lines) Patch
M __tryton__.py View 1 2 3 4 5 6 7 8 9 1 chunk +11 lines, -11 lines 0 comments Download
M configuration.py View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -5 lines 0 comments Download
M configuration.xml View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +19 lines, -17 lines 0 comments Download
M product.py View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +110 lines, -69 lines 0 comments Download
M product.xml View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +132 lines, -142 lines 0 comments Download

Messages

Total messages: 43
JGras
2 years, 10 months ago #1
JGras
2 years, 10 months ago #2
udono
In Patch set 2 are many files from patch set 1 missing.
2 years, 10 months ago #3
ced
2 years, 10 months ago #4
JGras
2 years, 10 months ago #5
udono
http://codereview.tryton.org/179002/diff/5002/product.py File product.py (right): http://codereview.tryton.org/179002/diff/5002/product.py#newcode50 product.py:50: codebase = fields.Char('Code') The string of a field should ...
2 years, 10 months ago #6
ced
http://codereview.tryton.org/179002/diff/5002/__tryton__.py File __tryton__.py (right): http://codereview.tryton.org/179002/diff/5002/__tryton__.py#newcode4 __tryton__.py:4: 'name' : 'Product Variants', PEP8: no space before : ...
2 years, 10 months ago #7
JGras
2 years, 10 months ago #8
JGras
http://codereview.tryton.org/179002/diff/5002/__tryton__.py File __tryton__.py (right): http://codereview.tryton.org/179002/diff/5002/__tryton__.py#newcode4 __tryton__.py:4: 'name' : 'Product Variants', On 2011/11/17 09:54:44, ced wrote: ...
2 years, 10 months ago #9
JGras
2 years, 10 months ago #10
JGras
http://codereview.tryton.org/179002/diff/7002/product.py File product.py (right): http://codereview.tryton.org/179002/diff/7002/product.py#newcode86 product.py:86: def create_code(self, codebase, variant): Yesterday I talked with a ...
2 years, 10 months ago #11
JGras
http://codereview.tryton.org/179002/diff/5002/product.py File product.py (right): http://codereview.tryton.org/179002/diff/5002/product.py#newcode52 product.py:52: 'template', 'attribute', 'Attributes') On 2011/11/17 09:36:52, udo.spallek wrote: > ...
2 years, 10 months ago #12
ced
http://codereview.tryton.org/179002/diff/5002/product.py File product.py (right): http://codereview.tryton.org/179002/diff/5002/product.py#newcode52 product.py:52: 'template', 'attribute', 'Attributes') On 2011/11/18 16:27:39, grasbauer wrote: > ...
2 years, 10 months ago #13
JGras
> Yes and this is an exception we do see > https://code.google.com/p/tryton/wiki/CodingGuidelines > It is ...
2 years, 10 months ago #14
udono
http://codereview.tryton.org/179002/diff/5002/product.py File product.py (right): http://codereview.tryton.org/179002/diff/5002/product.py#newcode52 product.py:52: 'template', 'attribute', 'Attributes') On 2011/11/18 16:34:33, ced wrote: > ...
2 years, 10 months ago #15
ced
http://codereview.tryton.org/179002/diff/5002/product.py File product.py (right): http://codereview.tryton.org/179002/diff/5002/product.py#newcode52 product.py:52: 'template', 'attribute', 'Attributes') On 2011/11/18 18:35:03, udo.spallek wrote: > ...
2 years, 10 months ago #16
ced
http://codereview.tryton.org/179002/diff/7002/__tryton__.py File __tryton__.py (right): http://codereview.tryton.org/179002/diff/7002/__tryton__.py#newcode5 __tryton__.py:5: 'version': '2.0.2', I think the version should be 2.3.0 ...
2 years, 10 months ago #17
JGras
2 years, 9 months ago #18
JGras
http://codereview.tryton.org/179002/diff/7002/__tryton__.py File __tryton__.py (right): http://codereview.tryton.org/179002/diff/7002/__tryton__.py#newcode5 __tryton__.py:5: 'version': '2.0.2', On 2011/11/23 16:31:27, ced wrote: > I ...
2 years, 9 months ago #19
JGras
sorry - my comments are related to the wrong revision
2 years, 9 months ago #20
JGras
this commit was b***it - i'll commit a new one
2 years, 9 months ago #21
udono
http://codereview.tryton.org/179002/diff/15001/__tryton__.py File __tryton__.py (right): http://codereview.tryton.org/179002/diff/15001/__tryton__.py#newcode9 __tryton__.py:9: 'description': 'Manage variants of products with \ Better use ...
2 years, 9 months ago #22
JGras
2 years, 9 months ago #23
JGras
2 years, 9 months ago #24
JGras
http://codereview.tryton.org/179002/diff/15001/__tryton__.py File __tryton__.py (right): http://codereview.tryton.org/179002/diff/15001/__tryton__.py#newcode9 __tryton__.py:9: 'description': 'Manage variants of products with \ On 2011/11/28 ...
2 years, 9 months ago #25
JGras
2 years, 9 months ago #26
JGras
http://codereview.tryton.org/179002/diff/12004/product.py File product.py (right): http://codereview.tryton.org/179002/diff/12004/product.py#newcode83 product.py:83: def search_variant(self, name, clause): this doesn't work on product ...
2 years, 9 months ago #27
udono
http://codereview.tryton.org/179002/diff/15003/configuration.xml File configuration.xml (right): http://codereview.tryton.org/179002/diff/15003/configuration.xml#newcode11 configuration.xml:11: groups="product.group_product_admin"/> groups is no longer supported in trytond > ...
2 years, 9 months ago #28
JGras
http://codereview.tryton.org/179002/diff/15003/product.xml File product.xml (right): http://codereview.tryton.org/179002/diff/15003/product.xml#newcode104 product.xml:104: <field name="search_value">{'variant': ['=', True]}</field> On 2011/11/29 10:00:39, udono wrote: ...
2 years, 9 months ago #29
udono
On 2011/11/29 10:15:31, grasbauer wrote: > http://codereview.tryton.org/179002/diff/15003/product.xml > File product.xml (right): > > http://codereview.tryton.org/179002/diff/15003/product.xml#newcode104 > ...
2 years, 9 months ago #30
JGras
2 years, 9 months ago #31
ced
It is difficult to review because the last sets are based on a previous commit. ...
2 years, 9 months ago #32
yangoon
http://codereview.tryton.org/179002/diff/16011/product.py File product.py (right): http://codereview.tryton.org/179002/diff/16011/product.py#newcode24 product.py:24: if not values.get('template'): I think you mean here: if ...
2 years, 9 months ago #33
JGras
2 years, 9 months ago #34
JGras
http://codereview.tryton.org/179002/diff/16011/configuration.xml File configuration.xml (right): http://codereview.tryton.org/179002/diff/16011/configuration.xml#newcode3 configuration.xml:3: This file is part of Tryton. The COPYRIGHT file ...
2 years, 9 months ago #35
JGras
2 years, 9 months ago #36
JGras
On 2011/12/05 19:55:55, ced wrote: > It is difficult to review because the last sets ...
2 years, 9 months ago #37
ced
On 13/12/11 16:51 +0000, grasbauer@googlemail.com wrote: > On 2011/12/05 19:55:55, ced wrote: > >It is ...
2 years, 9 months ago #38
JGras
2 years, 9 months ago #39
JGras
http://codereview.tryton.org/179002/diff/24007/product.xml File product.xml (right): http://codereview.tryton.org/179002/diff/24007/product.xml#newcode4 product.xml:4: this repository contains the full copyright notices and license ...
2 years, 9 months ago #40
JGras
http://codereview.tryton.org/179002/diff/16011/product.py File product.py (right): http://codereview.tryton.org/179002/diff/16011/product.py#newcode24 product.py:24: if not values.get('template'): On 2011/12/09 11:23:45, yangoon wrote: > ...
2 years, 8 months ago #41
ced
http://codereview.tryton.org/179002/diff/16011/product.py File product.py (right): http://codereview.tryton.org/179002/diff/16011/product.py#newcode24 product.py:24: if not values.get('template'): On 2011/12/27 15:49:37, grasbauer wrote: > ...
2 years, 8 months ago #42
ced
2 years, 8 months ago #43
Looks like you break the codereview when uploading the last version.
Please could you load a new one base on a clean repository.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1333:fb183666b261