Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(155)

Issue 580005: reduce_search_active_calls: prevent to recompute domain_parser if it's already known (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years ago by nicoe
Modified:
1 year, 12 months ago
Reviewers:
ced
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Fix 80 cols #

Total comments: 2

Patch Set 3 : compute self.fields_view_tree anyway #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -19 lines) Patch
M tryton/gui/window/view_form/screen/screen.py View 1 2 2 chunks +22 lines, -19 lines 0 comments Download

Messages

Total messages: 6
nicoe
2 years ago (2012-11-15 10:17:55 UTC) #1
nicoe
2 years ago (2012-11-15 10:18:52 UTC) #2
ced
http://codereview.tryton.org/580005/diff/3002/tryton/gui/window/view_form/screen/screen.py File tryton/gui/window/view_form/screen/screen.py (right): http://codereview.tryton.org/580005/diff/3002/tryton/gui/window/view_form/screen/screen.py#newcode101 tryton/gui/window/view_form/screen/screen.py:101: if not self.domain_parser: I will move the test only ...
2 years ago (2012-11-15 10:25:24 UTC) #3
nicoe
2 years ago (2012-11-20 12:58:13 UTC) #4
nicoe
http://codereview.tryton.org/580005/diff/3002/tryton/gui/window/view_form/screen/screen.py File tryton/gui/window/view_form/screen/screen.py (right): http://codereview.tryton.org/580005/diff/3002/tryton/gui/window/view_form/screen/screen.py#newcode101 tryton/gui/window/view_form/screen/screen.py:101: if not self.domain_parser: On 2012/11/15 10:25:24, ced wrote: > ...
2 years ago (2012-11-20 12:58:31 UTC) #5
ced
2 years ago (2012-11-23 12:42:38 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1440:120197668099