Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(521)

Issue 590006: tryton: enforce size limit on editable O2M (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 10 months ago by nicoe
Modified:
1 year, 6 months ago
Reviewers:
ced
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 : default for size_limit #

Total comments: 1

Patch Set 3 : Handle case where self.screen.size_limit is 0 #

Total comments: 2

Patch Set 4 : update to tip #

Total comments: 1

Patch Set 5 : fix parenthesis #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M tryton/gui/window/view_form/screen/screen.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/one2many.py View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M tryton/gui/window/view_form/view/list_gtk/editabletree.py View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13
nicoe
1 year, 10 months ago (2012-11-15 12:50:25 UTC) #1
ced
http://codereview.tryton.org/590006/diff/1/tryton/gui/window/view_form/view/form_gtk/one2many.py File tryton/gui/window/view_form/view/form_gtk/one2many.py (right): http://codereview.tryton.org/590006/diff/1/tryton/gui/window/view_form/view/form_gtk/one2many.py#newcode438 tryton/gui/window/view_form/view/form_gtk/one2many.py:438: domain = [] Missing default size_limit http://codereview.tryton.org/590006/diff/1/tryton/gui/window/view_form/view/form_gtk/one2many.py#newcode447 tryton/gui/window/view_form/view/form_gtk/one2many.py:447: if ...
1 year, 10 months ago (2012-11-15 13:48:46 UTC) #2
nicoe
1 year, 10 months ago (2012-11-25 17:55:04 UTC) #3
nicoe
http://codereview.tryton.org/590006/diff/1/tryton/gui/window/view_form/view/form_gtk/one2many.py File tryton/gui/window/view_form/view/form_gtk/one2many.py (right): http://codereview.tryton.org/590006/diff/1/tryton/gui/window/view_form/view/form_gtk/one2many.py#newcode438 tryton/gui/window/view_form/view/form_gtk/one2many.py:438: domain = [] On 2012/11/15 13:48:46, ced wrote: > ...
1 year, 10 months ago (2012-11-25 17:55:10 UTC) #4
ced
http://codereview.tryton.org/590006/diff/6001/tryton/gui/window/view_form/view/list_gtk/editabletree.py File tryton/gui/window/view_form/view/list_gtk/editabletree.py (right): http://codereview.tryton.org/590006/diff/6001/tryton/gui/window/view_form/view/list_gtk/editabletree.py#newcode90 tryton/gui/window/view_form/view/list_gtk/editabletree.py:90: if not access['create'] or (self.screen.size_limit What if size_limit equals ...
1 year, 10 months ago (2012-11-28 18:07:57 UTC) #5
nicoe
1 year, 10 months ago (2012-11-28 18:28:02 UTC) #6
ced
http://codereview.tryton.org/590006/diff/10001/tryton/gui/window/view_form/view/list_gtk/editabletree.py File tryton/gui/window/view_form/view/list_gtk/editabletree.py (right): http://codereview.tryton.org/590006/diff/10001/tryton/gui/window/view_form/view/list_gtk/editabletree.py#newcode91 tryton/gui/window/view_form/view/list_gtk/editabletree.py:91: and len(model) >= self.screen.size_limit): In other place, the test ...
1 year, 10 months ago (2012-11-28 18:38:34 UTC) #7
nicoe
http://codereview.tryton.org/590006/diff/10001/tryton/gui/window/view_form/view/list_gtk/editabletree.py File tryton/gui/window/view_form/view/list_gtk/editabletree.py (right): http://codereview.tryton.org/590006/diff/10001/tryton/gui/window/view_form/view/list_gtk/editabletree.py#newcode91 tryton/gui/window/view_form/view/list_gtk/editabletree.py:91: and len(model) >= self.screen.size_limit): On 2012/11/28 18:38:34, ced wrote: ...
1 year, 10 months ago (2012-12-03 11:10:55 UTC) #8
ced
On 2012/12/03 11:10:55, nicoe wrote: > http://codereview.tryton.org/590006/diff/10001/tryton/gui/window/view_form/view/list_gtk/editabletree.py > File tryton/gui/window/view_form/view/list_gtk/editabletree.py (right): > > http://codereview.tryton.org/590006/diff/10001/tryton/gui/window/view_form/view/list_gtk/editabletree.py#newcode91 > ...
1 year, 10 months ago (2012-12-04 14:16:18 UTC) #9
nicoe
1 year, 6 months ago (2013-03-18 07:06:25 UTC) #10
ced
http://codereview.tryton.org/590006/diff/12001/tryton/gui/window/view_form/view/list_gtk/editabletree.py File tryton/gui/window/view_form/view/list_gtk/editabletree.py (right): http://codereview.tryton.org/590006/diff/12001/tryton/gui/window/view_form/view/list_gtk/editabletree.py#newcode91 tryton/gui/window/view_form/view/list_gtk/editabletree.py:91: and (len(model) >= self.screen.size_limit) >= 0): wrong test parenthesis: ...
1 year, 6 months ago (2013-03-18 17:29:18 UTC) #11
nicoe
1 year, 6 months ago (2013-03-20 10:14:33 UTC) #12
ced
1 year, 6 months ago (2013-03-20 14:14:39 UTC) #13
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1439:a6bf440b5845