Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Issue 10851002: account: Preserve the user-supplied date on account moves when it's valid (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 6 months ago by RaphaelHertzog
Modified:
7 years, 6 months ago
Reviewers:
rietveld-bot, ced
Visibility:
Public.

Description

If the user-supplied date is within the current period, then it needs to be preserved. Otherwise we keep the current logic of using the last line of the journal, or, failing that, the start period. issue4475

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix coding style and invert test #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M move.py View 1 1 chunk +5 lines, -0 lines 2 comments Download

Messages

Total messages: 10
RaphaelHertzog
7 years, 6 months ago (2015-02-02 10:17:56 UTC) #1
reviewbot
Review's title does not follow the convention: '^([A-Za-z_][\w\.-]+)( [0-9.]+)?:'
7 years, 6 months ago (2015-02-02 10:20:12 UTC) #2
nicoe
http://codereview.tryton.org/10851002/diff/1/move.py File move.py (right): http://codereview.tryton.org/10851002/diff/1/move.py#newcode161 move.py:161: or date > self.period.end_date): The project differs from the ...
7 years, 6 months ago (2015-02-02 10:42:41 UTC) #3
ced
http://codereview.tryton.org/10851002/diff/1/move.py File move.py (right): http://codereview.tryton.org/10851002/diff/1/move.py#newcode161 move.py:161: or date > self.period.end_date): Coding style uses fixed 4 ...
7 years, 6 months ago (2015-02-02 10:44:18 UTC) #4
RaphaelHertzog
7 years, 6 months ago (2015-02-02 10:52:00 UTC) #5
RaphaelHertzog
http://codereview.tryton.org/10851002/diff/1/move.py File move.py (right): http://codereview.tryton.org/10851002/diff/1/move.py#newcode161 move.py:161: or date > self.period.end_date): On 2015/02/02 10:44:18, ced wrote: ...
7 years, 6 months ago (2015-02-02 10:53:24 UTC) #6
reviewbot
http://codereview.tryton.org/10851002/diff/20001/move.py File move.py (right): http://codereview.tryton.org/10851002/diff/20001/move.py#newcode76 move.py:76: }) E131 continuation line unaligned for hanging indent http://codereview.tryton.org/10851002/diff/20001/move.py#newcode859 ...
7 years, 6 months ago (2015-02-02 11:00:31 UTC) #7
ced
LGTM
7 years, 6 months ago (2015-02-02 11:16:34 UTC) #8
rietveld-bot_tryton.org
New changeset 35c0ddb4dc57 by Rapha?l Hertzog in branch 'default': Preserve the user-supplied date on account ...
7 years, 6 months ago (2015-02-02 17:44:31 UTC) #9
rietveld-bot_tryton.org
7 years, 6 months ago (2015-02-09 23:23:53 UTC) #10
New changeset 32ceadcd01cd by Rapha?l Hertzog in branch '3.4':
Preserve the user-supplied date on account moves when it's valid
http://hg.tryton.org/modules/account/rev/32ceadcd01cd


New changeset d5ed16b42907 by Rapha?l Hertzog in branch '3.2':
Preserve the user-supplied date on account moves when it's valid
http://hg.tryton.org/modules/account/rev/d5ed16b42907


New changeset d2014a8b38b0 by Rapha?l Hertzog in branch '3.0':
Preserve the user-supplied date on account moves when it's valid
http://hg.tryton.org/modules/account/rev/d2014a8b38b0


New changeset 6f64565f7092 by Rapha?l Hertzog in branch '2.8':
Preserve the user-supplied date on account moves when it's valid
http://hg.tryton.org/modules/account/rev/6f64565f7092


New changeset 3c982b595164 by Rapha?l Hertzog in branch '2.6':
Preserve the user-supplied date on account moves when it's valid
http://hg.tryton.org/modules/account/rev/3c982b595164
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted