account: Preserve the user-supplied date on account moves when it's valid

If the user-supplied date is within the current period, then it needs
to be preserved. Otherwise we keep the current logic of using the last
line of the journal, or, failing that, the start period.
    
issue4475

[reviewbot, 2015-02-02 10:20:12]

Review's title does not follow the convention: '^([A-Za-z_][\w\.-]+)(
[0-9.]+)?:'

[nicoe, 2015-02-02 10:42:41]

http://codereview.tryton.org/10851002/diff/1/move.py
File move.py (right):

http://codereview.tryton.org/10851002/diff/1/move.py#newcode161
move.py:161: or date > self.period.end_date):
The project differs from the pep8 on this case.
We do hanging indents here.

[ced, 2015-02-02 10:44:18]

http://codereview.tryton.org/10851002/diff/1/move.py
File move.py (right):

http://codereview.tryton.org/10851002/diff/1/move.py#newcode161
move.py:161: or date > self.period.end_date):
Coding style uses fixed 4 spaces indentation.

http://codereview.tryton.org/10851002/diff/1/move.py#newcode161
move.py:161: or date > self.period.end_date):
Is not more readable:

not (self.period.start_date <= date <= self.period.end_date)

[RaphaelHertzog, 2015-02-02 10:53:24]

http://codereview.tryton.org/10851002/diff/1/move.py
File move.py (right):

http://codereview.tryton.org/10851002/diff/1/move.py#newcode161
move.py:161: or date > self.period.end_date):
On 2015/02/02 10:44:18, ced wrote:
> Is not more readable:
> 
> not (self.period.start_date <= date <= self.period.end_date)

Done. And fixed the coding style.

[reviewbot, 2015-02-02 11:00:31]

http://codereview.tryton.org/10851002/diff/20001/move.py
File move.py (right):

http://codereview.tryton.org/10851002/diff/20001/move.py#newcode76
move.py:76: })
E131 continuation line unaligned for hanging indent

http://codereview.tryton.org/10851002/diff/20001/move.py#newcode859
move.py:859: tax_code = getattr(tax_line['tax'], key + '_tax_code')
E127 continuation line over-indented for visual indent

[ced, 2015-02-02 11:16:34]

LGTM

[rietveld-bot_tryton.org, 2015-02-02 17:44:31]

New changeset 35c0ddb4dc57 by Rapha?l Hertzog in branch 'default':
Preserve the user-supplied date on account moves when it's valid
http://hg.tryton.org/modules/account/rev/35c0ddb4dc57

[rietveld-bot_tryton.org, 2015-02-09 23:23:53]

New changeset 32ceadcd01cd by Rapha?l Hertzog in branch '3.4':
Preserve the user-supplied date on account moves when it's valid
http://hg.tryton.org/modules/account/rev/32ceadcd01cd


New changeset d5ed16b42907 by Rapha?l Hertzog in branch '3.2':
Preserve the user-supplied date on account moves when it's valid
http://hg.tryton.org/modules/account/rev/d5ed16b42907


New changeset d2014a8b38b0 by Rapha?l Hertzog in branch '3.0':
Preserve the user-supplied date on account moves when it's valid
http://hg.tryton.org/modules/account/rev/d2014a8b38b0


New changeset 6f64565f7092 by Rapha?l Hertzog in branch '2.8':
Preserve the user-supplied date on account moves when it's valid
http://hg.tryton.org/modules/account/rev/6f64565f7092


New changeset 3c982b595164 by Rapha?l Hertzog in branch '2.6':
Preserve the user-supplied date on account moves when it's valid
http://hg.tryton.org/modules/account/rev/3c982b595164