Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1716)

Issue 12011002: account_statement_sepa: Implementation of the CAMT053 blueprint

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 7 months ago by nicoe
Modified:
2 years, 4 months ago
Reviewers:
Okko, reviewbot
Visibility:
Public.

Description

https://code.google.com/p/tryton/wiki/CAMT053 issue4658 depends on review13121002 and review7081002

Patch Set 1 #

Patch Set 2 : Split review in three parts #

Patch Set 3 : Batter handling of statement journal bank accounts #

Total comments: 6

Patch Set 4 : Allow to process multiple statements in the same file #

Total comments: 6

Patch Set 5 : Fix flake8 #

Total comments: 4

Patch Set 6 : Handle currency, entry_reference, and do not validate #

Total comments: 3

Patch Set 7 : Open statements once the message is done #

Total comments: 3

Patch Set 8 : update to tip and use another design to store camt053 entries #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1938 lines, -0 lines) Patch
A .drone.yml View 1 2 3 4 5 6 7 1 chunk +9 lines, -0 lines 0 comments Download
A CHANGELOG View 1 1 chunk +1 line, -0 lines 0 comments Download
A COPYRIGHT View 1 1 chunk +15 lines, -0 lines 0 comments Download
A INSTALL View 1 1 chunk +38 lines, -0 lines 0 comments Download
A LICENSE View 1 1 chunk +674 lines, -0 lines 0 comments Download
A MANIFEST.in View 1 1 chunk +14 lines, -0 lines 0 comments Download
A README View 1 1 chunk +35 lines, -0 lines 0 comments Download
A __init__.py View 1 2 3 4 5 6 7 1 chunk +18 lines, -0 lines 0 comments Download
A account.py View 1 1 chunk +37 lines, -0 lines 0 comments Download
A account.xml View 1 1 chunk +12 lines, -0 lines 0 comments Download
A message.py View 1 2 3 4 5 6 7 1 chunk +139 lines, -0 lines 0 comments Download
A message.xml View 1 2 3 4 5 6 7 1 chunk +10 lines, -0 lines 0 comments Download
A sepa_handler.py View 1 2 3 4 5 6 7 1 chunk +254 lines, -0 lines 0 comments Download
A setup.py View 1 2 3 4 5 6 7 1 chunk +125 lines, -0 lines 0 comments Download
A tests/__init__.py View 1 1 chunk +6 lines, -0 lines 0 comments Download
A tests/camt.053.001.02.xml View 1 1 chunk +162 lines, -0 lines 0 comments Download
A tests/doctest_camt.xml View 1 2 3 4 5 1 chunk +82 lines, -0 lines 0 comments Download
A tests/scenario_account_statement_sepa.rst View 1 2 3 4 5 6 7 1 chunk +177 lines, -0 lines 0 comments Download
A tests/test_account_statement_sepa.py View 1 2 3 4 5 6 7 1 chunk +25 lines, -0 lines 0 comments Download
A tox.ini View 1 2 3 4 5 6 7 1 chunk +17 lines, -0 lines 0 comments Download
A tryton.cfg View 1 1 chunk +13 lines, -0 lines 0 comments Download
A view/camt053_line_dialog_form.xml View 1 2 3 4 5 6 7 1 chunk +26 lines, -0 lines 0 comments Download
A view/camt053_line_form.xml View 1 2 3 4 5 6 1 chunk +28 lines, -0 lines 0 comments Download
A view/camt053_line_tree.xml View 1 2 3 4 5 6 1 chunk +12 lines, -0 lines 0 comments Download
A view/statement_journal_form.xml View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14
nicoe
3 years, 7 months ago (2015-03-19 15:05:05 UTC) #1
reviewbot
patch is not applicable
3 years, 7 months ago (2015-03-19 15:10:43 UTC) #2
ced
Please don't make nested patch when there is few modules. We need flake8 running.
3 years, 7 months ago (2015-03-19 15:30:40 UTC) #3
nicoe
On 2015/03/19 15:30:40, ced wrote: > Please don't make nested patch when there is few ...
3 years, 7 months ago (2015-03-19 15:32:53 UTC) #4
ced
On 2015/03/19 15:32:53, nicoe wrote: > On 2015/03/19 15:30:40, ced wrote: > > Please don't ...
3 years, 7 months ago (2015-03-19 16:04:13 UTC) #5
Okko
3 years, 6 months ago (2015-03-25 12:41:49 UTC) #6
reviewbot
patch is not applicable
3 years, 6 months ago (2015-03-31 16:10:32 UTC) #7
reviewbot
http://codereview.tryton.org/12011002/diff/40001/__init__.py File __init__.py (right): http://codereview.tryton.org/12011002/diff/40001/__init__.py#newcode5 __init__.py:5: from .message import * F403 'from message import *' ...
3 years, 6 months ago (2015-04-01 10:40:36 UTC) #8
reviewbot
http://codereview.tryton.org/12011002/diff/60001/__init__.py File __init__.py (right): http://codereview.tryton.org/12011002/diff/60001/__init__.py#newcode5 __init__.py:5: from .message import * F403 'from message import *' ...
3 years, 6 months ago (2015-04-01 10:50:20 UTC) #9
reviewbot
http://codereview.tryton.org/12011002/diff/70001/__init__.py File __init__.py (right): http://codereview.tryton.org/12011002/diff/70001/__init__.py#newcode5 __init__.py:5: from .message import * F403 'from message import *' ...
3 years, 6 months ago (2015-04-01 11:30:19 UTC) #10
reviewbot
http://codereview.tryton.org/12011002/diff/90001/__init__.py File __init__.py (right): http://codereview.tryton.org/12011002/diff/90001/__init__.py#newcode5 __init__.py:5: from .message import * F403 'from message import *' ...
3 years, 6 months ago (2015-04-01 17:10:25 UTC) #11
reviewbot
http://codereview.tryton.org/12011002/diff/110001/__init__.py File __init__.py (right): http://codereview.tryton.org/12011002/diff/110001/__init__.py#newcode5 __init__.py:5: from .message import * F403 'from message import *' ...
3 years, 6 months ago (2015-04-02 09:00:22 UTC) #12
nicoe
update to tip and use another design to store camt053 entries
2 years, 4 months ago (2016-06-01 15:50:17 UTC) #13
reviewbot
2 years, 4 months ago (2016-06-01 16:01:07 UTC) #14
https://codereview.tryton.org/12011002/diff/130001/__init__.py#newcode5
__init__.py:5:
F403 'from message import *' used; unable to detect undefined names

https://codereview.tryton.org/12011002/diff/130001/__init__.py#newcode6
__init__.py:6:
F403 'from account import *' used; unable to detect undefined names

URL: https://codereview.tryton.org/12011002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766