Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(61)

Issue 12011002: tryton-env: Add account_statment_sepa module (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by nicoe
Modified:
4 months, 2 weeks ago
Reviewers:
rietveld-bot, Okko, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Split review in three parts #

Patch Set 3 : Batter handling of statement journal bank accounts #

Total comments: 6

Patch Set 4 : Allow to process multiple statements in the same file #

Total comments: 6

Patch Set 5 : Fix flake8 #

Total comments: 4

Patch Set 6 : Handle currency, entry_reference, and do not validate #

Total comments: 3

Patch Set 7 : Open statements once the message is done #

Total comments: 3

Patch Set 8 : update to tip and use another design to store camt053 entries #

Patch Set 9 : Rework for issue5882 #

Patch Set 10 : Support CAMT.054 and update doc #

Patch Set 11 : Ignore statement without entry #

Patch Set 12 : Update to tip #

Patch Set 13 : Update to tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1656 lines, -0 lines) Patch
M .hgsub View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
A modules/account_statement_sepa/.drone.yml View 1 2 3 4 5 6 7 8 1 chunk +78 lines, -0 lines 0 comments Download
A modules/account_statement_sepa/.flake8 View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
A modules/account_statement_sepa/.isort.cfg View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
A modules/account_statement_sepa/COPYRIGHT View 1 2 3 4 5 6 7 8 1 chunk +16 lines, -0 lines 0 comments Download
A modules/account_statement_sepa/LICENSE View 1 2 3 4 5 6 7 8 1 chunk +674 lines, -0 lines 0 comments Download
A modules/account_statement_sepa/MANIFEST.in View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -0 lines 0 comments Download
A modules/account_statement_sepa/README.rst View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
A modules/account_statement_sepa/__init__.py View 1 2 3 4 5 6 7 8 1 chunk +17 lines, -0 lines 0 comments Download
A modules/account_statement_sepa/account.py View 1 2 3 4 5 6 7 8 9 10 1 chunk +222 lines, -0 lines 0 comments Download
A modules/account_statement_sepa/account.xml View 1 2 3 4 5 6 7 8 1 chunk +112 lines, -0 lines 0 comments Download
A modules/account_statement_sepa/doc/conf.py View 1 2 3 4 5 6 7 8 1 chunk +61 lines, -0 lines 0 comments Download
A modules/account_statement_sepa/doc/index.rst View 1 2 3 4 5 6 7 8 9 1 chunk +6 lines, -0 lines 0 comments Download
A modules/account_statement_sepa/setup.py View 1 2 3 4 5 6 7 8 9 1 chunk +155 lines, -0 lines 0 comments Download
A modules/account_statement_sepa/tests/__init__.py View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
A modules/account_statement_sepa/tests/camt.053.001.02.xml View 1 2 3 4 5 6 7 8 1 chunk +139 lines, -0 lines 0 comments Download
A modules/account_statement_sepa/tests/scenario_account_statement_sepa.rst View 1 2 3 4 5 6 7 8 1 chunk +115 lines, -0 lines 0 comments Download
A modules/account_statement_sepa/tests/test_module.py View 1 2 3 4 5 6 7 8 1 chunk +11 lines, -0 lines 0 comments Download
A modules/account_statement_sepa/tests/test_scenario.py View 1 2 3 4 5 6 7 8 1 chunk +8 lines, -0 lines 0 comments Download
A modules/account_statement_sepa/tox.ini View 1 2 3 4 5 6 7 8 1 chunk +17 lines, -0 lines 0 comments Download
A modules/account_statement_sepa/tryton.cfg View 1 2 3 4 5 6 7 8 1 chunk +8 lines, -0 lines 0 comments Download
M readthedocs/account.rst View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 27
nicoe
7 years, 10 months ago (2015-03-19 15:05:05 UTC) #1
reviewbot
patch is not applicable
7 years, 10 months ago (2015-03-19 15:10:43 UTC) #2
ced
Please don't make nested patch when there is few modules. We need flake8 running.
7 years, 10 months ago (2015-03-19 15:30:40 UTC) #3
nicoe
On 2015/03/19 15:30:40, ced wrote: > Please don't make nested patch when there is few ...
7 years, 10 months ago (2015-03-19 15:32:53 UTC) #4
ced
On 2015/03/19 15:32:53, nicoe wrote: > On 2015/03/19 15:30:40, ced wrote: > > Please don't ...
7 years, 10 months ago (2015-03-19 16:04:13 UTC) #5
Okko
7 years, 10 months ago (2015-03-25 12:41:49 UTC) #6
reviewbot
patch is not applicable
7 years, 10 months ago (2015-03-31 16:10:32 UTC) #7
reviewbot
http://codereview.tryton.org/12011002/diff/40001/__init__.py File __init__.py (right): http://codereview.tryton.org/12011002/diff/40001/__init__.py#newcode5 __init__.py:5: from .message import * F403 'from message import *' ...
7 years, 10 months ago (2015-04-01 10:40:36 UTC) #8
reviewbot
http://codereview.tryton.org/12011002/diff/60001/__init__.py File __init__.py (right): http://codereview.tryton.org/12011002/diff/60001/__init__.py#newcode5 __init__.py:5: from .message import * F403 'from message import *' ...
7 years, 10 months ago (2015-04-01 10:50:20 UTC) #9
reviewbot
http://codereview.tryton.org/12011002/diff/70001/__init__.py File __init__.py (right): http://codereview.tryton.org/12011002/diff/70001/__init__.py#newcode5 __init__.py:5: from .message import * F403 'from message import *' ...
7 years, 10 months ago (2015-04-01 11:30:19 UTC) #10
reviewbot
http://codereview.tryton.org/12011002/diff/90001/__init__.py File __init__.py (right): http://codereview.tryton.org/12011002/diff/90001/__init__.py#newcode5 __init__.py:5: from .message import * F403 'from message import *' ...
7 years, 10 months ago (2015-04-01 17:10:25 UTC) #11
reviewbot
http://codereview.tryton.org/12011002/diff/110001/__init__.py File __init__.py (right): http://codereview.tryton.org/12011002/diff/110001/__init__.py#newcode5 __init__.py:5: from .message import * F403 'from message import *' ...
7 years, 10 months ago (2015-04-02 09:00:22 UTC) #12
nicoe
update to tip and use another design to store camt053 entries
6 years, 8 months ago (2016-06-01 15:50:17 UTC) #13
reviewbot
https://codereview.tryton.org/12011002/diff/130001/__init__.py#newcode5 __init__.py:5: F403 'from message import *' used; unable to detect undefined names https://codereview.tryton.org/12011002/diff/130001/__init__.py#newcode6 __init__.py:6: ...
6 years, 8 months ago (2016-06-01 16:01:07 UTC) #14
ced
6 months, 3 weeks ago (2022-07-14 12:19:02 UTC) #15
reviewbot
patch is not applicable URL: https://codereview.tryton.org/12011002
6 months, 3 weeks ago (2022-07-14 12:53:42 UTC) #16
ced
6 months, 3 weeks ago (2022-07-14 14:24:03 UTC) #17
reviewbot
patch is not applicable URL: https://codereview.tryton.org/12011002
6 months, 3 weeks ago (2022-07-14 14:55:57 UTC) #18
ced
6 months, 2 weeks ago (2022-07-18 08:43:00 UTC) #19
reviewbot
patch is not applicable URL: https://codereview.tryton.org/12011002
6 months, 2 weeks ago (2022-07-18 08:53:42 UTC) #20
ced
5 months, 1 week ago (2022-08-26 16:14:12 UTC) #21
reviewbot
patch is not applicable URL: https://codereview.tryton.org/12011002
5 months, 1 week ago (2022-08-26 16:43:20 UTC) #22
ced
4 months, 2 weeks ago (2022-09-18 12:35:05 UTC) #23
reviewbot
checks OK URL: https://codereview.tryton.org/12011002
4 months, 2 weeks ago (2022-09-18 12:43:10 UTC) #24
rietveld-bot_tryton.org
New changeset 31d963d802f8 by Cédric Krier in branch 'default': Add account_statment_sepa module https://hg.tryton.org/modules/account_statement_sepa/rev/31d963d802f8
4 months, 2 weeks ago (2022-09-18 13:58:30 UTC) #25
rietveld-bot_tryton.org
New changeset 88ebc8344dda by Cédric Krier in branch 'default': Add account_statment_sepa module https://hg.tryton.org/readthedocs/rev/88ebc8344dda
4 months, 2 weeks ago (2022-09-18 13:58:40 UTC) #26
rietveld-bot_tryton.org
4 months, 2 weeks ago (2022-09-18 13:58:40 UTC) #27
New changeset 4932ad9cd590 by Cédric Krier in branch 'default':
Add account_statment_sepa module
https://hg.tryton.org/tryton-env/rev/4932ad9cd590
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted