Issue 14391003: tryton: Fix domain inversion evaluation of constrained field

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14391003: tryton: Fix domain inversion evaluation of constrained field (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 5 months ago by ced

Modified:
9 years, 4 months ago

Reviewers:
nicoe

Visibility:
Public.

More Reviews

Description

The evaluation to True of constrained clause should only be done for inversion. Also it should be valid even if a wrong value is defined in the context. issue4073

Patch Set 2 : Update to tip #

Total comments: 3

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -9 lines)			Patch
	M	tryton/common/domain_inversion.py	View		4 chunks	+14 lines, -9 lines	3 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Paranoid Review Bot

http://codereview.tryton.org/14391003/diff/1/tryton/common/domain_inversion.py File tryton/common/domain_inversion.py (right): http://codereview.tryton.org/14391003/diff/1/tryton/common/domain_inversion.py#newcode298 tryton/common/domain_inversion.py:298: or constrained_leaf(part, operator.or_))): E127 continuation line over-indented for visual ...

9 years, 5 months ago (2014-07-19 23:11:41 UTC) #2

Paranoid Review Bot

9 years, 4 months ago (2014-07-29 11:14:12 UTC) #4

http://codereview.tryton.org/14391003/diff/20001/tryton/common/domain_inversi...
File tryton/common/domain_inversion.py (right):

http://codereview.tryton.org/14391003/diff/20001/tryton/common/domain_inversi...
tryton/common/domain_inversion.py:1: #This file is part of Tryton.  The
COPYRIGHT file at the top level of
E265 block comment should start with '# '

http://codereview.tryton.org/14391003/diff/20001/tryton/common/domain_inversi...
tryton/common/domain_inversion.py:2: #this repository contains the full
copyright notices and license terms.
E265 block comment should start with '# '

http://codereview.tryton.org/14391003/diff/20001/tryton/common/domain_inversi...
tryton/common/domain_inversion.py:298: or constrained_leaf(part,
operator.or_))):
E127 continuation line over-indented for visual indent

Expand All Messages | Collapse All Messages