Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(40)

Issue 17021002: tryton: Allow to browse history right before a revision

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years ago by jean.cavallo
Modified:
4 months, 3 weeks ago
Visibility:
Public.

Description

issue4498 COLLABORATOR=nicolas.evrard@b2ck.com

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fix style #

Patch Set 3 : Proper alignment, use datetime_included #

Total comments: 4

Patch Set 4 : Update to tip + fix remarks #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M CHANGELOG View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M tryton/gui/window/form.py View 1 2 3 1 chunk +7 lines, -3 lines 0 comments Download
M tryton/gui/window/revision.py View 1 2 3 5 chunks +14 lines, -3 lines 1 comment Download

Messages

Total messages: 11
pokoli
https://tryton-rietveld.appspot.com/17021002/diff/1/tryton/gui/window/form.py File tryton/gui/window/form.py (right): https://tryton-rietveld.appspot.com/17021002/diff/1/tryton/gui/window/form.py#newcode274 tryton/gui/window/form.py:274: if revision != self.screen.context.get('_datetime') or \ Better surrounded in ...
7 years ago (2016-01-29 11:44:43 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/17021002
7 years ago (2016-01-29 11:46:19 UTC) #2
jean.cavallo
https://tryton-rietveld.appspot.com/17021002/diff/1/tryton/gui/window/form.py File tryton/gui/window/form.py (right): https://tryton-rietveld.appspot.com/17021002/diff/1/tryton/gui/window/form.py#newcode274 tryton/gui/window/form.py:274: if revision != self.screen.context.get('_datetime') or \ On 2016/01/29 11:44:43, ...
7 years ago (2016-01-29 11:49:33 UTC) #3
ced
https://tryton-rietveld.appspot.com/17021002/diff/1/tryton/gui/window/revision.py File tryton/gui/window/revision.py (right): https://tryton-rietveld.appspot.com/17021002/diff/1/tryton/gui/window/revision.py#newcode17 tryton/gui/window/revision.py:17: def __init__(self, revisions, revision=None, before=False, Why not appending? https://tryton-rietveld.appspot.com/17021002/diff/1/tryton/gui/window/revision.py#newcode65 ...
7 years ago (2016-01-29 11:55:32 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/17021002
7 years ago (2016-01-29 12:01:31 UTC) #5
jean.cavallo
https://tryton-rietveld.appspot.com/17021002/diff/1/tryton/gui/window/revision.py File tryton/gui/window/revision.py (right): https://tryton-rietveld.appspot.com/17021002/diff/1/tryton/gui/window/revision.py#newcode17 tryton/gui/window/revision.py:17: def __init__(self, revisions, revision=None, before=False, On 2016/01/29 11:55:32, ced ...
7 years ago (2016-01-29 16:47:18 UTC) #6
reviewbot
flake8 OK URL: https://codereview.tryton.org/17021002
7 years ago (2016-01-29 16:47:43 UTC) #7
ced
Missing changelog https://tryton-rietveld.appspot.com/17021002/diff/40001/tryton/gui/window/form.py File tryton/gui/window/form.py (right): https://tryton-rietveld.appspot.com/17021002/diff/40001/tryton/gui/window/form.py#newcode275 tryton/gui/window/form.py:275: if revision != cur_revision or included != ...
7 years ago (2016-01-29 17:22:48 UTC) #8
nicoe
6 months, 3 weeks ago (2022-07-13 16:05:39 UTC) #9
reviewbot
checks OK URL: https://codereview.tryton.org/17021002
6 months, 3 weeks ago (2022-07-13 16:24:02 UTC) #10
ced
4 months, 3 weeks ago (2022-09-11 22:17:50 UTC) #11
https://codereview.tryton.org/17021002/diff/431351003/tryton/gui/window/revis...
File tryton/gui/window/revision.py (right):

https://codereview.tryton.org/17021002/diff/431351003/tryton/gui/window/revis...
tryton/gui/window/revision.py:82: include_revision_label =
Gtk.Label(label=_('Include Revision:'))
I think it is better to have an Exclude checkbox.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted