Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(595)

Issue 18021003: account_asset: correctly set the bymonth value to the previous month of the start date (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 9 months ago by nicoe
Modified:
3 weeks, 1 day ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -4 lines) Patch
M asset.py View 1 2 chunks +4 lines, -3 lines 0 comments Download
M tests/test_account_asset.py View 1 2 chunks +29 lines, -1 line 0 comments Download

Messages

Total messages: 5
nicoe
2 years, 9 months ago (2016-04-20 08:07:01 UTC) #1
reviewbot
https://codereview.tryton.org/18021003/diff/1/asset.py#newcode49 asset.py:49: E711 comparison to None should be 'if cond is None:' URL: https://codereview.tryton.org/18021003
2 years, 9 months ago (2016-04-20 08:30:19 UTC) #2
ced
We should add a test
2 years, 9 months ago (2016-04-20 09:10:12 UTC) #3
nicoe
Add tests
2 years, 7 months ago (2016-06-07 16:49:05 UTC) #4
reviewbot
2 years, 7 months ago (2016-06-07 17:00:55 UTC) #5
https://codereview.tryton.org/18021003/diff/20001/asset.py#newcode49
asset.py:49:
E711 comparison to None should be 'if cond is None:'

URL: https://codereview.tryton.org/18021003
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766