Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(880)

Issue 21241002: party_siret: Use PartyIdentifier to store SIREN value

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 8 months ago by nicoe
Modified:
2 years, 8 months ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add handling of SIRET and validation of uniqueness of the SIREN #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -60 lines) Patch
M CHANGELOG View 1 chunk +2 lines, -0 lines 0 comments Download
M __init__.py View 1 chunk +1 line, -1 line 0 comments Download
M address.py View 1 1 chunk +4 lines, -2 lines 1 comment Download
M party.py View 1 1 chunk +61 lines, -21 lines 1 comment Download
R party.xml View 1 chunk +0 lines, -17 lines 0 comments Download
M tryton.cfg View 1 chunk +0 lines, -1 line 0 comments Download
R view/party_form.xml View 1 chunk +0 lines, -10 lines 0 comments Download
R view/party_tree.xml View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6
nicoe
2 years, 8 months ago (2016-08-28 17:27:11 UTC) #1
reviewbot
https://codereview.tryton.org/21241002/diff/1/__init__.py#newcode5 __init__.py:5: F403 'from party import *' used; unable to detect undefined names https://codereview.tryton.org/21241002/diff/1/__init__.py#newcode6 __init__.py:6: ...
2 years, 8 months ago (2016-08-28 17:55:54 UTC) #2
ced
What about siret on address? It is probably good to have tests. https://tryton-rietveld.appspot.com/21241002/diff/1/party.py File party.py ...
2 years, 8 months ago (2016-09-02 08:45:23 UTC) #3
nicoe
Add handling of SIRET and validation of uniqueness of the SIREN
2 years, 8 months ago (2016-09-16 21:17:22 UTC) #4
reviewbot
https://codereview.tryton.org/21241002/diff/20001/__init__.py#newcode5 __init__.py:5: F403 'from party import *' used; unable to detect undefined names https://codereview.tryton.org/21241002/diff/20001/__init__.py#newcode6 __init__.py:6: ...
2 years, 8 months ago (2016-09-16 21:27:32 UTC) #5
ced
2 years, 8 months ago (2016-09-18 10:03:38 UTC) #6
https://tryton-rietveld.appspot.com/21241002/diff/20001/address.py
File address.py (right):

https://tryton-rietveld.appspot.com/21241002/diff/20001/address.py#newcode31
address.py:31: party_siren = party_sirens[0].code if party_sirens else None
I think it will be better to have such function on Party.

https://tryton-rietveld.appspot.com/21241002/diff/20001/party.py
File party.py (right):

https://tryton-rietveld.appspot.com/21241002/diff/20001/party.py#newcode80
party.py:80: having=Count(Literal(1)) > 1))
This does not work on concurrent system.
Indeed it should be a partial unique constraint.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766