Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2099)

Issue 24111002: Function-field bug in 3.4: _ids include active records

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 1 month ago by jonl
Modified:
3 years, 1 month ago
Reviewers:
reviewbot
Visibility:
Public.

Description

issue5454 Discussion[1] notes two function-field bugs in 3.4. The second (assert id in _ids) results from ModelStorage.instantiate passing a list of active records (rather than a list of ids) as the _ids argument to the model class's __init__. This patch clarifies the problem and "fixes" the bug, though a better fix probably lies in correcting instantiate. [1] https://groups.google.com/forum/#!msg/tryton/4EB9PB2-hzM/ne33IFqTEAAJ

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M trytond/model/modelstorage.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2
jonl
3 years, 1 month ago (2016-04-03 19:13:42 UTC) #1
reviewbot
3 years, 1 month ago (2016-04-03 19:30:10 UTC) #2
Review's title does not follow the convention: '^([A-Za-z_][\w\.-]+)(
[0-9.]+)?:'
URL: https://codereview.tryton.org/24111002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766