Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2168)

Issue 251121002: product_cost_fifo: Convert cost price into move uom to compute average cost price (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 2 weeks ago by ced
Modified:
1 month, 3 weeks ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

The unit price is always expressed in the unit of the move but the cost price is computed in the default uom. issue7918

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -16 lines) Patch
M move.py View 1 chunk +2 lines, -1 line 0 comments Download
A tests/scenario_product_cost_fifo_uom.rst View 6 chunks +16 lines, -15 lines 2 comments Download
M tests/test_product_cost_fifo.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8
ced
2 months, 2 weeks ago (2019-03-10 19:04:08 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/251121002
2 months, 2 weeks ago (2019-03-10 19:14:29 UTC) #2
pokoli
It seems that the test scenario haven't been correctly uploaded. Could you please reupload?
2 months, 1 week ago (2019-03-15 15:07:14 UTC) #3
ced
On 2019/03/15 15:07:14, pokoli wrote: > It seems that the test scenario haven't been correctly ...
2 months, 1 week ago (2019-03-15 15:22:19 UTC) #4
pokoli
https://codereview.tryton.org/251121002/diff/279071002/tests/scenario_product_cost_fifo_uom.rst File tests/scenario_product_cost_fifo_uom.rst (right): https://codereview.tryton.org/251121002/diff/279071002/tests/scenario_product_cost_fifo_uom.rst#newcode71 tests/scenario_product_cost_fifo_uom.rst:71: Add 2000 more g @ 25:: it should be ...
2 months, 1 week ago (2019-03-15 16:58:03 UTC) #5
ced
https://codereview.tryton.org/251121002/diff/279071002/tests/scenario_product_cost_fifo_uom.rst File tests/scenario_product_cost_fifo_uom.rst (right): https://codereview.tryton.org/251121002/diff/279071002/tests/scenario_product_cost_fifo_uom.rst#newcode71 tests/scenario_product_cost_fifo_uom.rst:71: Add 2000 more g @ 25:: On 2019/03/15 16:58:03, ...
2 months, 1 week ago (2019-03-15 17:12:12 UTC) #6
rietveld-bot_tryton.org
New changeset 0e32a0ae4a16 by Cédric Krier in branch 'default': Convert cost price into move uom ...
2 months ago (2019-03-22 10:18:41 UTC) #7
rietveld-bot_tryton.org
1 month, 3 weeks ago (2019-03-28 18:57:37 UTC) #8
New changeset 96d9be7eb3a1 by Cédric Krier in branch '5.0':
Convert cost price into move uom to compute average cost price
https://hg.tryton.org/modules/product_cost_fifo/rev/96d9be7eb3a1


New changeset 7d285b9f991c by Cédric Krier in branch '4.8':
Convert cost price into move uom to compute average cost price
https://hg.tryton.org/modules/product_cost_fifo/rev/7d285b9f991c


New changeset 8511c6e7bd33 by Cédric Krier in branch '4.6':
Convert cost price into move uom to compute average cost price
https://hg.tryton.org/modules/product_cost_fifo/rev/8511c6e7bd33
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766