Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(110)

Issue 251121002: product_cost_fifo: Convert cost price into move uom to compute average cost price

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 3 days ago by ced
Modified:
5 days, 2 hours ago
Reviewers:
pokoli, reviewbot
Visibility:
Public.

Description

The unit price is always expressed in the unit of the move but the cost price is computed in the default uom. issue7918

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -16 lines) Patch
M move.py View 1 chunk +2 lines, -1 line 0 comments Download
A tests/scenario_product_cost_fifo_uom.rst View 6 chunks +16 lines, -15 lines 2 comments Download
M tests/test_product_cost_fifo.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6
ced
1 week, 3 days ago (2019-03-10 19:04:08 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/251121002
1 week, 3 days ago (2019-03-10 19:14:29 UTC) #2
pokoli
It seems that the test scenario haven't been correctly uploaded. Could you please reupload?
5 days, 4 hours ago (2019-03-15 15:07:14 UTC) #3
ced
On 2019/03/15 15:07:14, pokoli wrote: > It seems that the test scenario haven't been correctly ...
5 days, 4 hours ago (2019-03-15 15:22:19 UTC) #4
pokoli
https://codereview.tryton.org/251121002/diff/279071002/tests/scenario_product_cost_fifo_uom.rst File tests/scenario_product_cost_fifo_uom.rst (right): https://codereview.tryton.org/251121002/diff/279071002/tests/scenario_product_cost_fifo_uom.rst#newcode71 tests/scenario_product_cost_fifo_uom.rst:71: Add 2000 more g @ 25:: it should be ...
5 days, 2 hours ago (2019-03-15 16:58:03 UTC) #5
ced
5 days, 2 hours ago (2019-03-15 17:12:12 UTC) #6
https://codereview.tryton.org/251121002/diff/279071002/tests/scenario_product...
File tests/scenario_product_cost_fifo_uom.rst (right):

https://codereview.tryton.org/251121002/diff/279071002/tests/scenario_product...
tests/scenario_product_cost_fifo_uom.rst:71: Add 2000 more g @ 25::
On 2019/03/15 16:58:03, pokoli wrote:
> it should be @ 0.025

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766