Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2123)

Issue 255091002: tryton-env: Add listform view type (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 2 weeks ago by nicoe
Modified:
1 month, 1 week ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

tryton-env: Add listform view type issue8185

Patch Set 1 #

Total comments: 16

Patch Set 2 : Update to tip #

Patch Set 3 : Fix some remarks #

Patch Set 4 : Fix order of listbox when reordering with a treeview and switching to listbox afterwards #

Patch Set 5 : Small fix #

Total comments: 51

Patch Set 6 : Fix most remarks #

Patch Set 7 : Refactor usage of view_id #

Total comments: 39

Patch Set 8 : Fix remarks and a bug in sao's display #

Patch Set 9 : fix remarks and update to tip #

Total comments: 3

Patch Set 10 : Rename files and fix remarks #

Patch Set 11 : Update to tip #

Total comments: 6

Patch Set 12 : Fix remarks and better handling of focus in TextView #

Total comments: 4

Patch Set 13 : Fixed remarks #

Patch Set 14 : Activate multiple selection in GTK #

Patch Set 15 : Add multi selection on sao #

Patch Set 16 : Fix sao behaviour and made it more standard in GTK #

Patch Set 17 : Add CHANGELOG and some doc #

Patch Set 18 : Update to tip #

Total comments: 5

Patch Set 19 : Fix remarks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+416 lines, -59 lines) Patch
M modules/party/address.xml View 1 1 chunk +5 lines, -0 lines 0 comments Download
M modules/party/view/party_form.xml View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -2 lines 0 comments Download
M modules/product/view/product_form.xml View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M sao/CHANGELOG View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +1 line, -0 lines 0 comments Download
M sao/Gruntfile.js View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M sao/src/sao.less View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +8 lines, -1 line 0 comments Download
M sao/src/screen.js View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +6 lines, -5 lines 0 comments Download
M sao/src/view.js View 1 2 3 4 5 6 7 8 3 chunks +15 lines, -10 lines 0 comments Download
M sao/src/view/calendar.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +2 lines, -2 lines 0 comments Download
M sao/src/view/form.js View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M sao/src/view/graph.js View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
A sao/src/view/list_form.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +147 lines, -0 lines 0 comments Download
M sao/src/view/tree.js View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M tryton/CHANGELOG View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +1 line, -0 lines 0 comments Download
M tryton/tryton/gui/window/view_form/model/group.py View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +8 lines, -4 lines 0 comments Download
M tryton/tryton/gui/window/view_form/screen/screen.py View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +13 lines, -3 lines 0 comments Download
M tryton/tryton/gui/window/view_form/view/__init__.py View 1 2 3 4 5 6 7 8 9 2 chunks +19 lines, -15 lines 0 comments Download
M tryton/tryton/gui/window/view_form/view/calendar_.py View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M tryton/tryton/gui/window/view_form/view/form.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +2 lines, -2 lines 0 comments Download
M tryton/tryton/gui/window/view_form/view/form_gtk/textbox.py View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +9 lines, -1 line 0 comments Download
M tryton/tryton/gui/window/view_form/view/graph.py View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M tryton/tryton/gui/window/view_form/view/list.py View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +2 lines, -2 lines 0 comments Download
A tryton/tryton/gui/window/view_form/view/list_form.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +147 lines, -0 lines 0 comments Download
M trytond/CHANGELOG View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +1 line, -0 lines 0 comments Download
M trytond/doc/topics/views/index.rst View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +13 lines, -1 line 0 comments Download
M trytond/trytond/ir/ui/view.py View 1 2 3 4 5 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 62
nicoe
2 months, 2 weeks ago (2019-03-08 09:16:32 UTC) #1
reviewbot
patch is not applicable URL: https://codereview.tryton.org/255091002
2 months, 2 weeks ago (2019-03-08 09:19:42 UTC) #2
ced
https://codereview.tryton.org/255091002/diff/253091002/modules/party/view/party_form.xml File modules/party/view/party_form.xml (left): https://codereview.tryton.org/255091002/diff/253091002/modules/party/view/party_form.xml#oldcode27 modules/party/view/party_form.xml:27: view_ids="party.category_view_list"/> Should stay. https://codereview.tryton.org/255091002/diff/253091002/modules/party/view/party_form.xml File modules/party/view/party_form.xml (right): https://codereview.tryton.org/255091002/diff/253091002/modules/party/view/party_form.xml#newcode19 modules/party/view/party_form.xml:19: ...
2 months, 2 weeks ago (2019-03-08 09:43:20 UTC) #3
nicoe
https://codereview.tryton.org/255091002/diff/253091002/modules/party/view/address_listform.xml File modules/party/view/address_listform.xml (right): https://codereview.tryton.org/255091002/diff/253091002/modules/party/view/address_listform.xml#newcode3 modules/party/view/address_listform.xml:3: <form col="6"> I wonder if we couldn't use xinclude ...
2 months, 2 weeks ago (2019-03-08 12:32:40 UTC) #4
nicoe
2 months, 1 week ago (2019-03-11 18:00:24 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/255091002
2 months, 1 week ago (2019-03-11 18:18:29 UTC) #6
nicoe
https://codereview.tryton.org/255091002/diff/253091002/sao/src/sao.less File sao/src/sao.less (right): https://codereview.tryton.org/255091002/diff/253091002/sao/src/sao.less#newcode171 sao/src/sao.less:171: fieldset.listform-item { On 2019/03/08 12:32:40, nicoe wrote: > useless ...
2 months, 1 week ago (2019-03-11 20:30:15 UTC) #7
nicoe
2 months, 1 week ago (2019-03-11 20:30:39 UTC) #8
reviewbot
flake8 OK URL: https://codereview.tryton.org/255091002
2 months, 1 week ago (2019-03-11 20:51:40 UTC) #9
nicoe
2 months, 1 week ago (2019-03-12 17:40:12 UTC) #10
nicoe
2 months, 1 week ago (2019-03-12 17:46:28 UTC) #11
reviewbot
flake8 OK URL: https://codereview.tryton.org/255091002
2 months, 1 week ago (2019-03-12 17:51:19 UTC) #12
ced
https://codereview.tryton.org/255091002/diff/281101002/modules/party/view/address_listform.xml File modules/party/view/address_listform.xml (right): https://codereview.tryton.org/255091002/diff/281101002/modules/party/view/address_listform.xml#newcode1 modules/party/view/address_listform.xml:1: <?xml version="1.0"?> useless https://codereview.tryton.org/255091002/diff/281101002/modules/party/view/party_form.xml File modules/party/view/party_form.xml (right): https://codereview.tryton.org/255091002/diff/281101002/modules/party/view/party_form.xml#newcode19 modules/party/view/party_form.xml:19: ...
2 months, 1 week ago (2019-03-13 09:46:08 UTC) #13
nicoe
2 months, 1 week ago (2019-03-13 16:30:15 UTC) #14
nicoe
https://codereview.tryton.org/255091002/diff/281101002/modules/party/view/address_listform.xml File modules/party/view/address_listform.xml (right): https://codereview.tryton.org/255091002/diff/281101002/modules/party/view/address_listform.xml#newcode1 modules/party/view/address_listform.xml:1: <?xml version="1.0"?> On 2019/03/13 09:46:05, ced wrote: > useless ...
2 months, 1 week ago (2019-03-13 16:31:18 UTC) #15
reviewbot
flake8 OK URL: https://codereview.tryton.org/255091002
2 months, 1 week ago (2019-03-13 16:50:23 UTC) #16
nicoe
2 months, 1 week ago (2019-03-13 17:52:16 UTC) #17
reviewbot
flake8 OK URL: https://codereview.tryton.org/255091002
2 months, 1 week ago (2019-03-13 18:13:10 UTC) #18
ced
Missing changelog and documentation. https://codereview.tryton.org/255091002/diff/253121002/sao/src/screen.js File sao/src/screen.js (right): https://codereview.tryton.org/255091002/diff/253121002/sao/src/screen.js#newcode1238 sao/src/screen.js:1238: if (~['tree', 'form', 'listform'].indexOf(view.view_type) && ...
2 months, 1 week ago (2019-03-14 11:06:44 UTC) #19
nicoe
https://codereview.tryton.org/255091002/diff/253121002/sao/src/screen.js File sao/src/screen.js (right): https://codereview.tryton.org/255091002/diff/253121002/sao/src/screen.js#newcode1238 sao/src/screen.js:1238: if (~['tree', 'form', 'listform'].indexOf(view.view_type) && On 2019/03/14 11:06:42, ced ...
2 months, 1 week ago (2019-03-14 12:38:23 UTC) #20
nicoe
2 months, 1 week ago (2019-03-14 12:38:45 UTC) #21
reviewbot
flake8 OK URL: https://codereview.tryton.org/255091002
2 months, 1 week ago (2019-03-14 12:47:21 UTC) #22
ced
https://codereview.tryton.org/255091002/diff/253121002/sao/src/view/listform.js File sao/src/view/listform.js (right): https://codereview.tryton.org/255091002/diff/253121002/sao/src/view/listform.js#newcode48 sao/src/view/listform.js:48: if (this.screen.current_record === record) { On 2019/03/14 12:38:23, nicoe ...
2 months, 1 week ago (2019-03-14 13:07:42 UTC) #23
nicoe
2 months, 1 week ago (2019-03-14 13:29:42 UTC) #24
nicoe
https://codereview.tryton.org/255091002/diff/253121002/sao/src/view/listform.js File sao/src/view/listform.js (right): https://codereview.tryton.org/255091002/diff/253121002/sao/src/view/listform.js#newcode48 sao/src/view/listform.js:48: if (this.screen.current_record === record) { On 2019/03/14 13:07:42, ced ...
2 months, 1 week ago (2019-03-14 13:29:46 UTC) #25
reviewbot
flake8 OK URL: https://codereview.tryton.org/255091002
2 months, 1 week ago (2019-03-14 13:43:43 UTC) #26
ced
https://codereview.tryton.org/255091002/diff/261101002/sao/Gruntfile.js File sao/Gruntfile.js (right): https://codereview.tryton.org/255091002/diff/261101002/sao/Gruntfile.js#newcode19 sao/Gruntfile.js:19: 'src/view/listform.js', should be called: list_form.js https://codereview.tryton.org/255091002/diff/261101002/sao/src/view/listform.js File sao/src/view/listform.js (right): ...
2 months, 1 week ago (2019-03-14 18:32:25 UTC) #27
ced
https://codereview.tryton.org/255091002/diff/261101002/tryton/tryton/gui/window/view_form/view/__init__.py File tryton/tryton/gui/window/view_form/view/__init__.py (right): https://codereview.tryton.org/255091002/diff/261101002/tryton/tryton/gui/window/view_form/view/__init__.py#newcode68 tryton/tryton/gui/window/view_form/view/__init__.py:68: from .listform import ViewListForm should be: from .list_form
2 months, 1 week ago (2019-03-14 18:32:52 UTC) #28
nicoe
2 months ago (2019-03-18 15:57:05 UTC) #29
nicoe
2 months ago (2019-03-18 16:00:17 UTC) #30
reviewbot
flake8 OK URL: https://codereview.tryton.org/255091002
2 months ago (2019-03-18 16:13:48 UTC) #31
ced
The active record is not changed when clicking on Entry of another record. It does ...
2 months ago (2019-03-22 14:11:30 UTC) #32
ced
On sao, the form-list is not shown on opening.
2 months ago (2019-03-22 14:13:48 UTC) #33
ced
https://codereview.tryton.org/255091002/diff/273111002/sao/src/view/list_form.js File sao/src/view/list_form.js (right): https://codereview.tryton.org/255091002/diff/273111002/sao/src/view/list_form.js#newcode6 sao/src/view/list_form.js:6: Sao.View.ListBoxViewForm = Sao.class_(Sao.View.Form, { I think it should be ...
2 months ago (2019-03-22 14:35:31 UTC) #34
nicoe
1 month, 4 weeks ago (2019-03-26 16:00:42 UTC) #35
reviewbot
flake8 OK URL: https://codereview.tryton.org/255091002
1 month, 4 weeks ago (2019-03-26 16:23:14 UTC) #36
ced
https://codereview.tryton.org/255091002/diff/277161003/tryton/tryton/gui/window/view_form/screen/screen.py File tryton/tryton/gui/window/view_form/screen/screen.py (right): https://codereview.tryton.org/255091002/diff/277161003/tryton/tryton/gui/window/view_form/screen/screen.py#newcode957 tryton/tryton/gui/window/view_form/screen/screen.py:957: vadjustment.clamp_page(y_position, y_position + y_size) Is this still needed with ...
1 month, 3 weeks ago (2019-03-27 08:33:08 UTC) #37
nicoe
https://codereview.tryton.org/255091002/diff/273111002/sao/src/view/list_form.js File sao/src/view/list_form.js (right): https://codereview.tryton.org/255091002/diff/273111002/sao/src/view/list_form.js#newcode6 sao/src/view/list_form.js:6: Sao.View.ListBoxViewForm = Sao.class_(Sao.View.Form, { On 2019/03/22 14:35:31, ced wrote: ...
1 month, 3 weeks ago (2019-03-27 10:32:45 UTC) #38
nicoe
1 month, 3 weeks ago (2019-03-27 10:36:14 UTC) #39
reviewbot
flake8 OK URL: https://codereview.tryton.org/255091002
1 month, 3 weeks ago (2019-03-27 10:43:50 UTC) #40
ced
It must be possible to select many record on the list-form (in both clients). The ...
1 month, 3 weeks ago (2019-03-27 14:58:46 UTC) #41
nicoe
1 month, 3 weeks ago (2019-03-29 16:50:14 UTC) #42
reviewbot
flake8 OK URL: https://codereview.tryton.org/255091002
1 month, 3 weeks ago (2019-03-29 17:18:20 UTC) #43
nicoe
1 month, 3 weeks ago (2019-04-01 16:46:15 UTC) #44
reviewbot
flake8 OK URL: https://codereview.tryton.org/255091002
1 month, 3 weeks ago (2019-04-01 17:17:05 UTC) #45
ced
The selection does not have the same behavior as in treeview. For sao: * Shift-click ...
1 month, 3 weeks ago (2019-04-02 08:38:47 UTC) #46
nicoe
1 month, 3 weeks ago (2019-04-02 16:02:32 UTC) #47
reviewbot
flake8 OK URL: https://codereview.tryton.org/255091002
1 month, 3 weeks ago (2019-04-02 16:19:36 UTC) #48
ced
Missing documentation and changelog
1 month, 3 weeks ago (2019-04-02 16:28:57 UTC) #49
nicoe
1 month, 2 weeks ago (2019-04-03 11:27:46 UTC) #50
reviewbot
patch is not applicable URL: https://codereview.tryton.org/255091002
1 month, 2 weeks ago (2019-04-03 11:50:33 UTC) #51
nicoe
1 month, 2 weeks ago (2019-04-03 12:41:27 UTC) #52
reviewbot
flake8 OK URL: https://codereview.tryton.org/255091002
1 month, 2 weeks ago (2019-04-03 12:49:48 UTC) #53
ced
https://codereview.tryton.org/255091002/diff/275201002/sao/CHANGELOG File sao/CHANGELOG (right): https://codereview.tryton.org/255091002/diff/275201002/sao/CHANGELOG#newcode1 sao/CHANGELOG:1: * Add list-form view type According to tryton CHANGELOG, ...
1 month, 2 weeks ago (2019-04-04 08:04:29 UTC) #54
ced
1 month, 2 weeks ago (2019-04-04 08:04:32 UTC) #55
nicoe
1 month, 2 weeks ago (2019-04-04 11:47:15 UTC) #56
reviewbot
flake8 OK URL: https://codereview.tryton.org/255091002
1 month, 2 weeks ago (2019-04-04 12:11:41 UTC) #57
ced
LGTM but modules must be cleaned.
1 month, 2 weeks ago (2019-04-04 13:01:13 UTC) #58
rietveld-bot_tryton.org
New changeset e596254259df by Nicolas ?vrard in branch 'default': Add list-form view https://hg.tryton.org/sao/rev/e596254259df
1 month, 2 weeks ago (2019-04-08 13:06:48 UTC) #59
rietveld-bot_tryton.org
New changeset 66d5d0e48684 by Nicolas ?vrard in branch 'default': Add list-form view https://hg.tryton.org/tryton/rev/66d5d0e48684
1 month, 2 weeks ago (2019-04-08 13:06:52 UTC) #60
rietveld-bot_tryton.org
New changeset 9b3dd281c12b by Nicolas ?vrard in branch 'default': Add list-form view https://hg.tryton.org/trytond/rev/9b3dd281c12b
1 month, 2 weeks ago (2019-04-08 13:06:53 UTC) #61
rietveld-bot_tryton.org
1 month, 2 weeks ago (2019-04-08 13:06:58 UTC) #62
New changeset 76038ceeaa39 by Nicolas ?vrard in branch 'default':
Add list-form view
https://hg.tryton.org/tryton-env/rev/76038ceeaa39
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766