Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(71)

Issue 255091002: tryton-env: Add listform view type

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 5 days ago by nicoe
Modified:
2 days, 2 hours ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

tryton-env: Add listform view type issue8185

Patch Set 1 #

Total comments: 16

Patch Set 2 : Update to tip #

Patch Set 3 : Fix some remarks #

Patch Set 4 : Fix order of listbox when reordering with a treeview and switching to listbox afterwards #

Patch Set 5 : Small fix #

Total comments: 51

Patch Set 6 : Fix most remarks #

Patch Set 7 : Refactor usage of view_id #

Total comments: 39

Patch Set 8 : Fix remarks and a bug in sao's display #

Patch Set 9 : fix remarks and update to tip #

Total comments: 3

Patch Set 10 : Rename files and fix remarks #

Patch Set 11 : Update to tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+356 lines, -55 lines) Patch
M modules/party/address.xml View 1 1 chunk +5 lines, -0 lines 0 comments Download
M modules/party/view/party_form.xml View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sao/Gruntfile.js View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M sao/src/sao.less View 1 2 3 4 5 2 chunks +5 lines, -1 line 0 comments Download
M sao/src/screen.js View 1 2 3 4 5 6 7 8 9 10 4 chunks +6 lines, -5 lines 0 comments Download
M sao/src/view.js View 1 2 3 4 5 6 7 8 3 chunks +15 lines, -10 lines 0 comments Download
M sao/src/view/calendar.js View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M sao/src/view/form.js View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M sao/src/view/graph.js View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
A sao/src/view/list_form.js View 1 2 3 4 5 6 7 8 9 1 chunk +113 lines, -0 lines 0 comments Download
M sao/src/view/tree.js View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M tryton/tryton/gui/window/view_form/model/group.py View 1 2 3 4 5 6 7 3 chunks +7 lines, -4 lines 0 comments Download
M tryton/tryton/gui/window/view_form/screen/screen.py View 1 2 3 4 5 6 7 3 chunks +26 lines, -2 lines 0 comments Download
M tryton/tryton/gui/window/view_form/view/__init__.py View 1 2 3 4 5 6 7 8 9 2 chunks +19 lines, -15 lines 0 comments Download
M tryton/tryton/gui/window/view_form/view/calendar_.py View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M tryton/tryton/gui/window/view_form/view/form.py View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M tryton/tryton/gui/window/view_form/view/graph.py View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M tryton/tryton/gui/window/view_form/view/list.py View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
A tryton/tryton/gui/window/view_form/view/list_form.py View 1 2 3 4 5 6 7 8 9 1 chunk +138 lines, -0 lines 0 comments Download
M trytond/trytond/ir/ui/view.py View 1 2 3 4 5 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 31
nicoe
1 week, 5 days ago (2019-03-08 09:16:32 UTC) #1
reviewbot
patch is not applicable URL: https://codereview.tryton.org/255091002
1 week, 5 days ago (2019-03-08 09:19:42 UTC) #2
ced
https://codereview.tryton.org/255091002/diff/253091002/modules/party/view/party_form.xml File modules/party/view/party_form.xml (left): https://codereview.tryton.org/255091002/diff/253091002/modules/party/view/party_form.xml#oldcode27 modules/party/view/party_form.xml:27: view_ids="party.category_view_list"/> Should stay. https://codereview.tryton.org/255091002/diff/253091002/modules/party/view/party_form.xml File modules/party/view/party_form.xml (right): https://codereview.tryton.org/255091002/diff/253091002/modules/party/view/party_form.xml#newcode19 modules/party/view/party_form.xml:19: ...
1 week, 5 days ago (2019-03-08 09:43:20 UTC) #3
nicoe
https://codereview.tryton.org/255091002/diff/253091002/modules/party/view/address_listform.xml File modules/party/view/address_listform.xml (right): https://codereview.tryton.org/255091002/diff/253091002/modules/party/view/address_listform.xml#newcode3 modules/party/view/address_listform.xml:3: <form col="6"> I wonder if we couldn't use xinclude ...
1 week, 5 days ago (2019-03-08 12:32:40 UTC) #4
nicoe
1 week, 2 days ago (2019-03-11 18:00:24 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/255091002
1 week, 2 days ago (2019-03-11 18:18:29 UTC) #6
nicoe
https://codereview.tryton.org/255091002/diff/253091002/sao/src/sao.less File sao/src/sao.less (right): https://codereview.tryton.org/255091002/diff/253091002/sao/src/sao.less#newcode171 sao/src/sao.less:171: fieldset.listform-item { On 2019/03/08 12:32:40, nicoe wrote: > useless ...
1 week, 1 day ago (2019-03-11 20:30:15 UTC) #7
nicoe
1 week, 1 day ago (2019-03-11 20:30:39 UTC) #8
reviewbot
flake8 OK URL: https://codereview.tryton.org/255091002
1 week, 1 day ago (2019-03-11 20:51:40 UTC) #9
nicoe
1 week, 1 day ago (2019-03-12 17:40:12 UTC) #10
nicoe
1 week, 1 day ago (2019-03-12 17:46:28 UTC) #11
reviewbot
flake8 OK URL: https://codereview.tryton.org/255091002
1 week, 1 day ago (2019-03-12 17:51:19 UTC) #12
ced
https://codereview.tryton.org/255091002/diff/281101002/modules/party/view/address_listform.xml File modules/party/view/address_listform.xml (right): https://codereview.tryton.org/255091002/diff/281101002/modules/party/view/address_listform.xml#newcode1 modules/party/view/address_listform.xml:1: <?xml version="1.0"?> useless https://codereview.tryton.org/255091002/diff/281101002/modules/party/view/party_form.xml File modules/party/view/party_form.xml (right): https://codereview.tryton.org/255091002/diff/281101002/modules/party/view/party_form.xml#newcode19 modules/party/view/party_form.xml:19: ...
1 week ago (2019-03-13 09:46:08 UTC) #13
nicoe
1 week ago (2019-03-13 16:30:15 UTC) #14
nicoe
https://codereview.tryton.org/255091002/diff/281101002/modules/party/view/address_listform.xml File modules/party/view/address_listform.xml (right): https://codereview.tryton.org/255091002/diff/281101002/modules/party/view/address_listform.xml#newcode1 modules/party/view/address_listform.xml:1: <?xml version="1.0"?> On 2019/03/13 09:46:05, ced wrote: > useless ...
1 week ago (2019-03-13 16:31:18 UTC) #15
reviewbot
flake8 OK URL: https://codereview.tryton.org/255091002
1 week ago (2019-03-13 16:50:23 UTC) #16
nicoe
1 week ago (2019-03-13 17:52:16 UTC) #17
reviewbot
flake8 OK URL: https://codereview.tryton.org/255091002
1 week ago (2019-03-13 18:13:10 UTC) #18
ced
Missing changelog and documentation. https://codereview.tryton.org/255091002/diff/253121002/sao/src/screen.js File sao/src/screen.js (right): https://codereview.tryton.org/255091002/diff/253121002/sao/src/screen.js#newcode1238 sao/src/screen.js:1238: if (~['tree', 'form', 'listform'].indexOf(view.view_type) && ...
6 days, 8 hours ago (2019-03-14 11:06:44 UTC) #19
nicoe
https://codereview.tryton.org/255091002/diff/253121002/sao/src/screen.js File sao/src/screen.js (right): https://codereview.tryton.org/255091002/diff/253121002/sao/src/screen.js#newcode1238 sao/src/screen.js:1238: if (~['tree', 'form', 'listform'].indexOf(view.view_type) && On 2019/03/14 11:06:42, ced ...
6 days, 6 hours ago (2019-03-14 12:38:23 UTC) #20
nicoe
6 days, 6 hours ago (2019-03-14 12:38:45 UTC) #21
reviewbot
flake8 OK URL: https://codereview.tryton.org/255091002
6 days, 6 hours ago (2019-03-14 12:47:21 UTC) #22
ced
https://codereview.tryton.org/255091002/diff/253121002/sao/src/view/listform.js File sao/src/view/listform.js (right): https://codereview.tryton.org/255091002/diff/253121002/sao/src/view/listform.js#newcode48 sao/src/view/listform.js:48: if (this.screen.current_record === record) { On 2019/03/14 12:38:23, nicoe ...
6 days, 5 hours ago (2019-03-14 13:07:42 UTC) #23
nicoe
6 days, 5 hours ago (2019-03-14 13:29:42 UTC) #24
nicoe
https://codereview.tryton.org/255091002/diff/253121002/sao/src/view/listform.js File sao/src/view/listform.js (right): https://codereview.tryton.org/255091002/diff/253121002/sao/src/view/listform.js#newcode48 sao/src/view/listform.js:48: if (this.screen.current_record === record) { On 2019/03/14 13:07:42, ced ...
6 days, 5 hours ago (2019-03-14 13:29:46 UTC) #25
reviewbot
flake8 OK URL: https://codereview.tryton.org/255091002
6 days, 5 hours ago (2019-03-14 13:43:43 UTC) #26
ced
https://codereview.tryton.org/255091002/diff/261101002/sao/Gruntfile.js File sao/Gruntfile.js (right): https://codereview.tryton.org/255091002/diff/261101002/sao/Gruntfile.js#newcode19 sao/Gruntfile.js:19: 'src/view/listform.js', should be called: list_form.js https://codereview.tryton.org/255091002/diff/261101002/sao/src/view/listform.js File sao/src/view/listform.js (right): ...
6 days ago (2019-03-14 18:32:25 UTC) #27
ced
https://codereview.tryton.org/255091002/diff/261101002/tryton/tryton/gui/window/view_form/view/__init__.py File tryton/tryton/gui/window/view_form/view/__init__.py (right): https://codereview.tryton.org/255091002/diff/261101002/tryton/tryton/gui/window/view_form/view/__init__.py#newcode68 tryton/tryton/gui/window/view_form/view/__init__.py:68: from .listform import ViewListForm should be: from .list_form
6 days ago (2019-03-14 18:32:52 UTC) #28
nicoe
2 days, 3 hours ago (2019-03-18 15:57:05 UTC) #29
nicoe
2 days, 3 hours ago (2019-03-18 16:00:17 UTC) #30
reviewbot
2 days, 2 hours ago (2019-03-18 16:13:48 UTC) #31
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766