Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(22)

Issue 255251002: tryton-env: Don't set default unit price on stock move

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 4 days ago by ced
Modified:
1 week, 1 day ago
Reviewers:
reviewbot
Visibility:
Public.

Description

tryton-env: Don't set default unit price on stock move issue8119

Patch Set 1 #

Patch Set 2 : Fill unit price when consigment origin is set #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -54 lines) Patch
M modules/carrier_percentage/tests/scenario_carrier_percentage_with_purchase_shipment_cost.rst View 1 chunk +1 line, -2 lines 0 comments Download
M modules/carrier_weight/tests/scenario_carrier_weight.rst View 1 chunk +1 line, -2 lines 0 comments Download
M modules/purchase_shipment_cost/tests/scenario_purchase_shipment_cost.rst View 2 chunks +2 lines, -2 lines 0 comments Download
M modules/purchase_shipment_cost/tests/scenario_purchase_shipment_cost_with_account_stock.rst View 2 chunks +3 lines, -4 lines 0 comments Download
M modules/stock/CHANGELOG View 1 chunk +1 line, -0 lines 0 comments Download
M modules/stock/move.py View 2 chunks +11 lines, -44 lines 0 comments Download
M modules/stock/tests/scenario_stock_average_cost_price.rst View 4 chunks +4 lines, -0 lines 0 comments Download
M modules/stock/tests/scenario_stock_shipment_in_same_storage_input.rst View 1 chunk +1 line, -0 lines 0 comments Download
M modules/stock/tests/scenario_stock_shipment_out_same_storage_output.rst View 1 chunk +1 line, -0 lines 0 comments Download
M modules/stock_consignment/stock.py View 1 2 chunks +21 lines, -0 lines 0 comments Download
M modules/stock_consignment/tests/scenario_stock_consignment.rst View 1 1 chunk +1 line, -0 lines 0 comments Download
M modules/stock_location_move/tests/scenario_stock_location_move_empty.rst View 4 chunks +6 lines, -0 lines 0 comments Download
M modules/stock_lot_unit/tests/scenario_stock_lot_unit.rst View 4 chunks +6 lines, -0 lines 0 comments Download
M modules/stock_supply/tests/scenario_stock_internal_supply_lead_time.rst View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
ced
1 week, 4 days ago (2019-04-07 14:22:53 UTC) #1
reviewbot
https://codereview.tryton.org/255251002/diff/265271002/modules/stock/move.py#newcode1023 modules/stock/move.py:1023: E712 comparison to True should be 'if cond is not True:' or 'if ...
1 week, 4 days ago (2019-04-07 14:49:10 UTC) #2
ced
1 week, 1 day ago (2019-04-10 10:54:23 UTC) #3
reviewbot
1 week, 1 day ago (2019-04-10 11:18:23 UTC) #4
https://codereview.tryton.org/255251002/diff/255291002/modules/stock/move.py#...
modules/stock/move.py:1023:
E712 comparison to True should be 'if cond is not True:' or 'if not cond:'

https://codereview.tryton.org/255251002/diff/255291002/modules/stock/move.py#...
modules/stock/move.py:1070:
E712 comparison to True should be 'if cond is True:' or 'if cond:'

https://codereview.tryton.org/255251002/diff/255291002/modules/stock/move.py#...
modules/stock/move.py:1080:
E731 do not assign a lambda expression, use a def

https://codereview.tryton.org/255251002/diff/255291002/modules/stock/move.py#...
modules/stock/move.py:1101:
E731 do not assign a lambda expression, use a def

https://codereview.tryton.org/255251002/diff/255291002/modules/stock/move.py#...
modules/stock/move.py:1142:
E731 do not assign a lambda expression, use a def

https://codereview.tryton.org/255251002/diff/255291002/modules/stock/move.py#...
modules/stock/move.py:1159:
E731 do not assign a lambda expression, use a def

https://codereview.tryton.org/255251002/diff/255291002/modules/stock/move.py#...
modules/stock/move.py:1206:
E731 do not assign a lambda expression, use a def

https://codereview.tryton.org/255251002/diff/255291002/modules/stock_consignm...
modules/stock_consignment/stock.py:104:
E127 continuation line over-indented for visual indent

URL: https://codereview.tryton.org/255251002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766