Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(67)

Issue 25981002: proteus: Add support for search_* attributes on ModelList (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 11 months ago by nicoe
Modified:
9 months ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : fix remarks #

Total comments: 2

Patch Set 3 : fix remarks #

Total comments: 3

Patch Set 4 : fix remarks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M CHANGELOG View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M proteus/__init__.py View 1 2 3 2 chunks +7 lines, -1 line 0 comments Download
M proteus/tests/test_model.py View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 18
nicoe
1 year, 11 months ago (2017-01-04 16:25:28 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/25981002
1 year, 11 months ago (2017-01-04 16:41:54 UTC) #2
ced
https://tryton-rietveld.appspot.com/25981002/diff/1/proteus/__init__.py File proteus/__init__.py (right): https://tryton-rietveld.appspot.com/25981002/diff/1/proteus/__init__.py#newcode500 proteus/__init__.py:500: self.search_order = definition.get('search_order', '[]') I think the default should ...
1 year, 11 months ago (2017-01-05 00:44:39 UTC) #3
nicoe
https://tryton-rietveld.appspot.com/25981002/diff/1/proteus/__init__.py File proteus/__init__.py (right): https://tryton-rietveld.appspot.com/25981002/diff/1/proteus/__init__.py#newcode500 proteus/__init__.py:500: self.search_order = definition.get('search_order', '[]') On 2017/01/05 00:44:39, ced wrote: ...
1 year, 11 months ago (2017-01-12 13:16:13 UTC) #4
nicoe
fix remarks
1 year, 11 months ago (2017-01-12 13:16:29 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/25981002
1 year, 11 months ago (2017-01-12 13:48:35 UTC) #6
ced
https://tryton-rietveld.appspot.com/25981002/diff/20001/proteus/__init__.py File proteus/__init__.py (right): https://tryton-rietveld.appspot.com/25981002/diff/20001/proteus/__init__.py#newcode624 proteus/__init__.py:624: order if order else decoder.decode(self.search_order)) Why not compute order ...
1 year, 11 months ago (2017-01-13 22:39:41 UTC) #7
nicoe
fix remarks
1 year, 10 months ago (2017-02-21 16:32:30 UTC) #8
nicoe
https://tryton-rietveld.appspot.com/25981002/diff/20001/proteus/__init__.py File proteus/__init__.py (right): https://tryton-rietveld.appspot.com/25981002/diff/20001/proteus/__init__.py#newcode624 proteus/__init__.py:624: order if order else decoder.decode(self.search_order)) On 2017/01/13 22:39:40, ced ...
1 year, 10 months ago (2017-02-21 16:32:34 UTC) #9
reviewbot
flake8 OK URL: https://codereview.tryton.org/25981002
1 year, 10 months ago (2017-02-21 16:36:25 UTC) #10
ced
https://tryton-rietveld.appspot.com/25981002/diff/40001/proteus/__init__.py File proteus/__init__.py (right): https://tryton-rietveld.appspot.com/25981002/diff/40001/proteus/__init__.py#newcode623 proteus/__init__.py:623: order = order if order else decoder.decode(self.search_order) could be ...
1 year, 9 months ago (2017-03-06 20:34:43 UTC) #11
nicoe
https://tryton-rietveld.appspot.com/25981002/diff/40001/proteus/__init__.py File proteus/__init__.py (right): https://tryton-rietveld.appspot.com/25981002/diff/40001/proteus/__init__.py#newcode623 proteus/__init__.py:623: order = order if order else decoder.decode(self.search_order) On 2017/03/06 ...
1 year, 9 months ago (2017-03-07 11:45:39 UTC) #12
ced
https://tryton-rietveld.appspot.com/25981002/diff/40001/proteus/__init__.py File proteus/__init__.py (right): https://tryton-rietveld.appspot.com/25981002/diff/40001/proteus/__init__.py#newcode623 proteus/__init__.py:623: order = order if order else decoder.decode(self.search_order) On 2017/03/07 ...
1 year, 9 months ago (2017-03-07 12:31:48 UTC) #13
nicoe
On 2017/03/07 12:31:48, ced wrote: > https://tryton-rietveld.appspot.com/25981002/diff/40001/proteus/__init__.py > File proteus/__init__.py (right): > > https://tryton-rietveld.appspot.com/25981002/diff/40001/proteus/__init__.py#newcode623 > ...
1 year, 9 months ago (2017-03-07 13:19:15 UTC) #14
nicoe
fix remarks
9 months, 1 week ago (2018-03-15 17:53:41 UTC) #15
reviewbot
flake8 OK URL: https://codereview.tryton.org/25981002
9 months, 1 week ago (2018-03-15 18:12:18 UTC) #16
ced
LGTM
9 months ago (2018-03-21 12:26:37 UTC) #17
rietveld-bot_tryton.org
9 months ago (2018-03-21 17:03:20 UTC) #18
New changeset 7db95d0e97d3 by Nicolas ?vrard in branch 'default':
Add support for search_* attributes on ModelList
http://hg.tryton.org/proteus/rev/7db95d0e97d3
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766