Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(78)

Issue 261391002: tryton-env: Remove _FileCache file from the FS when they're not used anymore

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks, 6 days ago by nicoe
Modified:
3 weeks ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

tryton-env: Remove _FileCache file from the FS when they're not used anymore issue8311

Patch Set 1 #

Total comments: 1

Patch Set 2 : Handle IOError #

Total comments: 3

Patch Set 3 : Don't log warning #

Total comments: 1

Patch Set 4 : remove logger #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M tryton/tryton/gui/window/view_form/model/field.py View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 16
nicoe
3 weeks, 6 days ago (2019-04-26 16:05:45 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/261391002
3 weeks, 6 days ago (2019-04-26 16:10:30 UTC) #2
ced
https://codereview.tryton.org/261391002/diff/257411002/tryton/tryton/gui/window/view_form/model/field.py File tryton/tryton/gui/window/view_form/model/field.py (right): https://codereview.tryton.org/261391002/diff/257411002/tryton/tryton/gui/window/view_form/model/field.py#newcode909 tryton/tryton/gui/window/view_form/model/field.py:909: os.remove(self.path) Should be protected against IOError.
3 weeks, 6 days ago (2019-04-26 16:13:13 UTC) #3
nicoe
3 weeks, 6 days ago (2019-04-26 16:59:05 UTC) #4
ced
https://codereview.tryton.org/261391002/diff/283291002/tryton/tryton/gui/window/view_form/model/field.py File tryton/tryton/gui/window/view_form/model/field.py (right): https://codereview.tryton.org/261391002/diff/283291002/tryton/tryton/gui/window/view_form/model/field.py#newcode917 tryton/tryton/gui/window/view_form/model/field.py:917: exc_info=error) I do not think we need to log ...
3 weeks, 6 days ago (2019-04-26 17:02:26 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/261391002
3 weeks, 6 days ago (2019-04-26 17:13:13 UTC) #6
nicoe
3 weeks, 3 days ago (2019-04-29 14:31:26 UTC) #7
nicoe
https://codereview.tryton.org/261391002/diff/283291002/tryton/tryton/gui/window/view_form/model/field.py File tryton/tryton/gui/window/view_form/model/field.py (right): https://codereview.tryton.org/261391002/diff/283291002/tryton/tryton/gui/window/view_form/model/field.py#newcode917 tryton/tryton/gui/window/view_form/model/field.py:917: exc_info=error) On 2019/04/26 17:02:25, ced wrote: > I do ...
3 weeks, 3 days ago (2019-04-29 14:32:16 UTC) #8
reviewbot
flake8 OK URL: https://codereview.tryton.org/261391002
3 weeks, 3 days ago (2019-04-29 14:47:08 UTC) #9
ced
https://codereview.tryton.org/261391002/diff/283291002/tryton/tryton/gui/window/view_form/model/field.py File tryton/tryton/gui/window/view_form/model/field.py (right): https://codereview.tryton.org/261391002/diff/283291002/tryton/tryton/gui/window/view_form/model/field.py#newcode917 tryton/tryton/gui/window/view_form/model/field.py:917: exc_info=error) On 2019/04/29 14:32:15, nicoe wrote: > On 2019/04/26 ...
3 weeks, 3 days ago (2019-04-29 14:48:30 UTC) #10
ced
https://codereview.tryton.org/261391002/diff/271371005/tryton/tryton/gui/window/view_form/model/field.py File tryton/tryton/gui/window/view_form/model/field.py (right): https://codereview.tryton.org/261391002/diff/271371005/tryton/tryton/gui/window/view_form/model/field.py#newcode22 tryton/tryton/gui/window/view_form/model/field.py:22: logger = logging.getLogger(__name__) No more needed.
3 weeks, 3 days ago (2019-04-29 20:31:34 UTC) #11
nicoe
3 weeks, 2 days ago (2019-04-30 11:53:12 UTC) #12
reviewbot
flake8 OK URL: https://codereview.tryton.org/261391002
3 weeks, 2 days ago (2019-04-30 12:04:03 UTC) #13
ced
LGTM
3 weeks, 2 days ago (2019-04-30 15:05:46 UTC) #14
rietveld-bot_tryton.org
New changeset 66bc701df6a0 by Nicolas ?vrard in branch 'default': Remove _FileCache file from the FS ...
3 weeks ago (2019-05-02 10:11:53 UTC) #15
rietveld-bot_tryton.org
3 weeks ago (2019-05-02 10:11:54 UTC) #16
New changeset 3e006a50653b by Nicolas ?vrard in branch 'default':
Remove _FileCache file from the FS when they're not used anymore
https://hg.tryton.org/tryton-env/rev/3e006a50653b
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766