Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13)

Issue 261811002: tryton-env: Improve moves synchronisation on shipments (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 6 months ago by ced
Modified:
3 years, 5 months ago
Reviewers:
pokoli, rietveld-bot, dave, reviewbot
Visibility:
Public.

Description

By using the origin as synchronisation key, the code is simplified but also it allows to follow when products are changed. The same design is applied to the internal shipment which allows to synchronise also the lots. issue8363

Patch Set 1 #

Total comments: 8

Patch Set 2 : Update to tip and use float as default #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -170 lines) Patch
M modules/stock/CHANGELOG View 1 chunk +1 line, -0 lines 0 comments Download
M modules/stock/shipment.py View 1 4 chunks +125 lines, -102 lines 0 comments Download
M modules/stock/tests/scenario_stock_shipment_internal.rst View 2 chunks +9 lines, -3 lines 0 comments Download
M modules/stock_lot/CHANGELOG View 1 chunk +2 lines, -0 lines 0 comments Download
M modules/stock_lot/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
M modules/stock_lot/stock.py View 3 chunks +9 lines, -39 lines 0 comments Download
M modules/stock_lot/tests/scenario_stock_lot_shipment_out.rst View 3 chunks +21 lines, -26 lines 0 comments Download

Messages

Total messages: 9
ced
3 years, 6 months ago (2019-07-09 15:52:59 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/261811002
3 years, 6 months ago (2019-07-09 16:11:24 UTC) #2
dave
https://codereview.tryton.org/261811002/diff/277581002/modules/stock/CHANGELOG File modules/stock/CHANGELOG (right): https://codereview.tryton.org/261811002/diff/277581002/modules/stock/CHANGELOG#newcode1 modules/stock/CHANGELOG:1: * Improve moves synchronisation on shipments A very minor ...
3 years, 6 months ago (2019-07-12 18:02:04 UTC) #3
pokoli
https://codereview.tryton.org/261811002/diff/277581002/modules/stock/shipment.py File modules/stock/shipment.py (right): https://codereview.tryton.org/261811002/diff/277581002/modules/stock/shipment.py#newcode1190 modules/stock/shipment.py:1190: inventory_qty = defaultdict(lambda: defaultdict(lambda: 0)) i think it's easier ...
3 years, 6 months ago (2019-07-18 07:45:17 UTC) #4
ced
https://codereview.tryton.org/261811002/diff/277581002/modules/stock/shipment.py File modules/stock/shipment.py (right): https://codereview.tryton.org/261811002/diff/277581002/modules/stock/shipment.py#newcode1190 modules/stock/shipment.py:1190: inventory_qty = defaultdict(lambda: defaultdict(lambda: 0)) On 2019/07/18 07:45:17, pokoli ...
3 years, 6 months ago (2019-07-18 07:56:01 UTC) #5
ced
3 years, 6 months ago (2019-07-18 07:56:33 UTC) #6
reviewbot
flake8 OK URL: https://codereview.tryton.org/261811002
3 years, 6 months ago (2019-07-18 08:14:00 UTC) #7
rietveld-bot_tryton.org
New changeset 38e2a76db719 by Cédric Krier in branch 'default': Improve moves synchronisation on shipments https://hg.tryton.org/modules/stock/rev/38e2a76db719
3 years, 5 months ago (2019-08-18 17:22:58 UTC) #8
rietveld-bot_tryton.org
3 years, 5 months ago (2019-08-18 17:23:08 UTC) #9
New changeset b705e7f82fc6 by Cédric Krier in branch 'default':
Improve moves synchronisation on shipments
https://hg.tryton.org/tryton-env/rev/b705e7f82fc6
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted