tryton-env: Improve moves synchronisation on shipments

By using the origin as synchronisation key, the code is simplified but also it
allows to follow when products are changed.
The same design is applied to the internal shipment which allows to synchronise
also the lots.

issue8363

[reviewbot, 2019-07-09 16:11:24]

flake8 OK
URL: https://codereview.tryton.org/261811002

[dave, 2019-07-12 18:02:04]

https://codereview.tryton.org/261811002/diff/277581002/modules/stock/CHANGELOG
File modules/stock/CHANGELOG (right):

https://codereview.tryton.org/261811002/diff/277581002/modules/stock/CHANGELO...
modules/stock/CHANGELOG:1: * Improve moves synchronisation on shipments
A very minor thing, synchronisation here is spelt with an 's', but in the later
CHANGELOG it is spelt with a 'z'.

Both can be considered correct, I'm only pointing it out because they are
inconsistent.

In US English using a 'z' is the preferred spelling, and outside the US the word
is normally spelt with an 's'.

[pokoli, 2019-07-18 07:45:17]

https://codereview.tryton.org/261811002/diff/277581002/modules/stock/shipment.py
File modules/stock/shipment.py (right):

https://codereview.tryton.org/261811002/diff/277581002/modules/stock/shipment...
modules/stock/shipment.py:1190: inventory_qty = defaultdict(lambda:
defaultdict(lambda: 0))
i think it's easier to write defaultdict(lambda: defaultict(float)) 
so the second lambda is not required

https://codereview.tryton.org/261811002/diff/277581002/modules/stock/shipment...
modules/stock/shipment.py:1193: inventory_qty[move][key] = 0
why setting 0? It is not the default value of defaultdict?

I think we can remove this for loop.

https://codereview.tryton.org/261811002/diff/277581002/modules/stock/shipment...
modules/stock/shipment.py:1214: for name, value in key:
Why not setting key value in _sync_outgoing_move?

This will allow better customization of keys and moves.

https://codereview.tryton.org/261811002/diff/277581002/modules/stock/shipment...
modules/stock/shipment.py:2226: for move in filter(active,
shipment.incoming_moves):
idem about this loop

[ced, 2019-07-18 07:56:01]

https://codereview.tryton.org/261811002/diff/277581002/modules/stock/shipment.py
File modules/stock/shipment.py (right):

https://codereview.tryton.org/261811002/diff/277581002/modules/stock/shipment...
modules/stock/shipment.py:1190: inventory_qty = defaultdict(lambda:
defaultdict(lambda: 0))
On 2019/07/18 07:45:17, pokoli wrote:
> i think it's easier to write defaultdict(lambda: defaultict(float)) 
> so the second lambda is not required

Done.

https://codereview.tryton.org/261811002/diff/277581002/modules/stock/shipment...
modules/stock/shipment.py:1193: inventory_qty[move][key] = 0
On 2019/07/18 07:45:17, pokoli wrote:
> why setting 0? It is not the default value of defaultdict?
> 
> I think we can remove this for loop. 

No it is to be sure that those keys are set when looping later on them.

https://codereview.tryton.org/261811002/diff/277581002/modules/stock/shipment...
modules/stock/shipment.py:1214: for name, value in key:
On 2019/07/18 07:45:17, pokoli wrote:
> Why not setting key value in _sync_outgoing_move?
> 
> This will allow better customization of keys and moves. 

No the algorithm is based on the fact that key does not change.
You can customize the key in _sync_move_key.

[reviewbot, 2019-07-18 08:14:00]

flake8 OK
URL: https://codereview.tryton.org/261811002

[rietveld-bot_tryton.org, 2019-08-18 17:22:58]

New changeset 38e2a76db719 by Cédric Krier in branch 'default':
Improve moves synchronisation on shipments
https://hg.tryton.org/modules/stock/rev/38e2a76db719

[rietveld-bot_tryton.org, 2019-08-18 17:23:08]

New changeset b705e7f82fc6 by Cédric Krier in branch 'default':
Improve moves synchronisation on shipments
https://hg.tryton.org/tryton-env/rev/b705e7f82fc6