Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2202)

Issue 263471002: tryton-env: Do not rely on field views to load form fields

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 6 days ago by ced
Modified:
6 days, 11 hours ago
Reviewers:
rietveld-bot, reviewbot
Visibility:
Public.

Description

tryton-env: Do not rely on field views to load form fields If the views attribute of the field is wrong or empty, the record will not load the value for this field. The views attribute can be empty if it was created by copying the field from its parent. So it is safer to not rely on this attribute which is there only for optimization and instead always use all the fields defined on the view. issue8289

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M sao/src/view/form.js View 1 chunk +6 lines, -8 lines 0 comments Download
M tryton/tryton/gui/window/view_form/view/form.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7
ced
2 weeks, 6 days ago (2019-05-03 17:14:22 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/263471002
2 weeks, 6 days ago (2019-05-03 17:37:51 UTC) #2
rietveld-bot_tryton.org
New changeset eb4883a7e477 by Cédric Krier in branch 'default': Do not rely on field views ...
2 weeks, 4 days ago (2019-05-05 17:34:11 UTC) #3
rietveld-bot_tryton.org
New changeset a2a957b7407f by Cédric Krier in branch 'default': Do not rely on field views ...
2 weeks, 4 days ago (2019-05-05 17:34:15 UTC) #4
rietveld-bot_tryton.org
New changeset 3f56d6c49f1d by Cédric Krier in branch 'default': Do not rely on field views ...
2 weeks, 4 days ago (2019-05-05 17:34:17 UTC) #5
rietveld-bot_tryton.org
New changeset 19961004f56e by Cédric Krier in branch '5.0': Do not rely on field views ...
6 days, 11 hours ago (2019-05-17 10:53:34 UTC) #6
rietveld-bot_tryton.org
6 days, 11 hours ago (2019-05-17 10:53:54 UTC) #7
New changeset 0ff72f467a92 by Cédric Krier in branch '5.0':
Do not rely on field views to load form fields
https://hg.tryton.org/tryton/rev/0ff72f467a92
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766