Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(75)

Issue 265411002: sao: Reduce number of promises when rendering tree

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 2 days ago by ced
Modified:
1 week, 6 days ago
Reviewers:
pokoli, reviewbot
Visibility:
Public.

Description

sao: Reduce number of promises when rendering tree We preload the first field of the first row if needed. This should ensure that the following records are also loaded. And we do not call load if the field is already loaded to avoid to create a promise. issue8199

Patch Set 1 #

Total comments: 4

Patch Set 2 : Improve all Cell.render and avoid setTimeout #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -36 lines) Patch
M src/model.js View 1 chunk +4 lines, -1 line 0 comments Download
M src/view/tree.js View 1 8 chunks +55 lines, -35 lines 0 comments Download

Messages

Total messages: 6
ced
2 weeks, 2 days ago (2019-05-07 15:34:52 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/265411002
2 weeks, 2 days ago (2019-05-07 15:41:02 UTC) #2
pokoli
https://codereview.tryton.org/265411002/diff/249381002/src/view/tree.js File src/view/tree.js (right): https://codereview.tryton.org/265411002/diff/249381002/src/view/tree.js#newcode831 src/view/tree.js:831: // Prefetch the first field to avoid creating a ...
2 weeks, 2 days ago (2019-05-07 16:37:56 UTC) #3
ced
https://codereview.tryton.org/265411002/diff/249381002/src/view/tree.js File src/view/tree.js (right): https://codereview.tryton.org/265411002/diff/249381002/src/view/tree.js#newcode831 src/view/tree.js:831: // Prefetch the first field to avoid creating a ...
1 week, 6 days ago (2019-05-10 17:06:20 UTC) #4
ced
1 week, 6 days ago (2019-05-10 17:06:20 UTC) #5
reviewbot
1 week, 6 days ago (2019-05-10 17:12:42 UTC) #6
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766