Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(125)

Issue 26651002: account_statement: Require party on statement line if account requires one (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 11 months ago by pokoli
Modified:
5 days, 12 hours ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : clear party via on_change #

Patch Set 3 : Add tests #

Total comments: 2

Patch Set 4 : Fix remarks and update to tip #

Total comments: 3

Patch Set 5 : Fix remarks #

Total comments: 1

Patch Set 6 : Make required only for draft statements #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M CHANGELOG View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M statement.py View 1 2 3 4 5 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 15
pokoli
5 years, 11 months ago (2016-09-14 11:14:03 UTC) #1
pokoli
clear party via on_change
5 years, 11 months ago (2016-09-14 11:20:48 UTC) #2
pokoli
Add tests
5 years, 11 months ago (2016-09-14 11:25:01 UTC) #3
reviewbot
flake8 OK URL: https://codereview.tryton.org/26651002
5 years, 11 months ago (2016-09-14 11:26:46 UTC) #4
ced
https://codereview.tryton.org/26651002/diff/40001/statement.py File statement.py (right): https://codereview.tryton.org/26651002/diff/40001/statement.py#newcode547 statement.py:547: 'invisible': ~Eval('party_required', False), I will keep the party always ...
1 month ago (2022-07-15 12:04:18 UTC) #5
pokoli
Fix remarks and update to tip
1 month ago (2022-07-15 12:52:07 UTC) #6
reviewbot
checks OK URL: https://codereview.tryton.org/26651002
1 month ago (2022-07-15 12:53:22 UTC) #7
ced
https://codereview.tryton.org/26651002/diff/411441003/CHANGELOG File CHANGELOG (right): https://codereview.tryton.org/26651002/diff/411441003/CHANGELOG#newcode1 CHANGELOG:1: * Make party required if account requires a party ...
4 weeks, 1 day ago (2022-07-18 21:11:40 UTC) #8
pokoli
Fix remarks
4 weeks ago (2022-07-19 11:40:44 UTC) #9
ced
https://codereview.tryton.org/26651002/diff/443441003/statement.py File statement.py (right): https://codereview.tryton.org/26651002/diff/443441003/statement.py#newcode785 statement.py:785: 'required': Eval('party_required', False), I think it should be required ...
4 weeks ago (2022-07-19 11:42:18 UTC) #10
pokoli
Make required only for draft statements
4 weeks ago (2022-07-19 11:45:48 UTC) #11
ced
LGTM
4 weeks ago (2022-07-19 11:46:41 UTC) #12
reviewbot
checks OK URL: https://codereview.tryton.org/26651002
4 weeks ago (2022-07-19 11:54:39 UTC) #13
rietveld-bot_tryton.org
New changeset 92522a1c18a2 by Sergi Almacellas Abellana in branch 'default': Require party on statement line ...
2 weeks ago (2022-08-02 07:38:26 UTC) #14
rietveld-bot_tryton.org
2 weeks ago (2022-08-02 07:38:31 UTC) #15
New changeset e97f1ae4477c by Sergi Almacellas Abellana in branch 'default':
Require party on statement line if account requires one
https://hg.tryton.org/tryton-env/rev/e97f1ae4477c
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted