Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(430)

Issue 26711002: trytond: Include record name and value in validation error message (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 4 months ago by pokoli
Modified:
5 months, 4 weeks ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

issue5581 COLLABORATOR=cedric.krier@b2ck.com

Patch Set 1 #

Total comments: 3

Patch Set 2 : Pass record to format_time #

Patch Set 3 : Use conditional rec_name and fallback to id #

Total comments: 3

Patch Set 4 : Fix comment and update to tip #

Patch Set 5 : Better changelog entry #

Total comments: 2

Patch Set 6 : Use right message id #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -35 lines) Patch
M CHANGELOG View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M doc/ref/models.rst View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M trytond/ir/message.xml View 1 2 3 1 chunk +13 lines, -7 lines 0 comments Download
M trytond/model/model.py View 1 2 3 2 chunks +15 lines, -1 line 0 comments Download
M trytond/model/modelsql.py View 1 2 3 4 5 2 chunks +5 lines, -3 lines 0 comments Download
M trytond/model/modelstorage.py View 1 2 3 9 chunks +16 lines, -22 lines 0 comments Download
M trytond/tests/test_model.py View 1 2 3 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 17
pokoli
6 years, 4 months ago (2016-09-21 15:59:38 UTC) #1
ced
https://tryton-rietveld.appspot.com/26711002/diff/1/trytond/ir/translation.xml File trytond/ir/translation.xml (right): https://tryton-rietveld.appspot.com/26711002/diff/1/trytond/ir/translation.xml#newcode112 trytond/ir/translation.xml:112: <field name="src">The field "%(field)s" on record with ID "%(id)s" ...
6 years, 4 months ago (2016-09-21 16:21:23 UTC) #2
reviewbot
flake8 OK URL: https://codereview.tryton.org/26711002
6 years, 4 months ago (2016-09-21 16:30:33 UTC) #3
pokoli
Pass record to format_time
6 years, 4 months ago (2016-09-22 07:34:58 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/26711002
6 years, 4 months ago (2016-09-22 07:59:27 UTC) #5
pokoli
Use conditional rec_name and fallback to id
4 years, 12 months ago (2018-02-07 16:13:40 UTC) #6
reviewbot
https://codereview.tryton.org/26711002/diff/40001/trytond/model/modelstorage.py#newcode1087 trytond/model/modelstorage.py:1087: F821 undefined name 'reecord' URL: https://codereview.tryton.org/26711002
4 years, 12 months ago (2018-02-07 16:20:30 UTC) #7
ced
https://codereview.tryton.org/26711002/diff/40001/trytond/ir/translation.xml File trytond/ir/translation.xml (right): https://codereview.tryton.org/26711002/diff/40001/trytond/ir/translation.xml#newcode132 trytond/ir/translation.xml:132: <field name="src">The value of the field "%(field)s" on record ...
4 years, 11 months ago (2018-02-12 23:47:47 UTC) #8
ced
6 months, 3 weeks ago (2022-07-15 12:09:30 UTC) #9
ced
6 months, 3 weeks ago (2022-07-15 12:10:02 UTC) #10
reviewbot
checks OK URL: https://codereview.tryton.org/26711002
6 months, 3 weeks ago (2022-07-15 12:21:01 UTC) #11
pokoli
https://codereview.tryton.org/26711002/diff/411431003/trytond/model/modelsql.py File trytond/model/modelsql.py (right): https://codereview.tryton.org/26711002/diff/411431003/trytond/model/modelsql.py#newcode419 trytond/model/modelsql.py:419: gettext('ir.msg_size_validation_record', **error_args)) should not be 'msg_size_validation' (without record) ?
6 months, 3 weeks ago (2022-07-15 12:50:20 UTC) #12
ced
6 months, 3 weeks ago (2022-07-15 13:18:57 UTC) #13
ced
https://codereview.tryton.org/26711002/diff/411431003/trytond/model/modelsql.py File trytond/model/modelsql.py (right): https://codereview.tryton.org/26711002/diff/411431003/trytond/model/modelsql.py#newcode419 trytond/model/modelsql.py:419: gettext('ir.msg_size_validation_record', **error_args)) On 2022/07/15 12:50:20, pokoli wrote: > should ...
6 months, 3 weeks ago (2022-07-15 13:18:58 UTC) #14
reviewbot
patch is not applicable URL: https://codereview.tryton.org/26711002
6 months, 3 weeks ago (2022-07-15 13:50:09 UTC) #15
rietveld-bot_tryton.org
New changeset 1b42f8379b1e by Cédric Krier in branch 'default': Include record name and value in ...
5 months, 4 weeks ago (2022-08-06 21:06:07 UTC) #16
rietveld-bot_tryton.org
5 months, 4 weeks ago (2022-08-06 21:06:15 UTC) #17
New changeset 484a7e89f662 by Cédric Krier in branch 'default':
Include record name and value in validation error message
https://hg.tryton.org/tryton-env/rev/484a7e89f662
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted