trytond: Include record name and value in validation error message

issue5581

COLLABORATOR=cedric.krier@b2ck.com

[ced, 2016-09-21 16:21:23]

https://tryton-rietveld.appspot.com/26711002/diff/1/trytond/ir/translation.xml
File trytond/ir/translation.xml (right):

https://tryton-rietveld.appspot.com/26711002/diff/1/trytond/ir/translation.xm...
trytond/ir/translation.xml:112: <field name="src">The field "%(field)s" on
record with ID "%(id)s" of "%(model)s" is required.</field>
I think the ID must be quite discrete as it is of no meaning for most of the
users.

https://tryton-rietveld.appspot.com/26711002/diff/1/trytond/model/modelstorag...
File trytond/model/modelstorage.py (right):

https://tryton-rietveld.appspot.com/26711002/diff/1/trytond/model/modelstorag...
trytond/model/modelstorage.py:860: error_args['id'] = record.id
How do you format id if the record is None

https://tryton-rietveld.appspot.com/26711002/diff/1/trytond/model/modelstorag...
trytond/model/modelstorage.py:978: field.name, record=next(iter(invalid_ids))))
why not showing all of them? with maybe a limit of 20.

[reviewbot, 2016-09-21 16:30:33]

flake8 OK
URL: https://codereview.tryton.org/26711002

[pokoli, 2016-09-22 07:34:58]

Pass record to format_time

[reviewbot, 2016-09-22 07:59:27]

flake8 OK
URL: https://codereview.tryton.org/26711002

[pokoli, 2018-02-07 16:13:40]

Use conditional rec_name and fallback to id

[reviewbot, 2018-02-07 16:20:30]

https://codereview.tryton.org/26711002/diff/40001/trytond/model/modelstorage....
trytond/model/modelstorage.py:1087:
F821 undefined name 'reecord'

URL: https://codereview.tryton.org/26711002

[ced, 2018-02-12 23:47:47]

https://codereview.tryton.org/26711002/diff/40001/trytond/ir/translation.xml
File trytond/ir/translation.xml (right):

https://codereview.tryton.org/26711002/diff/40001/trytond/ir/translation.xml#...
trytond/ir/translation.xml:132: <field name="src">The value of the field
"%(field)s" on record "%(record)s" of model "%(model)s" is not valid according
to its domain.</field>
I'm wondering if we should keep model? It is quite technical and so it will not
really help the user.

https://codereview.tryton.org/26711002/diff/40001/trytond/model/modelstorage.py
File trytond/model/modelstorage.py (right):

https://codereview.tryton.org/26711002/diff/40001/trytond/model/modelstorage....
trytond/model/modelstorage.py:871: error_args['record'] = record.id
I would prefer to do this the later possible because the exception may
invalidate the transaction and so it will prevent the search below.

https://codereview.tryton.org/26711002/diff/40001/trytond/model/modelstorage....
trytond/model/modelstorage.py:1010: invalid_ids = sub_relations ^ set(finds)
it is not ids.

[reviewbot, 2022-07-15 12:21:01]

checks OK
URL: https://codereview.tryton.org/26711002

[pokoli, 2022-07-15 12:50:20]

https://codereview.tryton.org/26711002/diff/411431003/trytond/model/modelsql.py
File trytond/model/modelsql.py (right):

https://codereview.tryton.org/26711002/diff/411431003/trytond/model/modelsql....
trytond/model/modelsql.py:419: gettext('ir.msg_size_validation_record',
**error_args))
should not be 'msg_size_validation' (without record) ?

[ced, 2022-07-15 13:18:58]

https://codereview.tryton.org/26711002/diff/411431003/trytond/model/modelsql.py
File trytond/model/modelsql.py (right):

https://codereview.tryton.org/26711002/diff/411431003/trytond/model/modelsql....
trytond/model/modelsql.py:419: gettext('ir.msg_size_validation_record',
**error_args))
On 2022/07/15 12:50:20, pokoli wrote:
> should not be 'msg_size_validation' (without record) ?

Done.

[reviewbot, 2022-07-15 13:50:09]

patch is not applicable
URL: https://codereview.tryton.org/26711002

[rietveld-bot_tryton.org, 2022-08-06 21:06:07]

New changeset 1b42f8379b1e by Cédric Krier in branch 'default':
Include record name and value in validation error message
https://hg.tryton.org/trytond/rev/1b42f8379b1e

[rietveld-bot_tryton.org, 2022-08-06 21:06:15]

New changeset 484a7e89f662 by Cédric Krier in branch 'default':
Include record name and value in validation error message
https://hg.tryton.org/tryton-env/rev/484a7e89f662