Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2145)

Issue 269131002: tryton: Open CSV file with empty newline (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by ced
Modified:
1 month, 3 weeks ago
Reviewers:
rietveld-bot, reviewbot
Visibility:
Public.

Description

The csv module takes care of managing the newline so we must open the file without the universal new line management. issue8006

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tryton/gui/window/win_export.py View 1 chunk +1 line, -1 line 0 comments Download
M tryton/gui/window/win_import.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
ced
2 months, 1 week ago (2019-03-13 15:23:52 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/269131002
2 months, 1 week ago (2019-03-13 15:40:31 UTC) #2
rietveld-bot_tryton.org
New changeset 841e8f907d37 by Cédric Krier in branch 'default': Open CSV file with empty newline ...
2 months ago (2019-03-22 10:21:07 UTC) #3
rietveld-bot_tryton.org
New changeset 5d4f2d701929 by Cédric Krier in branch 'default': Open CSV file with empty newline ...
2 months ago (2019-03-22 10:21:08 UTC) #4
rietveld-bot_tryton.org
1 month, 3 weeks ago (2019-03-28 18:58:08 UTC) #5
New changeset f5454c8aeab9 by Cédric Krier in branch '5.0':
Open CSV file with empty newline
https://hg.tryton.org/tryton/rev/f5454c8aeab9
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766