Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2102)

Issue 269251028: stock: Allow move as move's origin

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 2 weeks ago by ced
Modified:
2 weeks, 2 days ago
Reviewers:
pokoli, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update #

Patch Set 3 : Add origin to inventory of shipment out #

Total comments: 2

Patch Set 4 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M CHANGELOG View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M move.py View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M shipment.py View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
M tests/scenario_stock_shipment_out.rst View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10
ced
stock: Allow move as move's origin issue8253
1 month, 2 weeks ago (2019-04-03 14:52:36 UTC) #1
ced
1 month, 2 weeks ago (2019-04-03 15:01:19 UTC) #2
reviewbot
https://codereview.tryton.org/269251028/diff/251221002/move.py#newcode1056 move.py:1056: E712 comparison to True should be 'if cond is not True:' or 'if ...
1 month, 2 weeks ago (2019-04-03 15:11:14 UTC) #3
ced
1 month, 2 weeks ago (2019-04-03 15:28:07 UTC) #4
reviewbot
https://codereview.tryton.org/269251028/diff/281301002/move.py#newcode1056 move.py:1056: E712 comparison to True should be 'if cond is not True:' or 'if ...
1 month, 2 weeks ago (2019-04-03 15:35:25 UTC) #5
pokoli
https://codereview.tryton.org/269251028/diff/281301002/shipment.py File shipment.py (right): https://codereview.tryton.org/269251028/diff/281301002/shipment.py#newcode1751 shipment.py:1751: move.origin = incoming_move does it make sense to test ...
3 weeks, 3 days ago (2019-04-29 09:38:22 UTC) #6
ced
https://codereview.tryton.org/269251028/diff/281301002/shipment.py File shipment.py (right): https://codereview.tryton.org/269251028/diff/281301002/shipment.py#newcode1751 shipment.py:1751: move.origin = incoming_move On 2019/04/29 09:38:21, pokoli wrote: > ...
3 weeks, 2 days ago (2019-04-30 15:15:59 UTC) #7
ced
3 weeks, 2 days ago (2019-04-30 15:16:10 UTC) #8
reviewbot
https://codereview.tryton.org/269251028/diff/281481002/move.py#newcode1023 move.py:1023: E712 comparison to True should be 'if cond is not True:' or 'if ...
3 weeks, 2 days ago (2019-04-30 15:34:06 UTC) #9
pokoli
2 weeks, 2 days ago (2019-05-07 10:59:29 UTC) #10
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766