Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1247)

Issue 27011002: account_invoice: Add domain on journal of invoice

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 4 months ago by nando
Modified:
2 years, 3 months ago
Reviewers:
pokoli, ced, reviewbot
Visibility:
Public.

Description

Domain added to the journal on the invoice, only the revenue and expense journals are filtered issue5175

Patch Set 1 #

Total comments: 2

Patch Set 2 : add domain on journal of invoice #

Patch Set 3 : add domain to journal of invoice #

Patch Set 4 : add domain on journal of invoice #

Total comments: 7

Patch Set 5 : add domain on journal of invoice #

Total comments: 2

Patch Set 6 : account_invoice:add domain on journal of invoice #

Patch Set 7 : account_invoice:Add domain on journal of invoice #

Patch Set 8 : account_invoice:Add domain on journal of invoice #

Total comments: 3

Patch Set 9 : account_invoice:Add domain on journal of invoice #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M invoice.py View 1 2 3 4 5 6 7 8 3 chunks +6 lines, -4 lines 2 comments Download

Messages

Total messages: 29
nando
2 years, 4 months ago (2016-12-29 02:27:17 UTC) #1
reviewbot
Review's title does not follow the convention: '^([A-Za-z_][\w\.-]+)( [0-9.]+)?:' URL: https://codereview.tryton.org/27011002
2 years, 4 months ago (2016-12-29 02:30:14 UTC) #2
pokoli
You should prefix the review title with the module name (account_invoice in this case) The ...
2 years, 4 months ago (2016-12-29 17:32:28 UTC) #3
nando
2 years, 4 months ago (2017-01-08 14:19:44 UTC) #4
reviewbot
https://codereview.tryton.org/27011002/diff/20001/invoice.py#newcode616 invoice.py:616: W291 trailing whitespace URL: https://codereview.tryton.org/27011002
2 years, 4 months ago (2017-01-08 14:39:15 UTC) #5
nando
2 years, 4 months ago (2017-01-08 15:07:16 UTC) #6
reviewbot
https://codereview.tryton.org/27011002/diff/40001/invoice.py#newcode614 invoice.py:614: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/27011002
2 years, 4 months ago (2017-01-08 15:10:21 UTC) #7
nando
2 years, 4 months ago (2017-01-08 15:13:04 UTC) #8
reviewbot
flake8 OK URL: https://codereview.tryton.org/27011002
2 years, 4 months ago (2017-01-08 15:41:55 UTC) #9
pokoli
https://tryton-rietveld.appspot.com/27011002/diff/60001/invoice.py File invoice.py (right): https://tryton-rietveld.appspot.com/27011002/diff/60001/invoice.py#newcode129 invoice.py:129: states=_STATES, depends=_DEPENDS, domain=[If(Eval('type').in_(['out']), Won't be simpler to express domain ...
2 years, 4 months ago (2017-01-10 08:58:29 UTC) #10
ced
Please put the issue number on a new line like the example in the website. ...
2 years, 4 months ago (2017-01-10 10:10:29 UTC) #11
nando
issue5175
2 years, 4 months ago (2017-01-11 17:48:08 UTC) #12
reviewbot
https://codereview.tryton.org/27011002/diff/70001/invoice.py#newcode2645 invoice.py:2645: E251 unexpected spaces around keyword / parameter equals https://codereview.tryton.org/27011002/diff/70001/invoice.py#newcode2650 invoice.py:2650: E302 expected 2 ...
2 years, 4 months ago (2017-01-11 18:06:49 UTC) #13
ced
On 2017/01/11 17:48:08, nando wrote: > issue5175 Please try to put a meaningful title for ...
2 years, 4 months ago (2017-01-11 18:12:40 UTC) #14
ced
https://tryton-rietveld.appspot.com/27011002/diff/70001/invoice.py File invoice.py (right): https://tryton-rietveld.appspot.com/27011002/diff/70001/invoice.py#newcode33 invoice.py:33: 'PayInvoice', 'CreditInvoiceStart', 'CreditInvoice'] Please do not change if not ...
2 years, 4 months ago (2017-01-11 18:14:33 UTC) #15
nando
issue5175
2 years, 4 months ago (2017-01-12 05:01:02 UTC) #16
reviewbot
flake8 OK URL: https://codereview.tryton.org/27011002
2 years, 4 months ago (2017-01-12 05:16:41 UTC) #17
ced
On 2017/01/11 18:12:40, ced wrote: > On 2017/01/11 17:48:08, nando wrote: > > issue5175 > ...
2 years, 4 months ago (2017-01-12 09:35:33 UTC) #18
nando
issue5175
2 years, 3 months ago (2017-01-26 03:13:09 UTC) #19
reviewbot
https://codereview.tryton.org/27011002/diff/110001/invoice.py#newcode118 invoice.py:118: E231 missing whitespace after ',' https://codereview.tryton.org/27011002/diff/110001/invoice.py#newcode614 invoice.py:614: E127 continuation line over-indented for visual ...
2 years, 3 months ago (2017-01-26 03:14:26 UTC) #20
nando
issue5175
2 years, 3 months ago (2017-01-26 03:25:39 UTC) #21
reviewbot
flake8 OK URL: https://codereview.tryton.org/27011002
2 years, 3 months ago (2017-01-26 03:42:34 UTC) #22
pokoli
https://tryton-rietveld.appspot.com/27011002/diff/130001/invoice.py File invoice.py (right): https://tryton-rietveld.appspot.com/27011002/diff/130001/invoice.py#newcode129 invoice.py:129: states=_STATES, depends=_DEPENDS, domain=[If(Eval('type') == 'out', Better to put on ...
2 years, 3 months ago (2017-01-26 08:10:57 UTC) #23
nando
On 2017/01/26 08:10:57, pokoli wrote: > https://tryton-rietveld.appspot.com/27011002/diff/130001/invoice.py > File invoice.py (right): > > https://tryton-rietveld.appspot.com/27011002/diff/130001/invoice.py#newcode129 > ...
2 years, 3 months ago (2017-01-26 15:05:13 UTC) #24
pokoli
On 2017/01/26 15:05:13, nando wrote: > On 2017/01/26 08:10:57, pokoli wrote: > > https://tryton-rietveld.appspot.com/27011002/diff/130001/invoice.py > ...
2 years, 3 months ago (2017-01-26 15:09:41 UTC) #25
nando
issue5175
2 years, 3 months ago (2017-01-26 15:12:12 UTC) #26
reviewbot
flake8 OK URL: https://codereview.tryton.org/27011002
2 years, 3 months ago (2017-01-26 15:13:29 UTC) #27
pokoli
There are still the same changes that are not required for this review. https://tryton-rietveld.appspot.com/27011002/diff/150001/invoice.py File ...
2 years, 3 months ago (2017-01-27 09:11:02 UTC) #28
ced
2 years, 3 months ago (2017-01-27 09:44:46 UTC) #29
https://tryton-rietveld.appspot.com/27011002/diff/150001/invoice.py
File invoice.py (right):

https://tryton-rietveld.appspot.com/27011002/diff/150001/invoice.py#newcode129
invoice.py:129: states=_STATES, depends=_DEPENDS, domain=[If(Eval('type') ==
'out',
On 2017/01/27 09:11:01, pokoli wrote:
> type must be added on depends. 

By running the tests for the module, such issue should be catch.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766