Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2106)

Issue 27111002: sale: Cancel draft moves and invoices when canceling processed order (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 3 months ago by xcodinas
Modified:
1 year, 8 months ago
Reviewers:
pokoli, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 10

Patch Set 2 : Don't cancel paid invoices, add ignored moves per line, fix tests #

Patch Set 3 : Fix ident #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -0 lines) Patch
M sale.py View 1 2 2 chunks +41 lines, -0 lines 0 comments Download
M tests/scenario_sale.rst View 1 1 chunk +71 lines, -0 lines 3 comments Download
M view/sale_form.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8
xcodinas
2 years, 3 months ago (2017-02-14 12:39:43 UTC) #1
pokoli
https://tryton-rietveld-hrd.appspot.com/27111002/diff/1/sale.py File sale.py (right): https://tryton-rietveld-hrd.appspot.com/27111002/diff/1/sale.py#newcode889 sale.py:889: ([i for i in sale.invoices if i.state != 'posted'])) ...
2 years, 3 months ago (2017-02-14 12:59:37 UTC) #2
reviewbot
flake8 OK URL: https://codereview.tryton.org/27111002
2 years, 3 months ago (2017-02-14 13:04:14 UTC) #3
xcodinas
Don't cancel paid invoices, add ignored moves per line, fix tests
2 years, 3 months ago (2017-02-16 09:54:19 UTC) #4
reviewbot
https://codereview.tryton.org/27111002/diff/20001/sale.py#newcode890 sale.py:890: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/27111002
2 years, 3 months ago (2017-02-16 09:58:02 UTC) #5
xcodinas
Fix ident
2 years, 3 months ago (2017-02-16 10:10:32 UTC) #6
pokoli
https://tryton-rietveld.appspot.com/27111002/diff/40001/tests/scenario_sale.rst File tests/scenario_sale.rst (right): https://tryton-rietveld.appspot.com/27111002/diff/40001/tests/scenario_sale.rst#newcode777 tests/scenario_sale.rst:777: >>> len(sale.invoices) Same as purchase review https://tryton-rietveld.appspot.com/27111002/diff/40001/tests/scenario_sale.rst#newcode779 tests/scenario_sale.rst:779: >>> ...
2 years, 3 months ago (2017-02-16 10:34:56 UTC) #7
reviewbot
2 years, 3 months ago (2017-02-16 10:36:42 UTC) #8
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766