Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12)

Issue 271131003: tryton-env: Add secondary unit

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 6 days ago by ced
Modified:
1 week ago
Reviewers:
pokoli, albert, smn, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 9

Patch Set 2 : Add account_invoice_secondary_unit #

Total comments: 4

Patch Set 3 : Add stock_secondary_unit #

Patch Set 4 : Missing doc #

Patch Set 5 : Add purchase_secondary_unit #

Patch Set 6 : Add secondary on product and product customer/supplier #

Patch Set 7 : update to tip #

Patch Set 8 : Update amount when price or quantity changes and update unit price if quantity change #

Patch Set 9 : Ensure integrity if secondary uom are changed on product #

Patch Set 10 : Set secondary unit on opportunity with different category #

Patch Set 11 : Update to tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5740 lines, -41 lines) Patch
M .hgsub View 1 2 3 4 4 chunks +4 lines, -0 lines 0 comments Download
A modules/account_invoice_secondary_unit/.drone.yml View 1 2 3 4 5 6 1 chunk +45 lines, -0 lines 0 comments Download
A modules/account_invoice_secondary_unit/COPYRIGHT View 1 1 chunk +15 lines, -0 lines 0 comments Download
A modules/account_invoice_secondary_unit/LICENSE View 1 1 chunk +674 lines, -0 lines 0 comments Download
A modules/account_invoice_secondary_unit/MANIFEST.in View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
A modules/account_invoice_secondary_unit/README.rst View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
A modules/account_invoice_secondary_unit/__init__.py View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
A modules/account_invoice_secondary_unit/account.py View 1 2 3 4 5 6 7 1 chunk +134 lines, -0 lines 0 comments Download
A modules/account_invoice_secondary_unit/account.xml View 1 1 chunk +12 lines, -0 lines 0 comments Download
A modules/account_invoice_secondary_unit/doc/index.rst View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
A modules/account_invoice_secondary_unit/setup.py View 1 2 3 4 5 6 1 chunk +131 lines, -0 lines 0 comments Download
A modules/account_invoice_secondary_unit/tests/__init__.py View 1 1 chunk +9 lines, -0 lines 0 comments Download
A modules/account_invoice_secondary_unit/tests/test_account_invoice_secondary_unit.py View 1 1 chunk +19 lines, -0 lines 0 comments Download
A modules/account_invoice_secondary_unit/tox.ini View 1 2 3 4 5 6 1 chunk +15 lines, -0 lines 0 comments Download
A modules/account_invoice_secondary_unit/tryton.cfg View 1 1 chunk +8 lines, -0 lines 0 comments Download
A modules/account_invoice_secondary_unit/view/account_invoice_line_form.xml View 1 1 chunk +15 lines, -0 lines 0 comments Download
M modules/product/CHANGELOG View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M modules/product/doc/index.rst View 1 chunk +6 lines, -3 lines 0 comments Download
M modules/product/tests/test_product.py View 2 chunks +47 lines, -0 lines 0 comments Download
M modules/product/uom.py View 11 chunks +72 lines, -31 lines 0 comments Download
A modules/purchase_secondary_unit/.drone.yml View 1 2 3 4 1 chunk +46 lines, -0 lines 0 comments Download
A modules/purchase_secondary_unit/COPYRIGHT View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download
A modules/purchase_secondary_unit/LICENSE View 1 2 3 4 1 chunk +674 lines, -0 lines 0 comments Download
A modules/purchase_secondary_unit/MANIFEST.in View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
A modules/purchase_secondary_unit/README.rst View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
A modules/purchase_secondary_unit/__init__.py View 1 2 3 4 5 1 chunk +21 lines, -0 lines 0 comments Download
A modules/purchase_secondary_unit/account.py View 1 2 3 4 5 6 7 8 1 chunk +35 lines, -0 lines 0 comments Download
A modules/purchase_secondary_unit/doc/index.rst View 1 2 3 4 5 1 chunk +9 lines, -0 lines 0 comments Download
A modules/purchase_secondary_unit/message.xml View 1 2 3 4 5 1 chunk +10 lines, -0 lines 0 comments Download
A modules/purchase_secondary_unit/product.py View 1 2 3 4 5 1 chunk +150 lines, -0 lines 0 comments Download
A modules/purchase_secondary_unit/product.xml View 1 2 3 4 5 1 chunk +18 lines, -0 lines 0 comments Download
A modules/purchase_secondary_unit/purchase.py View 1 2 3 4 5 6 7 8 1 chunk +191 lines, -0 lines 0 comments Download
A modules/purchase_secondary_unit/purchase.xml View 1 2 3 4 1 chunk +25 lines, -0 lines 0 comments Download
A modules/purchase_secondary_unit/setup.py View 1 2 3 4 5 6 1 chunk +131 lines, -0 lines 0 comments Download
A modules/purchase_secondary_unit/stock.py View 1 2 3 4 5 6 7 8 1 chunk +35 lines, -0 lines 0 comments Download
A modules/purchase_secondary_unit/stock.xml View 1 2 3 4 1 chunk +12 lines, -0 lines 0 comments Download
A modules/purchase_secondary_unit/tests/__init__.py View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
A modules/purchase_secondary_unit/tests/scenario_purchase_secondary_unit.rst View 1 2 3 4 5 1 chunk +138 lines, -0 lines 0 comments Download
A modules/purchase_secondary_unit/tests/test_purchase_secondary_unit.py View 1 2 3 4 1 chunk +28 lines, -0 lines 0 comments Download
A modules/purchase_secondary_unit/tox.ini View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download
A modules/purchase_secondary_unit/tryton.cfg View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download
A modules/purchase_secondary_unit/view/product_supplier_form.xml View 1 2 3 4 5 1 chunk +15 lines, -0 lines 0 comments Download
A modules/purchase_secondary_unit/view/product_template_form.xml View 1 2 3 4 5 1 chunk +15 lines, -0 lines 0 comments Download
A modules/purchase_secondary_unit/view/purchase_line_form.xml View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download
A modules/purchase_secondary_unit/view/purchase_line_tree.xml View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
A modules/purchase_secondary_unit/view/stock_move_list.xml View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
M modules/sale_opportunity/opportunity.py View 1 2 3 4 5 6 7 8 9 1 chunk +6 lines, -2 lines 0 comments Download
A modules/sale_secondary_unit/.drone.yml View 1 2 3 4 5 6 1 chunk +45 lines, -0 lines 0 comments Download
A modules/sale_secondary_unit/COPYRIGHT View 1 chunk +15 lines, -0 lines 0 comments Download
A modules/sale_secondary_unit/LICENSE View 1 chunk +674 lines, -0 lines 0 comments Download
A modules/sale_secondary_unit/MANIFEST.in View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
A modules/sale_secondary_unit/README.rst View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
A modules/sale_secondary_unit/__init__.py View 1 2 3 4 5 6 7 8 9 1 chunk +29 lines, -0 lines 0 comments Download
A modules/sale_secondary_unit/account.py View 1 2 3 4 5 6 7 8 1 chunk +35 lines, -0 lines 0 comments Download
A modules/sale_secondary_unit/doc/index.rst View 1 2 3 4 5 1 chunk +12 lines, -0 lines 0 comments Download
A modules/sale_secondary_unit/message.xml View 1 2 3 4 5 1 chunk +10 lines, -0 lines 0 comments Download
A modules/sale_secondary_unit/product.py View 1 2 3 4 5 1 chunk +148 lines, -0 lines 0 comments Download
A modules/sale_secondary_unit/product.xml View 1 2 3 4 5 1 chunk +20 lines, -0 lines 0 comments Download
A modules/sale_secondary_unit/sale.py View 1 2 3 4 5 6 7 8 9 1 chunk +211 lines, -0 lines 0 comments Download
A modules/sale_secondary_unit/sale.xml View 1 chunk +24 lines, -0 lines 0 comments Download
A modules/sale_secondary_unit/setup.py View 1 2 3 4 5 6 1 chunk +132 lines, -0 lines 0 comments Download
A modules/sale_secondary_unit/stock.py View 1 2 3 4 5 6 7 8 1 chunk +35 lines, -0 lines 0 comments Download
A modules/sale_secondary_unit/stock.xml View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
A modules/sale_secondary_unit/tests/__init__.py View 1 chunk +9 lines, -0 lines 0 comments Download
A modules/sale_secondary_unit/tests/scenario_sale_secondary_unit.rst View 1 2 3 4 1 chunk +132 lines, -0 lines 0 comments Download
A modules/sale_secondary_unit/tests/test_sale_secondary_unit.py View 1 2 3 4 5 1 chunk +31 lines, -0 lines 0 comments Download
A modules/sale_secondary_unit/tox.ini View 1 2 3 4 5 6 1 chunk +15 lines, -0 lines 0 comments Download
A modules/sale_secondary_unit/tryton.cfg View 1 2 3 4 5 6 7 8 9 1 chunk +18 lines, -0 lines 0 comments Download
A modules/sale_secondary_unit/view/product_customer_form.xml View 1 2 3 4 5 1 chunk +15 lines, -0 lines 0 comments Download
A modules/sale_secondary_unit/view/product_template_form.xml View 1 chunk +16 lines, -0 lines 0 comments Download
A modules/sale_secondary_unit/view/sale_line_form.xml View 1 chunk +15 lines, -0 lines 0 comments Download
A modules/sale_secondary_unit/view/sale_line_tree.xml View 1 chunk +10 lines, -0 lines 0 comments Download
A modules/sale_secondary_unit/view/stock_move_list.xml View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M modules/stock/CHANGELOG View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M modules/stock/move.py View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M modules/stock/shipment.py View 1 2 4 chunks +5 lines, -2 lines 0 comments Download
A modules/stock_secondary_unit/.drone.yml View 1 2 1 chunk +46 lines, -0 lines 0 comments Download
A modules/stock_secondary_unit/COPYRIGHT View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
A modules/stock_secondary_unit/LICENSE View 1 2 1 chunk +674 lines, -0 lines 0 comments Download
A modules/stock_secondary_unit/MANIFEST.in View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
A modules/stock_secondary_unit/README.rst View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
A modules/stock_secondary_unit/__init__.py View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
A modules/stock_secondary_unit/doc/index.rst View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
A modules/stock_secondary_unit/setup.py View 1 2 3 4 5 6 1 chunk +129 lines, -0 lines 0 comments Download
A modules/stock_secondary_unit/stock.py View 1 2 1 chunk +160 lines, -0 lines 0 comments Download
A modules/stock_secondary_unit/stock.xml View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
A modules/stock_secondary_unit/tests/__init__.py View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
A modules/stock_secondary_unit/tests/test_stock_secondary_unit.py View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
A modules/stock_secondary_unit/tox.ini View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
A modules/stock_secondary_unit/tryton.cfg View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
A modules/stock_secondary_unit/view/stock_move_form.xml View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
A modules/stock_secondary_unit/view/stock_move_tree.xml View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M readthedocs/account.rst View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M readthedocs/purchase.rst View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M readthedocs/sale.rst View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M readthedocs/stock.rst View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 32
ced
2 weeks, 6 days ago (2019-03-29 12:42:36 UTC) #1
pokoli
https://codereview.tryton.org/271131003/diff/265161002/modules/sale_secondary_unit/sale.py File modules/sale_secondary_unit/sale.py (right): https://codereview.tryton.org/271131003/diff/265161002/modules/sale_secondary_unit/sale.py#newcode54 modules/sale_secondary_unit/sale.py:54: 'required': Bool(Eval('secondary_unit')), I think it should be invisible if ...
2 weeks, 6 days ago (2019-03-29 12:57:31 UTC) #2
reviewbot
https://codereview.tryton.org/271131003/diff/265161002/modules/sale_secondary_unit/setup.py#newcode85 modules/sale_secondary_unit/setup.py:85: E501 line too long (85 > 79 characters) https://codereview.tryton.org/271131003/diff/265161002/modules/sale_secondary_unit/tests/__init__.py#newcode5 modules/sale_secondary_unit/tests/__init__.py:5: E501 line too ...
2 weeks, 6 days ago (2019-03-29 13:12:04 UTC) #3
ced
https://codereview.tryton.org/271131003/diff/265161002/modules/sale_secondary_unit/sale.py File modules/sale_secondary_unit/sale.py (right): https://codereview.tryton.org/271131003/diff/265161002/modules/sale_secondary_unit/sale.py#newcode54 modules/sale_secondary_unit/sale.py:54: 'required': Bool(Eval('secondary_unit')), On 2019/03/29 12:57:31, pokoli wrote: > I ...
2 weeks, 6 days ago (2019-03-29 13:17:24 UTC) #4
ced
https://codereview.tryton.org/271131003/diff/265161002/modules/sale_secondary_unit/view/product_template_form.xml File modules/sale_secondary_unit/view/product_template_form.xml (right): https://codereview.tryton.org/271131003/diff/265161002/modules/sale_secondary_unit/view/product_template_form.xml#newcode9 modules/sale_secondary_unit/view/product_template_form.xml:9: <group id="sale_secondary_uom" col="-1" colspan="2"> On 2019/03/29 12:57:31, pokoli wrote: ...
2 weeks, 6 days ago (2019-03-29 13:19:18 UTC) #5
ced
2 weeks, 6 days ago (2019-03-29 15:49:49 UTC) #6
reviewbot
https://codereview.tryton.org/271131003/diff/283121002/modules/sale_secondary_unit/setup.py#newcode86 modules/sale_secondary_unit/setup.py:86: E501 line too long (85 > 79 characters) https://codereview.tryton.org/271131003/diff/283121002/modules/sale_secondary_unit/tests/__init__.py#newcode5 modules/sale_secondary_unit/tests/__init__.py:5: E501 line too ...
2 weeks, 6 days ago (2019-03-29 16:22:55 UTC) #7
smn
https://codereview.tryton.org/271131003/diff/283121002/modules/account_invoice_secondary_unit/account.py File modules/account_invoice_secondary_unit/account.py (right): https://codereview.tryton.org/271131003/diff/283121002/modules/account_invoice_secondary_unit/account.py#newcode125 modules/account_invoice_secondary_unit/account.py:125: return None What if we want to define secondary ...
2 weeks, 6 days ago (2019-03-29 16:30:38 UTC) #8
ced
https://codereview.tryton.org/271131003/diff/283121002/modules/account_invoice_secondary_unit/account.py File modules/account_invoice_secondary_unit/account.py (right): https://codereview.tryton.org/271131003/diff/283121002/modules/account_invoice_secondary_unit/account.py#newcode125 modules/account_invoice_secondary_unit/account.py:125: return None On 2019/03/29 16:30:38, smn wrote: > What ...
2 weeks, 6 days ago (2019-03-29 18:25:59 UTC) #9
albert
https://codereview.tryton.org/271131003/diff/283121002/modules/sale_secondary_unit/sale.py File modules/sale_secondary_unit/sale.py (right): https://codereview.tryton.org/271131003/diff/283121002/modules/sale_secondary_unit/sale.py#newcode57 modules/sale_secondary_unit/sale.py:57: secondary_uom_rate = fields.Float( I don't understand what is the ...
2 weeks, 4 days ago (2019-03-31 19:07:30 UTC) #10
ced
https://codereview.tryton.org/271131003/diff/283121002/modules/sale_secondary_unit/sale.py File modules/sale_secondary_unit/sale.py (right): https://codereview.tryton.org/271131003/diff/283121002/modules/sale_secondary_unit/sale.py#newcode57 modules/sale_secondary_unit/sale.py:57: secondary_uom_rate = fields.Float( On 2019/03/31 19:07:30, albert wrote: > ...
2 weeks, 4 days ago (2019-03-31 19:47:48 UTC) #11
pokoli
https://codereview.tryton.org/271131003/diff/265161002/modules/sale_secondary_unit/sale.py File modules/sale_secondary_unit/sale.py (right): https://codereview.tryton.org/271131003/diff/265161002/modules/sale_secondary_unit/sale.py#newcode54 modules/sale_secondary_unit/sale.py:54: 'required': Bool(Eval('secondary_unit')), On 2019/03/29 13:17:23, ced wrote: > On ...
2 weeks, 3 days ago (2019-04-01 07:53:56 UTC) #12
ced
https://codereview.tryton.org/271131003/diff/265161002/modules/sale_secondary_unit/sale.py File modules/sale_secondary_unit/sale.py (right): https://codereview.tryton.org/271131003/diff/265161002/modules/sale_secondary_unit/sale.py#newcode54 modules/sale_secondary_unit/sale.py:54: 'required': Bool(Eval('secondary_unit')), On 2019/04/01 07:53:56, pokoli wrote: > On ...
2 weeks, 3 days ago (2019-04-01 08:22:21 UTC) #13
pokoli
https://codereview.tryton.org/271131003/diff/265161002/modules/sale_secondary_unit/sale.py File modules/sale_secondary_unit/sale.py (right): https://codereview.tryton.org/271131003/diff/265161002/modules/sale_secondary_unit/sale.py#newcode54 modules/sale_secondary_unit/sale.py:54: 'required': Bool(Eval('secondary_unit')), On 2019/04/01 08:22:21, ced wrote: > On ...
2 weeks, 3 days ago (2019-04-01 11:42:14 UTC) #14
ced
https://codereview.tryton.org/271131003/diff/265161002/modules/sale_secondary_unit/sale.py File modules/sale_secondary_unit/sale.py (right): https://codereview.tryton.org/271131003/diff/265161002/modules/sale_secondary_unit/sale.py#newcode54 modules/sale_secondary_unit/sale.py:54: 'required': Bool(Eval('secondary_unit')), On 2019/04/01 11:42:14, pokoli wrote: > On ...
2 weeks, 1 day ago (2019-04-03 11:03:39 UTC) #15
ced
2 weeks, 1 day ago (2019-04-03 15:47:43 UTC) #16
ced
2 weeks, 1 day ago (2019-04-03 15:51:24 UTC) #17
reviewbot
https://codereview.tryton.org/271131003/diff/269271002/modules/stock/move.py#newcode1056 modules/stock/move.py:1056: E712 comparison to True should be 'if cond is not True:' or 'if ...
2 weeks, 1 day ago (2019-04-03 16:18:04 UTC) #18
ced
2 weeks ago (2019-04-04 16:56:33 UTC) #19
reviewbot
https://codereview.tryton.org/271131003/diff/271221002/modules/stock/move.py#newcode1056 modules/stock/move.py:1056: E712 comparison to True should be 'if cond is not True:' or 'if ...
2 weeks ago (2019-04-04 17:11:09 UTC) #20
ced
1 week, 3 days ago (2019-04-08 16:05:14 UTC) #21
reviewbot
https://codereview.tryton.org/271131003/diff/253301002/modules/stock/move.py#newcode1056 modules/stock/move.py:1056: E712 comparison to True should be 'if cond is not True:' or 'if ...
1 week, 3 days ago (2019-04-08 16:11:27 UTC) #22
ced
1 week, 3 days ago (2019-04-08 16:49:24 UTC) #23
reviewbot
https://codereview.tryton.org/271131003/diff/281361002/modules/stock/move.py#newcode1056 modules/stock/move.py:1056: E712 comparison to True should be 'if cond is not True:' or 'if ...
1 week, 3 days ago (2019-04-08 17:19:11 UTC) #24
ced
1 week, 1 day ago (2019-04-10 14:26:38 UTC) #25
reviewbot
https://codereview.tryton.org/271131003/diff/277221002/modules/stock/move.py#newcode1056 modules/stock/move.py:1056: E712 comparison to True should be 'if cond is not True:' or 'if ...
1 week, 1 day ago (2019-04-10 14:49:34 UTC) #26
ced
1 week, 1 day ago (2019-04-10 14:52:02 UTC) #27
reviewbot
https://codereview.tryton.org/271131003/diff/263311004/modules/stock/move.py#newcode1056 modules/stock/move.py:1056: E712 comparison to True should be 'if cond is not True:' or 'if ...
1 week, 1 day ago (2019-04-10 15:19:57 UTC) #28
ced
1 week ago (2019-04-11 16:02:17 UTC) #29
reviewbot
patch is not applicable URL: https://codereview.tryton.org/271131003
1 week ago (2019-04-11 16:09:06 UTC) #30
ced
1 week ago (2019-04-11 16:32:14 UTC) #31
reviewbot
1 week ago (2019-04-11 16:44:33 UTC) #32
https://codereview.tryton.org/271131003/diff/277241002/modules/stock/move.py#...
modules/stock/move.py:1056:
E712 comparison to True should be 'if cond is not True:' or 'if not cond:'

https://codereview.tryton.org/271131003/diff/277241002/modules/stock/move.py#...
modules/stock/move.py:1103:
E712 comparison to True should be 'if cond is True:' or 'if cond:'

https://codereview.tryton.org/271131003/diff/277241002/modules/stock/move.py#...
modules/stock/move.py:1113:
E731 do not assign a lambda expression, use a def

https://codereview.tryton.org/271131003/diff/277241002/modules/stock/move.py#...
modules/stock/move.py:1134:
E731 do not assign a lambda expression, use a def

https://codereview.tryton.org/271131003/diff/277241002/modules/stock/move.py#...
modules/stock/move.py:1175:
E731 do not assign a lambda expression, use a def

https://codereview.tryton.org/271131003/diff/277241002/modules/stock/move.py#...
modules/stock/move.py:1192:
E731 do not assign a lambda expression, use a def

https://codereview.tryton.org/271131003/diff/277241002/modules/stock/move.py#...
modules/stock/move.py:1239:
E731 do not assign a lambda expression, use a def

https://codereview.tryton.org/271131003/diff/277241002/modules/stock_secondar...
modules/stock_secondary_unit/setup.py:77:
E501 line too long (80 > 79 characters)

https://codereview.tryton.org/271131003/diff/277241002/modules/stock_secondar...
modules/stock_secondary_unit/setup.py:91:
E501 line too long (85 > 79 characters)

https://codereview.tryton.org/271131003/diff/277241002/modules/stock_secondar...
modules/stock_secondary_unit/tests/__init__.py:5:
E501 line too long (90 > 79 characters)

https://codereview.tryton.org/271131003/diff/277241002/modules/sale_secondary...
modules/sale_secondary_unit/setup.py:94:
E501 line too long (85 > 79 characters)

https://codereview.tryton.org/271131003/diff/277241002/modules/sale_secondary...
modules/sale_secondary_unit/tests/__init__.py:5:
E501 line too long (88 > 79 characters)

https://codereview.tryton.org/271131003/diff/277241002/modules/sale_opportuni...
modules/sale_opportunity/opportunity.py:598:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/271131003/diff/277241002/modules/sale_opportuni...
modules/sale_opportunity/opportunity.py:600:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/271131003/diff/277241002/modules/sale_opportuni...
modules/sale_opportunity/opportunity.py:602:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/271131003/diff/277241002/modules/sale_opportuni...
modules/sale_opportunity/opportunity.py:605:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/271131003/diff/277241002/modules/sale_opportuni...
modules/sale_opportunity/opportunity.py:608:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/271131003/diff/277241002/modules/account_invoic...
modules/account_invoice_secondary_unit/setup.py:78:
E501 line too long (90 > 79 characters)

https://codereview.tryton.org/271131003/diff/277241002/modules/account_invoic...
modules/account_invoice_secondary_unit/setup.py:92:
E501 line too long (85 > 79 characters)

https://codereview.tryton.org/271131003/diff/277241002/modules/account_invoic...
modules/account_invoice_secondary_unit/setup.py:126:
E501 line too long (83 > 79 characters)

https://codereview.tryton.org/271131003/diff/277241002/modules/account_invoic...
modules/account_invoice_secondary_unit/tests/__init__.py:5:
E501 line too long (110 > 79 characters)

https://codereview.tryton.org/271131003/diff/277241002/modules/purchase_secon...
modules/purchase_secondary_unit/setup.py:79:
E501 line too long (83 > 79 characters)

https://codereview.tryton.org/271131003/diff/277241002/modules/purchase_secon...
modules/purchase_secondary_unit/setup.py:93:
E501 line too long (85 > 79 characters)

https://codereview.tryton.org/271131003/diff/277241002/modules/purchase_secon...
modules/purchase_secondary_unit/tests/__init__.py:5:
E501 line too long (96 > 79 characters)

URL: https://codereview.tryton.org/271131003
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766