Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Issue 273651002: tryton-env: Add placeholder for fields

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 10 months ago by pokoli
Modified:
2 years, 9 months ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fix comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -21 lines) Patch
M modules/party/party.py View 1 chunk +2 lines, -1 line 0 comments Download
M sao/CHANGELOG View 1 1 chunk +1 line, -0 lines 0 comments Download
M sao/src/view.js View 1 chunk +3 lines, -0 lines 0 comments Download
M sao/src/view/form.js View 3 chunks +9 lines, -0 lines 0 comments Download
M tryton/CHANGELOG View 1 1 chunk +1 line, -0 lines 0 comments Download
M tryton/tryton/gui/window/view_form/view/__init__.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tryton/tryton/gui/window/view_form/view/form_gtk/char.py View 1 chunk +3 lines, -0 lines 0 comments Download
M trytond/CHANGELOG View 1 1 chunk +1 line, -0 lines 0 comments Download
M trytond/doc/ref/models/fields.rst View 1 2 chunks +9 lines, -0 lines 0 comments Download
M trytond/trytond/ir/model.py View 3 chunks +17 lines, -5 lines 0 comments Download
M trytond/trytond/ir/translation.py View 1 15 chunks +32 lines, -12 lines 0 comments Download
M trytond/trytond/ir/ui/form.rnc View 1 chunk +1 line, -0 lines 0 comments Download
M trytond/trytond/ir/ui/form.rng View 1 chunk +8 lines, -0 lines 0 comments Download
M trytond/trytond/ir/view/model_field_form.xml View 1 chunk +2 lines, -0 lines 0 comments Download
M trytond/trytond/model/fields/char.py View 1 5 chunks +30 lines, -1 line 0 comments Download
M trytond/trytond/model/fields/field.py View 1 1 chunk +4 lines, -1 line 1 comment Download
M trytond/trytond/model/modelview.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
pokoli
2 years, 10 months ago (2019-07-24 15:44:10 UTC) #1
reviewbot
https://codereview.tryton.org/273651002/diff/259961002/trytond/trytond/model/fields/field.py#newcode36 trytond/trytond/model/fields/field.py:36: E127 continuation line over-indented for visual indent https://codereview.tryton.org/273651002/diff/259961002/trytond/trytond/model/fields/field.py#newcode38 trytond/trytond/model/fields/field.py:38: E127 continuation line over-indented ...
2 years, 10 months ago (2019-07-24 16:02:26 UTC) #2
ced
Missing documentation https://codereview.tryton.org/273651002/diff/259961002/tryton/CHANGELOG File tryton/CHANGELOG (right): https://codereview.tryton.org/273651002/diff/259961002/tryton/CHANGELOG#newcode1 tryton/CHANGELOG:1: * Add placeholder for fields I would ...
2 years, 10 months ago (2019-07-24 19:32:30 UTC) #3
pokoli
Fix comments
2 years, 10 months ago (2019-07-31 13:37:58 UTC) #4
pokoli
https://codereview.tryton.org/273651002/diff/259961002/tryton/tryton/gui/window/view_form/view/form_gtk/textbox.py File tryton/tryton/gui/window/view_form/view/form_gtk/textbox.py (right): https://codereview.tryton.org/273651002/diff/259961002/tryton/tryton/gui/window/view_form/view/form_gtk/textbox.py#newcode49 tryton/tryton/gui/window/view_form/view/form_gtk/textbox.py:49: self.entry.set_placeholder_text(attrs.get('placeholder')) On 2019/07/24 19:32:29, ced wrote: > There is ...
2 years, 10 months ago (2019-07-31 13:38:20 UTC) #5
reviewbot
https://codereview.tryton.org/273651002/diff/283841003/trytond/trytond/model/fields/field.py#newcode36 trytond/trytond/model/fields/field.py:36: E127 continuation line over-indented for visual indent https://codereview.tryton.org/273651002/diff/283841003/trytond/trytond/model/fields/field.py#newcode38 trytond/trytond/model/fields/field.py:38: E127 continuation line over-indented ...
2 years, 10 months ago (2019-07-31 14:05:16 UTC) #6
ced
2 years, 9 months ago (2019-08-07 21:09:21 UTC) #7
https://codereview.tryton.org/273651002/diff/283841003/trytond/trytond/model/...
File trytond/trytond/model/fields/field.py (right):

https://codereview.tryton.org/273651002/diff/283841003/trytond/trytond/model/...
trytond/trytond/model/fields/field.py:457: ]:
should not be changed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted