Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(139)

Issue 27421002: sao: Add CSV Import/Export (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 6 months ago by prayashm
Modified:
2 years, 1 month ago
Reviewers:
pokoli, rietveld-bot, ced, reviewbot
Visibility:
Public.

Patch Set 1 #

Total comments: 36

Patch Set 2 : Made changes as per review #

Patch Set 3 : Parse only 1st row on auto_detect, Fix default skip lines to 0 #

Patch Set 4 : Meaningful CSS for padding CSV fields #

Total comments: 25

Patch Set 5 : Fix coding style. Remove unused variable. #

Patch Set 6 : Change CSS selector to be more meaningful #

Patch Set 7 : Allow all JavaScript encodings #

Patch Set 8 : Improve assignment of default values #

Patch Set 9 : Add Export Views, Fix last expandable field #

Total comments: 38

Patch Set 10 : Remove single line ifs, Send styling to css, Better code format #

Patch Set 11 : Add Predefined Exports usage, saving and removal #

Patch Set 12 : Generate CSV from data, Make downloadable Blob URL #

Patch Set 13 : Remove open/save options. Let browser handle export file. #

Total comments: 14

Patch Set 14 : Add comments, Rename auto_detect, Fix indentation #

Patch Set 15 : Remove leading spaces from gettext #

Total comments: 41

Patch Set 16 : Refactor css #

Patch Set 17 : Remove css padding. #

Patch Set 18 : Fix expanding of All Fields on sel_predef. Change selection behavior of Fields. #

Total comments: 8

Patch Set 19 : Remove Comment #

Patch Set 20 : Remove trailing space. Add space around operator. #

Patch Set 21 : Add unexpand feature to import. Add comment for known bug #

Total comments: 6

Patch Set 22 : Separate DOM Update from Model Population #

Total comments: 6

Patch Set 23 : Add missing 'event' parameter #

Total comments: 2

Patch Set 24 : Use minified PapaParse #

Total comments: 12

Patch Set 25 : Fix styles #

Patch Set 26 : Pass fields_selected as a parameter to autodetect #

Patch Set 27 : Bring fields_selected in autodetect as an attribute #

Patch Set 28 : Update Changelog #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1003 lines, -2 lines) Patch
M CHANGELOG View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 2 chunks +2 lines, -1 line 0 comments Download
M bower.json View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 1 chunk +1 line, -0 lines 0 comments Download
M index.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 1 chunk +1 line, -0 lines 0 comments Download
M src/sao.less View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 1 chunk +9 lines, -0 lines 0 comments Download
M src/tab.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 2 chunks +13 lines, -1 line 0 comments Download
M src/window.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +977 lines, -0 lines 0 comments Download

Messages

Total messages: 118
prayashm
2 years, 6 months ago (2016-06-28 12:53:50 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/27421002
2 years, 6 months ago (2016-06-28 13:00:44 UTC) #2
pokoli
2 years, 6 months ago (2016-06-28 13:09:50 UTC) #3
ced
2 years, 6 months ago (2016-06-28 13:43:56 UTC) #4
ced
https://tryton-rietveld.appspot.com/27421002/diff/1/src/sao.less File src/sao.less (right): https://tryton-rietveld.appspot.com/27421002/diff/1/src/sao.less#newcode303 src/sao.less:303: padding-left: 5px; We try to limit the css to ...
2 years, 6 months ago (2016-06-29 09:40:33 UTC) #5
prayashm
Thanks for reviewing. https://tryton-rietveld.appspot.com/27421002/diff/1/src/sao.less File src/sao.less (right): https://tryton-rietveld.appspot.com/27421002/diff/1/src/sao.less#newcode303 src/sao.less:303: padding-left: 5px; > Is it really ...
2 years, 6 months ago (2016-06-30 06:46:47 UTC) #6
prayashm
2 years, 6 months ago (2016-06-30 06:49:26 UTC) #7
reviewbot
flake8 OK URL: https://codereview.tryton.org/27421002
2 years, 6 months ago (2016-06-30 07:00:36 UTC) #8
ced
https://tryton-rietveld.appspot.com/27421002/diff/1/src/sao.less File src/sao.less (right): https://tryton-rietveld.appspot.com/27421002/diff/1/src/sao.less#newcode303 src/sao.less:303: padding-left: 5px; On 2016/06/30 06:46:47, prayashm wrote: > > ...
2 years, 6 months ago (2016-06-30 07:15:18 UTC) #9
prayashm
2 years, 6 months ago (2016-06-30 08:13:50 UTC) #10
prayashm
https://tryton-rietveld.appspot.com/27421002/diff/1/src/sao.less File src/sao.less (right): https://tryton-rietveld.appspot.com/27421002/diff/1/src/sao.less#newcode303 src/sao.less:303: padding-left: 5px; > This is because you remove the ...
2 years, 6 months ago (2016-06-30 08:14:29 UTC) #11
reviewbot
flake8 OK URL: https://codereview.tryton.org/27421002
2 years, 6 months ago (2016-06-30 08:30:27 UTC) #12
ced
https://tryton-rietveld.appspot.com/27421002/diff/1/src/sao.less File src/sao.less (right): https://tryton-rietveld.appspot.com/27421002/diff/1/src/sao.less#newcode303 src/sao.less:303: padding-left: 5px; On 2016/06/30 08:14:29, prayashm wrote: > > ...
2 years, 6 months ago (2016-06-30 08:40:59 UTC) #13
prayashm
https://tryton-rietveld.appspot.com/27421002/diff/1/src/sao.less File src/sao.less (right): https://tryton-rietveld.appspot.com/27421002/diff/1/src/sao.less#newcode303 src/sao.less:303: padding-left: 5px; On 2016/06/30 08:40:59, ced wrote: > Then ...
2 years, 6 months ago (2016-06-30 09:08:38 UTC) #14
ced
https://tryton-rietveld.appspot.com/27421002/diff/1/src/sao.less File src/sao.less (right): https://tryton-rietveld.appspot.com/27421002/diff/1/src/sao.less#newcode303 src/sao.less:303: padding-left: 5px; On 2016/06/30 09:08:38, prayashm wrote: > On ...
2 years, 6 months ago (2016-06-30 09:25:26 UTC) #15
prayashm
https://tryton-rietveld.appspot.com/27421002/diff/1/src/sao.less File src/sao.less (right): https://tryton-rietveld.appspot.com/27421002/diff/1/src/sao.less#newcode303 src/sao.less:303: padding-left: 5px; On 2016/06/30 09:25:25, ced wrote: > I ...
2 years, 6 months ago (2016-06-30 09:53:55 UTC) #16
ced
https://tryton-rietveld.appspot.com/27421002/diff/1/src/sao.less File src/sao.less (right): https://tryton-rietveld.appspot.com/27421002/diff/1/src/sao.less#newcode303 src/sao.less:303: padding-left: 5px; On 2016/06/30 09:53:55, prayashm wrote: > On ...
2 years, 6 months ago (2016-06-30 10:10:36 UTC) #17
prayashm
2 years, 6 months ago (2016-06-30 11:47:49 UTC) #18
prayashm
https://tryton-rietveld.appspot.com/27421002/diff/1/src/sao.less File src/sao.less (right): https://tryton-rietveld.appspot.com/27421002/diff/1/src/sao.less#newcode303 src/sao.less:303: padding-left: 5px; Done.
2 years, 6 months ago (2016-06-30 11:50:58 UTC) #19
reviewbot
flake8 OK URL: https://codereview.tryton.org/27421002
2 years, 6 months ago (2016-06-30 12:00:34 UTC) #20
pokoli
https://tryton-rietveld.appspot.com/27421002/diff/60001/src/window.js File src/window.js (right): https://tryton-rietveld.appspot.com/27421002/diff/60001/src/window.js#newcode723 src/window.js:723: init: function(screen){ missing space between ) and { https://tryton-rietveld.appspot.com/27421002/diff/60001/src/window.js#newcode766 ...
2 years, 6 months ago (2016-06-30 12:27:59 UTC) #21
ced
https://tryton-rietveld.appspot.com/27421002/diff/60001/src/sao.less File src/sao.less (right): https://tryton-rietveld.appspot.com/27421002/diff/60001/src/sao.less#newcode302 src/sao.less:302: .csv_dialog li { instead of _dialog, is not better ...
2 years, 6 months ago (2016-06-30 13:09:37 UTC) #22
prayashm
https://tryton-rietveld.appspot.com/27421002/diff/60001/src/window.js File src/window.js (right): https://tryton-rietveld.appspot.com/27421002/diff/60001/src/window.js#newcode723 src/window.js:723: init: function(screen){ On 2016/06/30 12:27:59, pokoli wrote: > missing ...
2 years, 6 months ago (2016-06-30 14:13:59 UTC) #23
ced
https://tryton-rietveld.appspot.com/27421002/diff/60001/src/window.js File src/window.js (right): https://tryton-rietveld.appspot.com/27421002/diff/60001/src/window.js#newcode766 src/window.js:766: this.get_fields(this.screen.model_name).done(function(fields){ On 2016/06/30 14:13:59, prayashm wrote: > On 2016/06/30 ...
2 years, 6 months ago (2016-06-30 14:20:23 UTC) #24
pokoli
https://tryton-rietveld.appspot.com/27421002/diff/60001/src/window.js File src/window.js (right): https://tryton-rietveld.appspot.com/27421002/diff/60001/src/window.js#newcode977 src/window.js:977: if (parent_node === undefined) parent_node = this.fields_all; On 2016/06/30 ...
2 years, 6 months ago (2016-06-30 14:49:02 UTC) #25
prayashm
2 years, 6 months ago (2016-06-30 17:52:35 UTC) #26
prayashm
https://tryton-rietveld.appspot.com/27421002/diff/60001/src/window.js File src/window.js (right): https://tryton-rietveld.appspot.com/27421002/diff/60001/src/window.js#newcode766 src/window.js:766: this.get_fields(this.screen.model_name).done(function(fields){ On 2016/06/30 14:20:23, ced wrote: > > But ...
2 years, 6 months ago (2016-06-30 17:53:54 UTC) #27
reviewbot
flake8 OK URL: https://codereview.tryton.org/27421002
2 years, 6 months ago (2016-06-30 18:00:36 UTC) #28
ced
https://tryton-rietveld.appspot.com/27421002/diff/60001/src/window.js File src/window.js (right): https://tryton-rietveld.appspot.com/27421002/diff/60001/src/window.js#newcode766 src/window.js:766: this.get_fields(this.screen.model_name).done(function(fields){ On 2016/06/30 17:53:54, prayashm wrote: > On 2016/06/30 ...
2 years, 6 months ago (2016-06-30 18:30:43 UTC) #29
prayashm
On 2016/06/30 18:30:43, ced wrote: > That is the strange scope behaviour of Javascript. Oh! ...
2 years, 6 months ago (2016-07-01 04:45:39 UTC) #30
pokoli
https://tryton-rietveld.appspot.com/27421002/diff/60001/src/window.js File src/window.js (right): https://tryton-rietveld.appspot.com/27421002/diff/60001/src/window.js#newcode977 src/window.js:977: if (parent_node === undefined) parent_node = this.fields_all; On 2016/06/30 ...
2 years, 6 months ago (2016-07-04 10:03:51 UTC) #31
prayashm
https://tryton-rietveld.appspot.com/27421002/diff/60001/src/window.js File src/window.js (right): https://tryton-rietveld.appspot.com/27421002/diff/60001/src/window.js#newcode977 src/window.js:977: if (parent_node === undefined) parent_node = this.fields_all; On 2016/07/04 ...
2 years, 6 months ago (2016-07-04 11:01:19 UTC) #32
prayashm
2 years, 6 months ago (2016-07-04 12:32:17 UTC) #33
prayashm
https://tryton-rietveld.appspot.com/27421002/diff/60001/src/sao.less File src/sao.less (right): https://tryton-rietveld.appspot.com/27421002/diff/60001/src/sao.less#newcode302 src/sao.less:302: .csv_dialog li { Done.
2 years, 6 months ago (2016-07-04 12:32:52 UTC) #34
reviewbot
flake8 OK URL: https://codereview.tryton.org/27421002
2 years, 6 months ago (2016-07-04 13:00:36 UTC) #35
ced
https://tryton-rietveld.appspot.com/27421002/diff/60001/src/window.js File src/window.js (right): https://tryton-rietveld.appspot.com/27421002/diff/60001/src/window.js#newcode977 src/window.js:977: if (parent_node === undefined) parent_node = this.fields_all; On 2016/07/04 ...
2 years, 6 months ago (2016-07-04 13:04:04 UTC) #36
prayashm
2 years, 6 months ago (2016-07-04 15:05:46 UTC) #37
prayashm
2 years, 6 months ago (2016-07-04 15:21:20 UTC) #38
prayashm
https://tryton-rietveld.appspot.com/27421002/diff/60001/src/window.js File src/window.js (right): https://tryton-rietveld.appspot.com/27421002/diff/60001/src/window.js#newcode977 src/window.js:977: if (parent_node === undefined) parent_node = this.fields_all; On 2016/07/04 ...
2 years, 6 months ago (2016-07-04 15:23:01 UTC) #39
reviewbot
flake8 OK URL: https://codereview.tryton.org/27421002
2 years, 6 months ago (2016-07-04 15:30:29 UTC) #40
prayashm
2 years, 6 months ago (2016-07-11 14:30:39 UTC) #41
reviewbot
flake8 OK URL: https://codereview.tryton.org/27421002
2 years, 6 months ago (2016-07-11 15:00:38 UTC) #42
ced
https://tryton-rietveld.appspot.com/27421002/diff/150001/src/tab.js File src/tab.js (right): https://tryton-rietveld.appspot.com/27421002/diff/150001/src/tab.js#newcode809 src/tab.js:809: // for name in self.screen.current_view.get_fields(): It is good to ...
2 years, 6 months ago (2016-07-19 06:10:53 UTC) #43
prayashm
2 years, 6 months ago (2016-07-19 11:35:03 UTC) #44
prayashm
https://tryton-rietveld.appspot.com/27421002/diff/150001/src/tab.js File src/tab.js (right): https://tryton-rietveld.appspot.com/27421002/diff/150001/src/tab.js#newcode809 src/tab.js:809: // for name in self.screen.current_view.get_fields(): On 2016/07/19 06:10:53, ced ...
2 years, 6 months ago (2016-07-19 11:42:01 UTC) #45
reviewbot
flake8 OK URL: https://codereview.tryton.org/27421002
2 years, 6 months ago (2016-07-19 12:00:36 UTC) #46
ced
https://tryton-rietveld.appspot.com/27421002/diff/150001/src/window.js File src/window.js (right): https://tryton-rietveld.appspot.com/27421002/diff/150001/src/window.js#newcode767 src/window.js:767: this.dialog = new Sao.Dialog('', 'csv', 'lg'); On 2016/07/19 11:42:01, ...
2 years, 6 months ago (2016-07-19 15:35:27 UTC) #47
prayashm
2 years, 6 months ago (2016-07-21 21:49:41 UTC) #48
prayashm
https://tryton-rietveld.appspot.com/27421002/diff/150001/src/window.js File src/window.js (right): https://tryton-rietveld.appspot.com/27421002/diff/150001/src/window.js#newcode767 src/window.js:767: this.dialog = new Sao.Dialog('', 'csv', 'lg'); On 2016/07/19 15:35:27, ...
2 years, 6 months ago (2016-07-21 21:50:11 UTC) #49
reviewbot
flake8 OK URL: https://codereview.tryton.org/27421002
2 years, 6 months ago (2016-07-21 22:01:04 UTC) #50
prayashm
2 years, 6 months ago (2016-07-26 09:45:02 UTC) #51
reviewbot
flake8 OK URL: https://codereview.tryton.org/27421002
2 years, 6 months ago (2016-07-26 10:00:34 UTC) #52
prayashm
2 years, 5 months ago (2016-07-28 13:27:31 UTC) #53
reviewbot
flake8 OK URL: https://codereview.tryton.org/27421002
2 years, 5 months ago (2016-07-28 13:30:26 UTC) #54
pokoli
https://tryton-rietveld.appspot.com/27421002/diff/230001/src/window.js File src/window.js (right): https://tryton-rietveld.appspot.com/27421002/diff/230001/src/window.js#newcode838 src/window.js:838: }.bind(this)).append(Sao.i18n.gettext(' Add')) Can we avoid this space? https://tryton-rietveld.appspot.com/27421002/diff/230001/src/window.js#newcode849 src/window.js:849: ...
2 years, 5 months ago (2016-08-11 08:57:36 UTC) #55
prayashm
2 years, 5 months ago (2016-08-11 09:34:21 UTC) #56
prayashm
https://tryton-rietveld.appspot.com/27421002/diff/230001/src/window.js File src/window.js (right): https://tryton-rietveld.appspot.com/27421002/diff/230001/src/window.js#newcode838 src/window.js:838: }.bind(this)).append(Sao.i18n.gettext(' Add')) On 2016/08/11 08:57:35, pokoli wrote: > Can ...
2 years, 5 months ago (2016-08-11 09:34:43 UTC) #57
reviewbot
flake8 OK URL: https://codereview.tryton.org/27421002
2 years, 5 months ago (2016-08-11 10:00:36 UTC) #58
ced
https://tryton-rietveld.appspot.com/27421002/diff/230001/src/window.js File src/window.js (right): https://tryton-rietveld.appspot.com/27421002/diff/230001/src/window.js#newcode838 src/window.js:838: }.bind(this)).append(Sao.i18n.gettext(' Add')) On 2016/08/11 09:34:43, prayashm wrote: > On ...
2 years, 5 months ago (2016-08-11 10:03:11 UTC) #59
prayashm
2 years, 5 months ago (2016-08-11 10:32:06 UTC) #60
prayashm
https://tryton-rietveld.appspot.com/27421002/diff/230001/src/window.js File src/window.js (right): https://tryton-rietveld.appspot.com/27421002/diff/230001/src/window.js#newcode838 src/window.js:838: }.bind(this)).append(Sao.i18n.gettext(' Add')) On 2016/08/11 10:03:10, ced wrote: > On ...
2 years, 5 months ago (2016-08-11 10:33:26 UTC) #61
reviewbot
flake8 OK URL: https://codereview.tryton.org/27421002
2 years, 5 months ago (2016-08-11 11:00:43 UTC) #62
ced
https://tryton-rietveld.appspot.com/27421002/diff/270001/src/sao.less File src/sao.less (right): https://tryton-rietveld.appspot.com/27421002/diff/270001/src/sao.less#newcode219 src/sao.less:219: This is a better to place to add csv ...
2 years, 5 months ago (2016-08-18 07:05:06 UTC) #63
prayashm
2 years, 5 months ago (2016-08-19 09:32:40 UTC) #64
prayashm
https://tryton-rietveld.appspot.com/27421002/diff/270001/src/sao.less File src/sao.less (right): https://tryton-rietveld.appspot.com/27421002/diff/270001/src/sao.less#newcode219 src/sao.less:219: On 2016/08/18 07:05:06, ced wrote: > This is a ...
2 years, 5 months ago (2016-08-19 09:33:19 UTC) #65
reviewbot
flake8 OK URL: https://codereview.tryton.org/27421002
2 years, 5 months ago (2016-08-19 09:48:27 UTC) #66
ced
https://tryton-rietveld.appspot.com/27421002/diff/270001/src/sao.less File src/sao.less (right): https://tryton-rietveld.appspot.com/27421002/diff/270001/src/sao.less#newcode303 src/sao.less:303: padding-left: 5px; On 2016/08/19 09:33:18, prayashm wrote: > On ...
2 years, 5 months ago (2016-08-19 10:12:37 UTC) #67
prayashm
https://tryton-rietveld.appspot.com/27421002/diff/270001/src/sao.less File src/sao.less (right): https://tryton-rietveld.appspot.com/27421002/diff/270001/src/sao.less#newcode303 src/sao.less:303: padding-left: 5px; On 2016/08/19 10:12:37, ced wrote: > I ...
2 years, 5 months ago (2016-08-22 07:07:48 UTC) #68
ced
https://tryton-rietveld.appspot.com/27421002/diff/270001/src/sao.less File src/sao.less (right): https://tryton-rietveld.appspot.com/27421002/diff/270001/src/sao.less#newcode303 src/sao.less:303: padding-left: 5px; On 2016/08/22 07:07:48, prayashm wrote: > On ...
2 years, 5 months ago (2016-08-22 07:42:03 UTC) #69
prayashm
2 years, 5 months ago (2016-08-23 08:30:33 UTC) #70
prayashm
https://tryton-rietveld.appspot.com/27421002/diff/270001/src/sao.less File src/sao.less (right): https://tryton-rietveld.appspot.com/27421002/diff/270001/src/sao.less#newcode303 src/sao.less:303: padding-left: 5px; On 2016/08/22 07:42:03, ced wrote: > On ...
2 years, 5 months ago (2016-08-23 08:31:05 UTC) #71
prayashm
2 years, 5 months ago (2016-08-23 08:36:51 UTC) #72
reviewbot
flake8 OK URL: https://codereview.tryton.org/27421002
2 years, 5 months ago (2016-08-23 08:45:01 UTC) #73
prayashm
2 years, 5 months ago (2016-08-23 08:49:38 UTC) #74
prayashm
2 years, 5 months ago (2016-08-23 08:55:46 UTC) #75
reviewbot
flake8 OK URL: https://codereview.tryton.org/27421002
2 years, 5 months ago (2016-08-23 09:26:14 UTC) #76
ced
Also the unexpanded feature does not work the first time you click on auto-detect. https://tryton-rietveld.appspot.com/27421002/diff/270001/src/window.js ...
2 years, 5 months ago (2016-08-23 16:24:00 UTC) #77
prayashm
2 years, 5 months ago (2016-08-23 18:02:07 UTC) #78
prayashm
On 2016/08/23 16:24:00, ced wrote: > Also the unexpanded feature does not work the first ...
2 years, 5 months ago (2016-08-23 18:19:18 UTC) #79
reviewbot
flake8 OK URL: https://codereview.tryton.org/27421002
2 years, 5 months ago (2016-08-23 18:23:07 UTC) #80
prayashm
https://tryton-rietveld.appspot.com/27421002/diff/330001/src/window.js File src/window.js (right): https://tryton-rietveld.appspot.com/27421002/diff/330001/src/window.js#newcode1437 src/window.js:1437: }.bind(this)); On 2016/08/23 16:23:59, ced wrote: > trailing space ...
2 years, 5 months ago (2016-08-23 18:24:09 UTC) #81
prayashm
2 years, 5 months ago (2016-08-23 18:39:21 UTC) #82
reviewbot
flake8 OK URL: https://codereview.tryton.org/27421002
2 years, 5 months ago (2016-08-23 18:45:15 UTC) #83
ced
https://tryton-rietveld.appspot.com/27421002/diff/330001/src/window.js File src/window.js (right): https://tryton-rietveld.appspot.com/27421002/diff/330001/src/window.js#newcode1607 src/window.js:1607: this.unexpand_field = this.unexpand_field || On 2016/08/23 18:24:09, prayashm wrote: ...
2 years, 5 months ago (2016-08-24 09:02:35 UTC) #84
ced
https://tryton-rietveld.appspot.com/27421002/diff/400001/src/window.js File src/window.js (right): https://tryton-rietveld.appspot.com/27421002/diff/400001/src/window.js#newcode1496 src/window.js:1496: this.sel_predef(jQuery(event.target).attr('export_id')); event is not defined. https://tryton-rietveld.appspot.com/27421002/diff/400001/src/window.js#newcode1520 src/window.js:1520: }.bind(this)); trailing ...
2 years, 4 months ago (2016-09-19 09:48:29 UTC) #85
prayashm
2 years, 3 months ago (2016-10-16 23:08:54 UTC) #86
prayashm
https://tryton-rietveld.appspot.com/27421002/diff/330001/src/window.js File src/window.js (right): https://tryton-rietveld.appspot.com/27421002/diff/330001/src/window.js#newcode1607 src/window.js:1607: this.unexpand_field = this.unexpand_field || Done. https://tryton-rietveld.appspot.com/27421002/diff/400001/src/window.js File src/window.js (right): ...
2 years, 3 months ago (2016-10-16 23:18:38 UTC) #87
reviewbot
flake8 OK URL: https://codereview.tryton.org/27421002
2 years, 3 months ago (2016-10-16 23:33:46 UTC) #88
pokoli
https://tryton-rietveld.appspot.com/27421002/diff/410001/src/window.js File src/window.js (right): https://tryton-rietveld.appspot.com/27421002/diff/410001/src/window.js#newcode1010 src/window.js:1010: this.fields_data = {}; // Ask before Removing this. On ...
2 years, 3 months ago (2016-10-20 09:01:34 UTC) #89
prayashm
https://tryton-rietveld.appspot.com/27421002/diff/410001/src/window.js File src/window.js (right): https://tryton-rietveld.appspot.com/27421002/diff/410001/src/window.js#newcode1010 src/window.js:1010: this.fields_data = {}; // Ask before Removing this. On ...
2 years, 3 months ago (2016-10-20 09:25:52 UTC) #90
prayashm
2 years, 3 months ago (2016-10-20 09:54:04 UTC) #91
prayashm
https://tryton-rietveld.appspot.com/27421002/diff/410001/src/window.js File src/window.js (right): https://tryton-rietveld.appspot.com/27421002/diff/410001/src/window.js#newcode1533 src/window.js:1533: this.sel_predef(jQuery(event.target).attr('export_id')); > Works when using unminified js. Fixing this. ...
2 years, 3 months ago (2016-10-20 09:55:33 UTC) #92
reviewbot
flake8 OK URL: https://codereview.tryton.org/27421002
2 years, 3 months ago (2016-10-20 10:03:28 UTC) #93
pokoli
https://tryton-rietveld-hrd.appspot.com/27421002/diff/430001/index.html File index.html (right): https://tryton-rietveld-hrd.appspot.com/27421002/diff/430001/index.html#newcode20 index.html:20: <script type="text/javascript" src="bower_components/papaparse/papaparse.js"></script> I think we should use the ...
2 years, 3 months ago (2016-10-20 13:11:05 UTC) #94
prayashm
2 years, 3 months ago (2016-10-20 13:13:47 UTC) #95
prayashm
https://tryton-rietveld-hrd.appspot.com/27421002/diff/430001/index.html File index.html (right): https://tryton-rietveld-hrd.appspot.com/27421002/diff/430001/index.html#newcode20 index.html:20: <script type="text/javascript" src="bower_components/papaparse/papaparse.js"></script> On 2016/10/20 13:11:05, pokoli wrote: > ...
2 years, 3 months ago (2016-10-20 13:14:41 UTC) #96
reviewbot
flake8 OK URL: https://codereview.tryton.org/27421002
2 years, 3 months ago (2016-10-20 13:22:30 UTC) #97
pokoli
Tested and LGTM
2 years, 3 months ago (2016-10-20 16:15:01 UTC) #98
ced
I did not comment all style issues, please fix all similar. https://tryton-rietveld.appspot.com/27421002/diff/450001/src/window.js File src/window.js (right): ...
2 years, 3 months ago (2016-10-22 18:50:47 UTC) #99
prayashm
2 years, 3 months ago (2016-10-23 19:16:39 UTC) #100
prayashm
https://tryton-rietveld.appspot.com/27421002/diff/450001/src/window.js File src/window.js (right): https://tryton-rietveld.appspot.com/27421002/diff/450001/src/window.js#newcode1059 src/window.js:1059: 'class' : 'form-group' On 2016/10/22 18:50:46, ced wrote: > ...
2 years, 3 months ago (2016-10-23 19:17:59 UTC) #101
reviewbot
flake8 OK URL: https://codereview.tryton.org/27421002
2 years, 3 months ago (2016-10-23 19:27:52 UTC) #102
ced
https://tryton-rietveld.appspot.com/27421002/diff/450001/src/window.js File src/window.js (right): https://tryton-rietveld.appspot.com/27421002/diff/450001/src/window.js#newcode1175 src/window.js:1175: this.fields_selected.empty(); On 2016/10/23 19:17:59, prayashm wrote: > On 2016/10/22 ...
2 years, 3 months ago (2016-10-23 20:19:08 UTC) #103
ced
Once this.fields_selected is removed, we could include it.
2 years, 3 months ago (2016-10-24 16:56:54 UTC) #104
prayashm
On 2016/10/24 16:56:54, ced wrote: > Once this.fields_selected is removed, we could include it. Working ...
2 years, 3 months ago (2016-10-24 17:03:02 UTC) #105
ced
On 2016/10/24 17:03:02, prayashm wrote: > On 2016/10/24 16:56:54, ced wrote: > > Once this.fields_selected ...
2 years, 3 months ago (2016-10-24 17:20:25 UTC) #106
prayashm
2 years, 2 months ago (2016-10-30 12:44:12 UTC) #107
prayashm
https://tryton-rietveld.appspot.com/27421002/diff/450001/src/window.js File src/window.js (right): https://tryton-rietveld.appspot.com/27421002/diff/450001/src/window.js#newcode1175 src/window.js:1175: this.fields_selected.empty(); Removed it, and passed as a parameter now. ...
2 years, 2 months ago (2016-10-30 12:47:31 UTC) #108
reviewbot
flake8 OK URL: https://codereview.tryton.org/27421002
2 years, 2 months ago (2016-10-30 12:54:59 UTC) #109
ced
https://tryton-rietveld.appspot.com/27421002/diff/450001/src/window.js File src/window.js (right): https://tryton-rietveld.appspot.com/27421002/diff/450001/src/window.js#newcode1175 src/window.js:1175: this.fields_selected.empty(); On 2016/10/30 12:47:30, prayashm wrote: > Removed it, ...
2 years, 2 months ago (2016-10-30 17:24:09 UTC) #110
prayashm
2 years, 2 months ago (2016-10-30 17:28:50 UTC) #111
prayashm
https://tryton-rietveld.appspot.com/27421002/diff/450001/src/window.js File src/window.js (right): https://tryton-rietveld.appspot.com/27421002/diff/450001/src/window.js#newcode1175 src/window.js:1175: this.fields_selected.empty(); On 2016/10/30 17:24:09, ced wrote: > On 2016/10/30 ...
2 years, 2 months ago (2016-10-30 17:28:58 UTC) #112
reviewbot
flake8 OK URL: https://codereview.tryton.org/27421002
2 years, 2 months ago (2016-10-30 17:28:59 UTC) #113
ced
Could you just add a changelog entry.
2 years, 2 months ago (2016-10-30 17:49:00 UTC) #114
prayashm
2 years, 2 months ago (2016-10-30 19:09:33 UTC) #115
reviewbot
flake8 OK URL: https://codereview.tryton.org/27421002
2 years, 2 months ago (2016-10-30 19:34:23 UTC) #116
ced
LGTM
2 years, 2 months ago (2016-10-30 19:35:20 UTC) #117
rietveld-bot_tryton.org
2 years, 2 months ago (2016-10-31 09:10:25 UTC) #118
New changeset dd4d140db096 by Prayash Mohapatra in branch 'default':
Add CSV Import/Export
http://hg.tryton.org/sao/rev/dd4d140db096
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766