Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(71)

Issue 275351002: web_user: Avoid passing None values to urllib.parse.urlsplit

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks, 2 days ago by pokoli
Modified:
6 days, 1 hour ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add comment #

Patch Set 3 : Add default value for URL #

Patch Set 4 : Add missing default keyword #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M user.py View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9
pokoli
3 weeks, 2 days ago (2019-04-30 09:40:48 UTC) #1
reviewbot
https://codereview.tryton.org/275351002/diff/283311002/user.py#newcode97 user.py:97: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
3 weeks, 2 days ago (2019-04-30 10:07:37 UTC) #2
ced
https://codereview.tryton.org/275351002/diff/283311002/user.py File user.py (right): https://codereview.tryton.org/275351002/diff/283311002/user.py#newcode56 user.py:56: url = '' Could you put a comment explaining ...
3 weeks, 2 days ago (2019-04-30 14:59:48 UTC) #3
pokoli
Add comment
3 weeks, 1 day ago (2019-05-01 19:54:14 UTC) #4
reviewbot
https://codereview.tryton.org/275351002/diff/285211002/user.py#newcode98 user.py:98: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
3 weeks, 1 day ago (2019-05-01 20:12:53 UTC) #5
ced
I think it is better to ensure to have an URL as said in https://bugs.tryton.org/msg49263
3 weeks ago (2019-05-02 10:41:55 UTC) #6
pokoli
Add default value for URL
6 days, 1 hour ago (2019-05-17 19:23:00 UTC) #7
pokoli
Add missing default keyword
6 days, 1 hour ago (2019-05-17 19:27:40 UTC) #8
reviewbot
6 days, 1 hour ago (2019-05-17 19:35:52 UTC) #9
https://codereview.tryton.org/275351002/diff/271421003/user.py#newcode95
user.py:95:
E712 comparison to True should be 'if cond is True:' or 'if cond:'

URL: https://codereview.tryton.org/275351002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766