Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2141)

Issue 28001002: purchase: Cancel draft moves and invoices when canceling processed order (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 3 months ago by xcodinas
Modified:
1 year, 8 months ago
Reviewers:
pokoli, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Don't cancel paid invoices, add ignored moves per line, fix tests #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -0 lines) Patch
M purchase.py View 1 2 chunks +42 lines, -0 lines 0 comments Download
M tests/scenario_purchase.rst View 1 1 chunk +75 lines, -0 lines 4 comments Download
M view/purchase_form.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6
xcodinas
2 years, 3 months ago (2017-02-14 12:38:49 UTC) #1
pokoli
Mostly the same remarks as on sale must be applied here https://tryton-rietveld-hrd.appspot.com/28001002/diff/1/purchase.py File purchase.py (right): ...
2 years, 3 months ago (2017-02-14 13:02:19 UTC) #2
reviewbot
https://codereview.tryton.org/28001002/diff/1/purchase.py#newcode795 purchase.py:795: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/28001002
2 years, 3 months ago (2017-02-14 13:04:17 UTC) #3
xcodinas
Don't cancel paid invoices, add ignored moves per line, fix tests
2 years, 3 months ago (2017-02-16 10:09:52 UTC) #4
pokoli
Missing CHANGELOG entry https://tryton-rietveld.appspot.com/28001002/diff/20001/tests/scenario_purchase.rst File tests/scenario_purchase.rst (right): https://tryton-rietveld.appspot.com/28001002/diff/20001/tests/scenario_purchase.rst#newcode600 tests/scenario_purchase.rst:600: Cancel processed products:: This title does ...
2 years, 3 months ago (2017-02-16 10:33:28 UTC) #5
reviewbot
2 years, 3 months ago (2017-02-16 10:36:39 UTC) #6
https://codereview.tryton.org/28001002/diff/20001/purchase.py#newcode797
purchase.py:797:
E127 continuation line over-indented for visual indent

URL: https://codereview.tryton.org/28001002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766