Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(180)

Issue 28181002: product_attribute: Add help text

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 months ago by pokoli
Modified:
46 minutes ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix ced's comments and use the instead of this #

Total comments: 1

Patch Set 3 : Avoid template term on user #

Total comments: 2

Patch Set 4 : Use ced suggestions #

Total comments: 1

Patch Set 5 : Fix ced comment #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M product.py View 1 2 3 4 4 chunks +10 lines, -5 lines 2 comments Download

Messages

Total messages: 15
pokoli
11 months ago (2017-03-27 11:04:15 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/28181002
11 months ago (2017-03-27 11:33:30 UTC) #2
ced
https://codereview.tryton.org/28181002/diff/1/product.py File product.py (right): https://codereview.tryton.org/28181002/diff/1/product.py#newcode45 product.py:45: help="The set of attributes availabe on template variants.") It ...
4 months, 3 weeks ago (2017-10-02 22:20:39 UTC) #3
pokoli
Fix ced's comments and use the instead of this
4 months, 3 weeks ago (2017-10-04 07:37:54 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/28181002
4 months, 3 weeks ago (2017-10-04 08:08:30 UTC) #5
ced
https://codereview.tryton.org/28181002/diff/20001/product.py File product.py (right): https://codereview.tryton.org/28181002/diff/20001/product.py#newcode45 product.py:45: help="The set of attributes available on the template.") I ...
3 months, 2 weeks ago (2017-11-13 10:29:23 UTC) #6
pokoli
Avoid template term on user
3 months, 2 weeks ago (2017-11-13 11:34:36 UTC) #7
reviewbot
flake8 OK URL: https://codereview.tryton.org/28181002
3 months, 2 weeks ago (2017-11-13 11:58:37 UTC) #8
ced
https://codereview.tryton.org/28181002/diff/40001/product.py File product.py (right): https://codereview.tryton.org/28181002/diff/40001/product.py#newcode28 product.py:28: help="Add sets to the attribute.") For me, it should ...
2 months, 1 week ago (2017-12-19 22:50:49 UTC) #9
pokoli
Use ced suggestions
2 months, 1 week ago (2017-12-20 16:54:18 UTC) #10
reviewbot
flake8 OK URL: https://codereview.tryton.org/28181002
2 months, 1 week ago (2017-12-20 17:16:58 UTC) #11
ced
https://codereview.tryton.org/28181002/diff/60001/product.py File product.py (right): https://codereview.tryton.org/28181002/diff/60001/product.py#newcode28 product.py:28: help="Add attribute to a set.") It should be: "Add ...
1 week, 5 days ago (2018-02-13 18:18:15 UTC) #12
pokoli
Fix ced comment
1 week, 4 days ago (2018-02-14 09:50:36 UTC) #13
reviewbot
flake8 OK URL: https://codereview.tryton.org/28181002
1 week, 4 days ago (2018-02-14 10:14:43 UTC) #14
ced
46 minutes ago (2018-02-25 22:28:42 UTC) #15
https://codereview.tryton.org/28181002/diff/80001/product.py
File product.py (right):

https://codereview.tryton.org/28181002/diff/80001/product.py#newcode19
product.py:19: help="Add sets to the attribute.")
It should be: "Add attributes to the set"

https://codereview.tryton.org/28181002/diff/80001/product.py#newcode28
product.py:28: help="Add attribute to a set.")
It should be: "Add set to the attribute"
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922