Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(380)

Issue 28181002: product_attribute: Add help text (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 1 month ago by pokoli
Modified:
1 month, 4 weeks ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix ced's comments and use the instead of this #

Total comments: 1

Patch Set 3 : Avoid template term on user #

Total comments: 2

Patch Set 4 : Use ced suggestions #

Total comments: 1

Patch Set 5 : Fix ced comment #

Total comments: 2

Patch Set 6 : Fix order of wording #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M product.py View 1 2 3 4 5 4 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 19
pokoli
1 year, 1 month ago (2017-03-27 11:04:15 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/28181002
1 year, 1 month ago (2017-03-27 11:33:30 UTC) #2
ced
https://codereview.tryton.org/28181002/diff/1/product.py File product.py (right): https://codereview.tryton.org/28181002/diff/1/product.py#newcode45 product.py:45: help="The set of attributes availabe on template variants.") It ...
7 months, 2 weeks ago (2017-10-02 22:20:39 UTC) #3
pokoli
Fix ced's comments and use the instead of this
7 months, 2 weeks ago (2017-10-04 07:37:54 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/28181002
7 months, 2 weeks ago (2017-10-04 08:08:30 UTC) #5
ced
https://codereview.tryton.org/28181002/diff/20001/product.py File product.py (right): https://codereview.tryton.org/28181002/diff/20001/product.py#newcode45 product.py:45: help="The set of attributes available on the template.") I ...
6 months, 1 week ago (2017-11-13 10:29:23 UTC) #6
pokoli
Avoid template term on user
6 months, 1 week ago (2017-11-13 11:34:36 UTC) #7
reviewbot
flake8 OK URL: https://codereview.tryton.org/28181002
6 months, 1 week ago (2017-11-13 11:58:37 UTC) #8
ced
https://codereview.tryton.org/28181002/diff/40001/product.py File product.py (right): https://codereview.tryton.org/28181002/diff/40001/product.py#newcode28 product.py:28: help="Add sets to the attribute.") For me, it should ...
5 months ago (2017-12-19 22:50:49 UTC) #9
pokoli
Use ced suggestions
5 months ago (2017-12-20 16:54:18 UTC) #10
reviewbot
flake8 OK URL: https://codereview.tryton.org/28181002
5 months ago (2017-12-20 17:16:58 UTC) #11
ced
https://codereview.tryton.org/28181002/diff/60001/product.py File product.py (right): https://codereview.tryton.org/28181002/diff/60001/product.py#newcode28 product.py:28: help="Add attribute to a set.") It should be: "Add ...
3 months ago (2018-02-13 18:18:15 UTC) #12
pokoli
Fix ced comment
3 months ago (2018-02-14 09:50:36 UTC) #13
reviewbot
flake8 OK URL: https://codereview.tryton.org/28181002
3 months ago (2018-02-14 10:14:43 UTC) #14
ced
https://codereview.tryton.org/28181002/diff/80001/product.py File product.py (right): https://codereview.tryton.org/28181002/diff/80001/product.py#newcode19 product.py:19: help="Add sets to the attribute.") It should be: "Add ...
2 months, 3 weeks ago (2018-02-25 22:28:42 UTC) #15
pokoli
Fix order of wording
2 months ago (2018-03-19 09:40:17 UTC) #16
reviewbot
flake8 OK URL: https://codereview.tryton.org/28181002
2 months ago (2018-03-19 09:47:04 UTC) #17
ced
LGTM
2 months ago (2018-03-21 12:35:51 UTC) #18
rietveld-bot_tryton.org
1 month, 4 weeks ago (2018-03-22 10:08:53 UTC) #19
New changeset c3ca9eb68dbc by Sergi Almacellas Abellana in branch 'default':
Add help text
http://hg.tryton.org/modules/product_attribute/rev/c3ca9eb68dbc
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922