Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2103)

Issue 283141002: party: Add ar_dni as identifier

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 3 weeks ago by lukio
Modified:
3 days ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove python-stdnum minimal version #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M party.py View 2 chunks +2 lines, -1 line 1 comment Download

Messages

Total messages: 8
lukio
1 month, 3 weeks ago (2019-04-01 13:09:36 UTC) #1
reviewbot
https://codereview.tryton.org/283141002/diff/269241002/setup.py#newcode86 setup.py:86: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/283141002
1 month, 3 weeks ago (2019-04-01 13:20:26 UTC) #2
ced
https://codereview.tryton.org/283141002/diff/269241002/setup.py File setup.py (right): https://codereview.tryton.org/283141002/diff/269241002/setup.py#newcode48 setup.py:48: requires = ['python-sql >= 0.4', 'python-stdnum >= 1.11'] I ...
4 weeks ago (2019-04-25 14:03:04 UTC) #3
lukio
Remove python-stdnum minimal version
2 weeks, 2 days ago (2019-05-07 07:08:51 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/283141002
2 weeks, 2 days ago (2019-05-07 07:31:26 UTC) #5
ced
https://codereview.tryton.org/283141002/diff/253471002/party.py File party.py (right): https://codereview.tryton.org/283141002/diff/253471002/party.py#newcode139 party.py:139: 'us_tin', 'ar_dni'] Are you sure it is used as ...
3 days, 9 hours ago (2019-05-20 11:05:22 UTC) #6
lukio
On 2019/05/20 11:05:22, ced wrote: > https://codereview.tryton.org/283141002/diff/253471002/party.py > File party.py (right): > > https://codereview.tryton.org/283141002/diff/253471002/party.py#newcode139 > ...
3 days, 3 hours ago (2019-05-20 17:18:31 UTC) #7
ced
3 days ago (2019-05-20 20:28:44 UTC) #8
On 2019/05/20 17:18:31, lukio wrote:
> On 2019/05/20 11:05:22, ced wrote:
> > https://codereview.tryton.org/283141002/diff/253471002/party.py
> > File party.py (right):
> > 
> > https://codereview.tryton.org/283141002/diff/253471002/party.py#newcode139
> > party.py:139: 'us_tin', 'ar_dni']
> > Are you sure it is used as tax identifier? ar_cuit seems to be the only
right
> > one for Argentina.
> 
> Hi cedk!
> 
> When you purchase something at Argentina, you can give your CUIT (if you have
> it) or DNI so they can identify you. There are another identifiers like
> LE/LC/Passport/CUIT/CDI. The common are CUIT or DNI.
> 
> There are information regarding invoice at Argentina here:
> http://www.afip.gob.ar/facturacion/
> https://www.afip.gob.ar/fe/ayuda.asp
> 
> Those are another kind of identifiers when you purchase like:
>
http://www.afip.gob.ar/fe/documentos/TABLA%20DOC_ID%20COMPRADOR%20V.0%20%2025...
> 
> Copied and translated from http://www.afip.gob.ar/facturacion
> 
> When the recipient is a final consumer, the following data should be detailed,
> provided that the amount of the transaction is equal to or greater than $
10,000
> 
> * Surname and Names.
> * Home.
> * CUIT / CUIL / CDI, where applicable, identity document number (LE, LC, DNI
or,
> in the case of foreigners, Passport or CI).
> 
> Hope it helps!

I do not think it is right to define it as tax identifier.
I know Argentina is weird on many aspects about business but for me the example
is not about tax identifier.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766