Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2113)

Issue 283331002: sale: Preserve original delivery date on backorders from future shipping

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks ago by mrichez
Modified:
3 days, 9 hours ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 7

Patch Set 2 : Apply last remarks #

Total comments: 3

Patch Set 3 : Apply Ced's remark #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M sale.py View 1 2 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 15
mrichez
3 weeks ago (2019-05-02 09:44:09 UTC) #1
reviewbot
patch is not applicable URL: https://codereview.tryton.org/283331002
3 weeks ago (2019-05-02 10:12:10 UTC) #2
ced
https://codereview.tryton.org/283331002/diff/261421002/sale.py File sale.py (right): https://codereview.tryton.org/283331002/diff/261421002/sale.py#newcode1439 sale.py:1439: planned_date = min(dates, default=None) Why not use shipping_date?
3 weeks ago (2019-05-02 10:41:08 UTC) #3
mrichez
https://codereview.tryton.org/283331002/diff/261421002/sale.py File sale.py (right): https://codereview.tryton.org/283331002/diff/261421002/sale.py#newcode1439 sale.py:1439: planned_date = min(dates, default=None) On 2019/05/02 10:41:08, ced wrote: ...
3 weeks ago (2019-05-02 10:58:45 UTC) #4
ced
https://codereview.tryton.org/283331002/diff/261421002/sale.py File sale.py (right): https://codereview.tryton.org/283331002/diff/261421002/sale.py#newcode1439 sale.py:1439: planned_date = min(dates, default=None) On 2019/05/02 10:58:44, mrichez wrote: ...
3 weeks ago (2019-05-02 11:04:09 UTC) #5
mrichez
https://codereview.tryton.org/283331002/diff/261421002/sale.py File sale.py (right): https://codereview.tryton.org/283331002/diff/261421002/sale.py#newcode1439 sale.py:1439: planned_date = min(dates, default=None) On 2019/05/02 11:04:09, ced wrote: ...
3 weeks ago (2019-05-02 11:22:01 UTC) #6
ced
https://codereview.tryton.org/283331002/diff/261421002/sale.py File sale.py (right): https://codereview.tryton.org/283331002/diff/261421002/sale.py#newcode1439 sale.py:1439: planned_date = min(dates, default=None) On 2019/05/02 11:22:01, mrichez wrote: ...
3 weeks ago (2019-05-02 12:08:56 UTC) #7
mrichez
https://codereview.tryton.org/283331002/diff/261421002/sale.py File sale.py (right): https://codereview.tryton.org/283331002/diff/261421002/sale.py#newcode1439 sale.py:1439: planned_date = min(dates, default=None) On 2019/05/02 12:08:56, ced wrote: ...
3 weeks ago (2019-05-02 12:52:57 UTC) #8
ced
https://codereview.tryton.org/283331002/diff/261421002/sale.py File sale.py (right): https://codereview.tryton.org/283331002/diff/261421002/sale.py#newcode1439 sale.py:1439: planned_date = min(dates, default=None) On 2019/05/02 12:52:57, mrichez wrote: ...
3 weeks ago (2019-05-02 13:37:44 UTC) #9
mrichez
3 weeks ago (2019-05-02 13:51:26 UTC) #10
reviewbot
flake8 OK URL: https://codereview.tryton.org/283331002
3 weeks ago (2019-05-02 14:06:36 UTC) #11
ced
https://codereview.tryton.org/283331002/diff/255401002/sale.py File sale.py (left): https://codereview.tryton.org/283331002/diff/255401002/sale.py#oldcode1435 sale.py:1435: # backorder can not be planned I would keep ...
3 weeks ago (2019-05-02 14:20:28 UTC) #12
mrichez
2 weeks, 6 days ago (2019-05-03 06:59:28 UTC) #13
reviewbot
flake8 OK URL: https://codereview.tryton.org/283331002
2 weeks, 6 days ago (2019-05-03 07:12:26 UTC) #14
ced
3 days, 9 hours ago (2019-05-20 10:58:24 UTC) #15
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766