account_statement_import: New module

issue5882

[reviewbot, 2016-09-14 15:02:49]

https://codereview.tryton.org/28811002/diff/1/tests/__init__.py#newcode5
tests/__init__.py:5:
E501 line too long (98 > 79 characters)

URL: https://codereview.tryton.org/28811002

[ced, 2016-10-04 21:20:20]

https://tryton-rietveld.appspot.com/28811002/diff/1/statement.py
File statement.py (right):

https://tryton-rietveld.appspot.com/28811002/diff/1/statement.py#newcode32
statement.py:32: fields.Selection(STATES, 'Statement State'),
You should use method to get selections from Statement

https://tryton-rietveld.appspot.com/28811002/diff/1/statement.py#newcode35
statement.py:35: date = fields.Date('Date', states=_states, depends=_depends)
For me date should be required.

https://tryton-rietveld.appspot.com/28811002/diff/1/statement.py#newcode38
statement.py:38: states=_states, depends=_depends)
Missing number field

https://tryton-rietveld.appspot.com/28811002/diff/1/statement.py#newcode46
statement.py:46: ('statement', '=', Eval('statement')),
The date should be the same

https://tryton-rietveld.appspot.com/28811002/diff/1/statement.py#newcode49
statement.py:49: state = fields.Selection(ORIGIN_STATES, 'State', readonly=True,
I do not think it needs to have a state.
The Statement state and pending amount are enough.

https://tryton-rietveld.appspot.com/28811002/diff/1/statement.py#newcode65
statement.py:65: cls._transitions |= set((
I do not see the point of a workflow if all transitions are allowed.

https://tryton-rietveld.appspot.com/28811002/diff/1/statement.py#newcode96
statement.py:96: lines_amount = sum(l.amount or Decimal(0) for l in self.lines)
l.amount could fail, you must use getattr with default value.
But maybe it is not needed to have a on_change_with.

https://tryton-rietveld.appspot.com/28811002/diff/1/statement.py#newcode100
statement.py:100: return self.name or self.statement.rec_name
I do not think that the name is rec_name. At best it should be number.
I do not think neither it should be statement rec_name.

https://tryton-rietveld.appspot.com/28811002/diff/1/statement.py#newcode134
statement.py:134: cls.create_move(origins)
I do not think it should be in standard module.
For me, it is not a good practice to post line in advance.

https://tryton-rietveld.appspot.com/28811002/diff/1/statement.py#newcode145
statement.py:145: return Statement.create_move(origins)
For me, it is wrong to create move base on origin. The real information should
always be the lines.

https://tryton-rietveld.appspot.com/28811002/diff/1/statement.py#newcode207
statement.py:207: fields.Selection(ORIGIN_STATES, 'Origin State'),
It is better to use a method that will return the selections of the origin.

https://tryton-rietveld.appspot.com/28811002/diff/1/statement.py#newcode282
statement.py:282: class ImportStatement(Wizard):
Why not run on top of an existing empty statement instead of asking all the
fields in a view.