Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6)

Issue 299621002: tryton-env: Add trigger templates

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years ago by pokoli
Modified:
6 months, 3 weeks ago
Reviewers:
ced, dave, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix dave's comments #

Patch Set 3 : Remove unrelated patch #

Total comments: 3

Patch Set 4 : Update to tip and fix comments #

Patch Set 5 : Remove uneeded condition used and empty line #

Total comments: 1

Patch Set 6 : Fix comment and add trigger templates for more modules #

Patch Set 7 : Update to tip #

Patch Set 8 : Update to tip #

Total comments: 20

Patch Set 9 : Update to tip and fix remarks #

Patch Set 10 : Update to tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+389 lines, -94 lines) Patch
A modules/account_invoice/trigger.xml View 1 2 3 4 5 6 7 8 1 chunk +31 lines, -0 lines 0 comments Download
M modules/account_invoice/tryton.cfg View 1 chunk +1 line, -0 lines 0 comments Download
A modules/account_payment/trigger.xml View 1 2 3 4 5 6 7 8 1 chunk +25 lines, -0 lines 0 comments Download
M modules/account_payment/tryton.cfg View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
A modules/purchase/trigger.xml View 1 2 3 4 5 1 chunk +19 lines, -0 lines 0 comments Download
M modules/purchase/tryton.cfg View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
A modules/sale/trigger.xml View 1 2 3 4 5 1 chunk +19 lines, -0 lines 0 comments Download
M modules/sale/tryton.cfg View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
A modules/sale_complaint/trigger.xml View 1 2 3 4 5 7 8 1 chunk +19 lines, -0 lines 0 comments Download
M modules/sale_complaint/tryton.cfg View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
A modules/stock/trigger.xml View 1 2 3 4 5 6 7 8 1 chunk +19 lines, -0 lines 0 comments Download
M modules/stock/tryton.cfg View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M trytond/CHANGELOG View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M trytond/trytond/ir/__init__.py View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M trytond/trytond/ir/message.xml View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
M trytond/trytond/ir/trigger.py View 1 2 3 4 5 6 7 8 9 5 chunks +119 lines, -57 lines 0 comments Download
M trytond/trytond/ir/trigger.xml View 1 2 3 4 5 6 7 8 1 chunk +31 lines, -2 lines 0 comments Download
M trytond/trytond/ir/view/trigger_form.xml View 1 2 3 4 5 6 7 8 1 chunk +14 lines, -26 lines 0 comments Download
M trytond/trytond/ir/view/trigger_list.xml View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -9 lines 0 comments Download
A trytond/trytond/ir/view/trigger_template_form.xml View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download
A trytond/trytond/ir/view/trigger_template_list.xml View 1 chunk +11 lines, -0 lines 0 comments Download
M trytond/trytond/tests/test_trigger.py View 1 2 3 4 5 6 7 8 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 22
pokoli
3 years ago (2020-05-09 17:46:06 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/299621002
3 years ago (2020-05-09 18:16:33 UTC) #2
dave
https://codereview.tryton.org/299621002/diff/293641002/trytond/trytond/ir/trigger.py File trytond/trytond/ir/trigger.py (right): https://codereview.tryton.org/299621002/diff/293641002/trytond/trytond/ir/trigger.py#newcode61 trytond/trytond/ir/trigger.py:61: '"On Time" and others are mutually exclusive!'), Should this ...
3 years ago (2020-05-11 11:03:25 UTC) #3
pokoli
Fix dave's comments
3 years ago (2020-05-12 11:14:02 UTC) #4
pokoli
Remove unrelated patch
3 years ago (2020-05-12 11:15:10 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/299621002
3 years ago (2020-05-12 11:38:10 UTC) #6
ced
https://codereview.tryton.org/299621002/diff/323281002/trytond/trytond/ir/trigger.py File trytond/trytond/ir/trigger.py (right): https://codereview.tryton.org/299621002/diff/323281002/trytond/trytond/ir/trigger.py#newcode30 trytond/trytond/ir/trigger.py:30: class TriggerMixin(DeactivableMixin, ModelSQL, ModelView): I do not think template ...
1 year, 10 months ago (2021-08-08 15:40:19 UTC) #7
pokoli
Update to tip and fix comments
1 year, 10 months ago (2021-08-09 07:52:04 UTC) #8
pokoli
Remove uneeded condition used and empty line
1 year, 10 months ago (2021-08-09 07:55:11 UTC) #9
reviewbot
flake8 OK URL: https://codereview.tryton.org/299621002
1 year, 10 months ago (2021-08-09 08:00:31 UTC) #10
dave
https://codereview.tryton.org/299621002/diff/336761002/trytond/trytond/ir/message.xml File trytond/trytond/ir/message.xml (right): https://codereview.tryton.org/299621002/diff/336761002/trytond/trytond/ir/message.xml#newcode376 trytond/trytond/ir/message.xml:376: <field name="text">You can not use "On Time" at the ...
1 year, 10 months ago (2021-08-09 21:27:01 UTC) #11
pokoli
Fix comment and add trigger templates for more modules
1 year, 9 months ago (2021-08-17 08:44:01 UTC) #12
reviewbot
flake8 OK URL: https://codereview.tryton.org/299621002
1 year, 9 months ago (2021-08-17 08:57:12 UTC) #13
pokoli
Update to tip
1 year, 5 months ago (2021-12-14 15:23:54 UTC) #14
reviewbot
checks OK URL: https://codereview.tryton.org/299621002
1 year, 5 months ago (2021-12-14 15:28:38 UTC) #15
pokoli
Update to tip
1 year, 2 months ago (2022-03-28 15:20:45 UTC) #16
reviewbot
checks OK URL: https://codereview.tryton.org/299621002
1 year, 2 months ago (2022-03-28 15:32:07 UTC) #17
ced
https://codereview.tryton.org/299621002/diff/390391002/modules/account_invoice/trigger.xml File modules/account_invoice/trigger.xml (right): https://codereview.tryton.org/299621002/diff/390391002/modules/account_invoice/trigger.xml#newcode7 modules/account_invoice/trigger.xml:7: <field name="name">When an invoice is posted</field> I think we ...
10 months, 2 weeks ago (2022-07-26 22:20:11 UTC) #18
pokoli
Update to tip and fix remarks
9 months, 4 weeks ago (2022-08-11 12:46:34 UTC) #19
reviewbot
patch is not applicable URL: https://codereview.tryton.org/299621002
9 months, 4 weeks ago (2022-08-11 13:16:46 UTC) #20
pokoli
Update to tip
6 months, 3 weeks ago (2022-11-15 07:05:08 UTC) #21
reviewbot
6 months, 3 weeks ago (2022-11-15 07:22:09 UTC) #22
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted