tryton-env: Add trigger templates

issue9320

[reviewbot, 2020-05-09 18:16:33]

flake8 OK
URL: https://codereview.tryton.org/299621002

[dave, 2020-05-11 11:03:25]

https://codereview.tryton.org/299621002/diff/293641002/trytond/trytond/ir/tri...
File trytond/trytond/ir/trigger.py (right):

https://codereview.tryton.org/299621002/diff/293641002/trytond/trytond/ir/tri...
trytond/trytond/ir/trigger.py:61: '"On Time" and others are mutually
exclusive!'),
Should this text go in message.xml, with the xml id here?

Perhaps as?
You cannot use "On Time" at the same time as the other events"

[pokoli, 2020-05-12 11:14:02]

Fix dave's comments

[pokoli, 2020-05-12 11:15:10]

Remove unrelated patch

[reviewbot, 2020-05-12 11:38:10]

flake8 OK
URL: https://codereview.tryton.org/299621002

[ced, 2021-08-08 15:40:19]

https://codereview.tryton.org/299621002/diff/323281002/trytond/trytond/ir/tri...
File trytond/trytond/ir/trigger.py (right):

https://codereview.tryton.org/299621002/diff/323281002/trytond/trytond/ir/tri...
trytond/trytond/ir/trigger.py:30: class TriggerMixin(DeactivableMixin, ModelSQL,
ModelView):
I do not think template must be deactivable.

https://codereview.tryton.org/299621002/diff/323281002/trytond/trytond/ir/tri...
trytond/trytond/ir/trigger.py:115: _template_fields = {
Better to use a function because it can be extended for customization.

https://codereview.tryton.org/299621002/diff/323281002/trytond/trytond/ir/tri...
File trytond/trytond/ir/trigger.xml (right):

https://codereview.tryton.org/299621002/diff/323281002/trytond/trytond/ir/tri...
trytond/trytond/ir/trigger.xml:6: 
Not necessary

[pokoli, 2021-08-09 07:52:04]

Update to tip and fix comments

[pokoli, 2021-08-09 07:55:11]

Remove uneeded condition used and empty line

[reviewbot, 2021-08-09 08:00:31]

flake8 OK
URL: https://codereview.tryton.org/299621002

[dave, 2021-08-09 21:27:01]

https://codereview.tryton.org/299621002/diff/336761002/trytond/trytond/ir/mes...
File trytond/trytond/ir/message.xml (right):

https://codereview.tryton.org/299621002/diff/336761002/trytond/trytond/ir/mes...
trytond/trytond/ir/message.xml:376: <field name="text">You can not use "On Time"
at the same time as other events.</field>
can not -> cannot

[pokoli, 2021-08-17 08:44:01]

Fix comment and add trigger templates for more modules

[reviewbot, 2021-08-17 08:57:12]

flake8 OK
URL: https://codereview.tryton.org/299621002

[pokoli, 2021-12-14 15:23:54]

Update to tip

[reviewbot, 2021-12-14 15:28:38]

checks OK
URL: https://codereview.tryton.org/299621002

[pokoli, 2022-03-28 15:20:45]

Update to tip

[reviewbot, 2022-03-28 15:32:07]

checks OK
URL: https://codereview.tryton.org/299621002

[ced, 2022-07-26 22:20:11]

https://codereview.tryton.org/299621002/diff/390391002/modules/account_invoic...
File modules/account_invoice/trigger.xml (right):

https://codereview.tryton.org/299621002/diff/390391002/modules/account_invoic...
modules/account_invoice/trigger.xml:7: <field name="name">When an invoice is
posted</field>
I think we should not use the pronom 'a' in the trigger name to be more general:

When invoice is posted

https://codereview.tryton.org/299621002/diff/390391002/modules/account_invoic...
modules/account_invoice/trigger.xml:7: <field name="name">When an invoice is
posted</field>
I do not think we need a trigger for any type of invoice.
User who really need both will create 2 triggers.

https://codereview.tryton.org/299621002/diff/390391002/modules/account_invoic...
modules/account_invoice/trigger.xml:10: <field name="condition"
eval="Eval('self', {}).get('state', '') == 'posted'" pyson="1"/>
The problem is that it will not be expected to be triggered if the invoice goes
from paid to posted.

So I think it should be: state in ['posted', 'paid']

https://codereview.tryton.org/299621002/diff/390391002/modules/account_paymen...
File modules/account_payment/trigger.xml (right):

https://codereview.tryton.org/299621002/diff/390391002/modules/account_paymen...
modules/account_payment/trigger.xml:10: <field name="condition"
eval="Eval('self', {}).get('state', '') == 'processing'" pyson="1"/>
Idem it should not be trigger when coming from succeeded nor failed

https://codereview.tryton.org/299621002/diff/390391002/modules/account_paymen...
modules/account_payment/trigger.xml:11: </record>
I think we need also a trigger for succeeded and another for failed.

https://codereview.tryton.org/299621002/diff/390391002/modules/sale_complaint...
File modules/sale_complaint/tryton.cfg (right):

https://codereview.tryton.org/299621002/diff/390391002/modules/sale_complaint...
modules/sale_complaint/tryton.cfg:14: trigger.xml
missing the file

https://codereview.tryton.org/299621002/diff/390391002/modules/stock/trigger.xml
File modules/stock/trigger.xml (right):

https://codereview.tryton.org/299621002/diff/390391002/modules/stock/trigger....
modules/stock/trigger.xml:7: <field name="name">When a shipment out is
packed</field>
When customer shipment is packed

https://codereview.tryton.org/299621002/diff/390391002/trytond/trytond/ir/mes...
File trytond/trytond/ir/message.xml (right):

https://codereview.tryton.org/299621002/diff/390391002/trytond/trytond/ir/mes...
trytond/trytond/ir/message.xml:314: 
I would add the new message here.

https://codereview.tryton.org/299621002/diff/390391002/trytond/trytond/ir/tri...
File trytond/trytond/ir/trigger.py (right):

https://codereview.tryton.org/299621002/diff/390391002/trytond/trytond/ir/tri...
trytond/trytond/ir/trigger.py:43: condition = fields.Char("Condition",
required=True,
I would prefer to not change quote here as the lines are not edited.

https://codereview.tryton.org/299621002/diff/390391002/trytond/trytond/ir/tri...
trytond/trytond/ir/trigger.py:140: (),
no need for trailing ,

https://codereview.tryton.org/299621002/diff/390391002/trytond/trytond/ir/tri...
trytond/trytond/ir/trigger.py:143: depends=['model'])
no more needed

https://codereview.tryton.org/299621002/diff/390391002/trytond/trytond/ir/tri...
trytond/trytond/ir/trigger.py:162: field.depends.append('template')
no more needed

https://codereview.tryton.org/299621002/diff/390391002/trytond/trytond/ir/tri...
trytond/trytond/ir/trigger.py:165: def _get_template_fields(cls):
Must be public as it is used on template.

https://codereview.tryton.org/299621002/diff/390391002/trytond/trytond/ir/tri...
File trytond/trytond/ir/trigger.xml (right):

https://codereview.tryton.org/299621002/diff/390391002/trytond/trytond/ir/tri...
trytond/trytond/ir/trigger.xml:9: <field name="name">trigger_form</field>
I think it could inherit from trigger_template_form

https://codereview.tryton.org/299621002/diff/390391002/trytond/trytond/ir/tri...
trytond/trytond/ir/trigger.xml:14: <field name="name">trigger_list</field>
idem

https://codereview.tryton.org/299621002/diff/390391002/trytond/trytond/ir/tri...
trytond/trytond/ir/trigger.xml:36: <record model="ir.ui.view"
id="trigger_template_view_form">
better to follow the same order as the python file

https://codereview.tryton.org/299621002/diff/390391002/trytond/trytond/ir/tri...
trytond/trytond/ir/trigger.xml:41: <record model="ir.ui.view"
id="trigger_template_view_tree">
_list

https://codereview.tryton.org/299621002/diff/390391002/trytond/trytond/ir/tri...
trytond/trytond/ir/trigger.xml:60: <menuitem parent="menu_trigger_form"
action="act_trigger_template_form" id="menu_trigger_template_form"/>
better to set one attribute per line

https://codereview.tryton.org/299621002/diff/390391002/trytond/trytond/tests/...
File trytond/trytond/tests/test_trigger.py (right):

https://codereview.tryton.org/299621002/diff/390391002/trytond/trytond/tests/...
trytond/trytond/tests/test_trigger.py:484: def
test_template_values_are_updated(self):
Usually we name test like: test_update_from_template

https://codereview.tryton.org/299621002/diff/390391002/trytond/trytond/tests/...
trytond/trytond/tests/test_trigger.py:496: for field in
Trigger._get_template_fields():
I'm never a fan of test that are as complex as the code they test because we
never know if we actually test what we think.
So for me it will be better to explicitly test the value of each field we
explicitly names.

[pokoli, 2022-08-11 12:46:34]

Update to tip and fix remarks

[reviewbot, 2022-08-11 13:16:46]

patch is not applicable
URL: https://codereview.tryton.org/299621002

[pokoli, 2022-11-15 07:05:08]

Update to tip

[reviewbot, 2022-11-15 07:22:09]

checks OK
URL: https://codereview.tryton.org/299621002