Issue 306561010: tryton-env: Add stock_package application API

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1142 lines, -20 lines)			Patch
M	modules/sale_shipment_cost/stock.py	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16	1 chunk	+5 lines, -0 lines	0 comments	Download
M	modules/sale_shipment_cost/tryton.cfg	View	1 2 3 4 5 6 7 8 9 10 11 12 13	1 chunk	+1 line, -0 lines	0 comments	Download
M	modules/sale_shipment_tolerance/sale.py	View	1 2 3 4 5 6 7 8 9 10 11	3 chunks	+30 lines, -13 lines	0 comments	Download
M	modules/sale_shipment_tolerance/stock.py	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	modules/sale_shipment_tolerance/tryton.cfg	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	modules/stock/CHANGELOG	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16	1 chunk	+1 line, -0 lines	0 comments	Download
M	modules/stock/__init__.py	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16	2 chunks	+3 lines, -2 lines	0 comments	Download
M	modules/stock/doc/reference.rst	View	1 2 3 4 5 6 7	1 chunk	+17 lines, -0 lines	0 comments	Download
M	modules/stock/res.py	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	modules/stock/routes.py	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15	1 chunk	+83 lines, -0 lines	0 comments	Download
M	modules/stock_package/CHANGELOG	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16	1 chunk	+2 lines, -0 lines	0 comments	Download
M	modules/stock_package/__init__.py	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	1 chunk	+3 lines, -1 line	0 comments	Download
M	modules/stock_package/doc/index.rst	View	1 2 3 4 5 6 7	1 chunk	+5 lines, -0 lines	0 comments	Download
A	modules/stock_package/doc/reference.rst	View	1 2 3 4 5 6 7	1 chunk	+45 lines, -0 lines	0 comments	Download
A	modules/stock_package/routes.py	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16	1 chunk	+163 lines, -0 lines	0 comments	Download
M	modules/stock_package/setup.py	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	1 chunk	+4 lines, -1 line	0 comments	Download
M	modules/stock_package/stock.py	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16	5 chunks	+183 lines, -0 lines	0 comments	Download
M	modules/stock_package/tests/__init__.py	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16	1 chunk	+12 lines, -0 lines	0 comments	Download
M	modules/stock_package/tests/test_module.py	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16	1 chunk	+271 lines, -1 line	0 comments	Download
M	modules/stock_package_shipping/CHANGELOG	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16	1 chunk	+2 lines, -0 lines	0 comments	Download
M	modules/stock_package_shipping/__init__.py	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	1 chunk	+3 lines, -1 line	0 comments	Download
M	modules/stock_package_shipping/doc/index.rst	View	1 2 3 4 5 6 7 8	1 chunk	+1 line, -0 lines	0 comments	Download
A	modules/stock_package_shipping/doc/reference.rst	View	1 2 3 4 5 6 7	1 chunk	+32 lines, -0 lines	0 comments	Download
A	modules/stock_package_shipping/routes.py	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15	1 chunk	+104 lines, -0 lines	0 comments	Download
M	modules/stock_package_shipping/stock.py	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16	2 chunks	+41 lines, -0 lines	0 comments	Download
M	modules/stock_package_shipping/tests/test_module.py	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16	1 chunk	+57 lines, -1 line	0 comments	Download
M	modules/stock_package_shipping_dpd/stock.py	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	1 chunk	+18 lines, -0 lines	0 comments	Download
M	modules/stock_package_shipping_ups/stock.py	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16	1 chunk	+18 lines, -0 lines	0 comments	Download
M	modules/stock_package_shipping_ups/view/ups_credential_form.xml	View	1 2 3 4 5 6	1 chunk	+2 lines, -0 lines	0 comments	Download
M	modules/stock_shipment_measurements/stock.py	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 38

Expand All Messages | Collapse All Messages

reviewbot

patch is not applicable URL: https://codereview.tryton.org/306561010

2 years, 9 months ago (2021-02-09 16:12:29 UTC) #12

reviewbot

flake8 OK URL: https://codereview.tryton.org/306561010

2 years, 9 months ago (2021-02-09 17:35:03 UTC) #14

dave

https://codereview.tryton.org/306561010/diff/341321002/modules/stock/doc/design/index.rst File modules/stock/doc/design/index.rst (right): https://codereview.tryton.org/306561010/diff/341321002/modules/stock/doc/design/index.rst#newcode17 modules/stock/doc/design/index.rst:17: user_application This might need changing - see below? https://codereview.tryton.org/306561010/diff/341321002/modules/stock/doc/design/user_application.rst ...

2 years, 9 months ago (2021-02-10 19:14:49 UTC) #15

https://codereview.tryton.org/306561010/diff/341321002/modules/stock/doc/desi...
File modules/stock/doc/design/index.rst (right):

https://codereview.tryton.org/306561010/diff/341321002/modules/stock/doc/desi...
modules/stock/doc/design/index.rst:17: user_application
This might need changing - see below?

https://codereview.tryton.org/306561010/diff/341321002/modules/stock/doc/desi...
File modules/stock/doc/design/user_application.rst (right):

https://codereview.tryton.org/306561010/diff/341321002/modules/stock/doc/desi...
modules/stock/doc/design/user_application.rst:4: ################
I think this might be more consistent if this was part of the reference.rst file
in the /doc/ directory as it seems to me like this is part of the module's API?

So, perhaps add something like this to the bottom of the reference.rst file?:

Routes
======

The *Stock Module* provides some routes for use with
`User Applications <trytond:topics-user_application>`:

``GET`` ``/<database_name>/stock/employees``
   Returns a list of the user's employees each as a dictionary containing the
   keys ``id`` and ``name``.

``GET`` ``/<database_name>/stock/warehouses``
   Returns the list of warehouses each as a dictionary containing the keys
   ``id`` and ``name``.

``GET`` ``/<database_name>/stock/shipment/out/<int:shipment>/delivery_note``
   Returns the delivery note report for the ``shipment``.

https://codereview.tryton.org/306561010/diff/341321002/modules/stock_package/...
File modules/stock_package/doc/index.rst (right):

https://codereview.tryton.org/306561010/diff/341321002/modules/stock_package/...
modules/stock_package/doc/index.rst:15: .. toctree::
The read method in setup.py might need updating to strip out the toctree
directive.

https://codereview.tryton.org/306561010/diff/341321002/modules/stock_package/...
modules/stock_package/doc/index.rst:18: user_application
Perhaps use reference.rst here, and a maxdepth of 2?

https://codereview.tryton.org/306561010/diff/341321002/modules/stock_package/...
File modules/stock_package/doc/user_application.rst (right):

https://codereview.tryton.org/306561010/diff/341321002/modules/stock_package/...
modules/stock_package/doc/user_application.rst:1: Stock Package User Application
I suggest perhaps?

*************
API Reference
*************

Routes
======

The *Stock Package Module* provides some routes for use with
*User Applications*:

``GET`` ``/<database_name>/stock_package/package_types``
   Returns a list of package types each as a dictionary containing the keys
   ``id`` and ``name``.

``POST`` ``/<database_name>/stock_package/shipments/out/search``
   Returns a list of waiting and assigned shipments each as a dictionary
   containing the keys ``id``, ``number`` and ``packed_by``, using the
   ``warehouse`` from the data.
   The list is limited to the shipments packed by the either the employee or
   nobody, except when a ``number`` is provided in the data.

``GET`` ``/<database_name>/stock_package/shipment/out/<int:shipment>``
   Returns the ``shipment`` as a dictionary containing the keys ``id``,
   ``number``, ``packed_by``, ``customer``, ``delivery_address``, ``moves``,
   ``packages`` and ``state``.

``PUT`` ``/<database_name>/stock_package/shipment/out/<int:shipment>``
   Updates the ``shipment`` using the ``packed_by``, ``packages`` and
   ``state`` from the data.

``GET``
``/<database_name>/stock_package/shipment/out/<int:shipment>/attachments``
   Returns a list of attachments for the ``shipment`` containing the keys
   ``id``, ``last_user``, ``last_modification``, ``name`` and ``link``.

``GET`` ``/<database_name>/stock_package/attachment/<int:attachment>``
   Returns the contents of the ``attachment``.

``GET`` ``/<database_name>/stock_package/shipment/out/<int:shipment>/notes``
   Returns a list of notes for the ``shipment`` containing the keys
   ``id``, ``last_user``, ``last_modification``, ``message`` and
   ``unread``.

``PUT`` ``/<database_name>/stock_package/note/<int:note>``
   Updates the ``note`` using the ``unread`` from the data.

https://codereview.tryton.org/306561010/diff/341321002/modules/stock_package_...
File modules/stock_package_shipping/doc/index.rst (right):

https://codereview.tryton.org/306561010/diff/341321002/modules/stock_package_...
modules/stock_package_shipping/doc/index.rst:56: .. toctree::
The read method in setup.py might need updating to strip out the toctree
directive.

https://codereview.tryton.org/306561010/diff/341321002/modules/stock_package_...
modules/stock_package_shipping/doc/index.rst:59: user_application
Perhaps use reference.rst instead, and a maxdepth of 2?

https://codereview.tryton.org/306561010/diff/341321002/modules/stock_package_...
File modules/stock_package_shipping/doc/user_application.rst (right):

https://codereview.tryton.org/306561010/diff/341321002/modules/stock_package_...
modules/stock_package_shipping/doc/user_application.rst:1: Stock Package
Shipping User Application
*************
API Reference
*************

Routes
======

The *Stock Package Shipping Module* provides some routes for use with
*User Applications*:

``POST`` ``/<database_name>/stock_package_shipping/shipments/out/search``
   Returns a list of packed shipments each as a dictionary containing the
   keys ``id``, ``number`` and ``done_by`` using the ``warehouse`` from the
   data.
   The list is limited to shipments shipped by the either the employee or
   nobody, except when a ``number`` is provided in the data.

``GET`` ``/<database_name>/stock_package_shipping/shipment/out/<int:shipment>``
   Returns the ``shipment`` as a dictionary containing the keys ``id``,
   ``number``, ``done_by``, ``customer``, ``delivery_address``, ``packages``
   and ``states``.

``PUT`` ``/<database_name>/stock_package_shipping/shipment/out/<int:shipment>``
   Updates the ``shipment`` using the ``done_by`` and ``state`` from the
   data.

``POST``
``/<database_name>/stock_package_shipping/shipment/out/<int:shipment>/create_shipping``
   Runs the *Create Shipping* wizard on the ``shipment``.

``GET`` ``/<database_name>/stock_package_shipping/package/<int:package>/label``
   Returns the ``package`` label data.

ced

https://codereview.tryton.org/306561010/diff/341321002/modules/stock/doc/design/index.rst File modules/stock/doc/design/index.rst (right): https://codereview.tryton.org/306561010/diff/341321002/modules/stock/doc/design/index.rst#newcode17 modules/stock/doc/design/index.rst:17: user_application On 2021/02/10 19:14:48, dave wrote: > This might ...

2 years, 9 months ago (2021-02-13 11:56:07 UTC) #16

https://codereview.tryton.org/306561010/diff/341321002/modules/stock/doc/desi...
File modules/stock/doc/design/index.rst (right):

https://codereview.tryton.org/306561010/diff/341321002/modules/stock/doc/desi...
modules/stock/doc/design/index.rst:17: user_application
On 2021/02/10 19:14:48, dave wrote:
> This might need changing - see below?

Done.

https://codereview.tryton.org/306561010/diff/341321002/modules/stock/doc/desi...
File modules/stock/doc/design/user_application.rst (right):

https://codereview.tryton.org/306561010/diff/341321002/modules/stock/doc/desi...
modules/stock/doc/design/user_application.rst:4: ################
On 2021/02/10 19:14:48, dave wrote:
> I think this might be more consistent if this was part of the reference.rst
file
> in the /doc/ directory as it seems to me like this is part of the module's
API?
> 
> So, perhaps add something like this to the bottom of the reference.rst file?:
> 
> Routes
> ======
> 
> The *Stock Module* provides some routes for use with
> `User Applications <trytond:topics-user_application>`:
> 
> ``GET`` ``/<database_name>/stock/employees``
>    Returns a list of the user's employees each as a dictionary containing the
>    keys ``id`` and ``name``.
> 
> ``GET`` ``/<database_name>/stock/warehouses``
>    Returns the list of warehouses each as a dictionary containing the keys
>    ``id`` and ``name``.
> 
> ``GET`` ``/<database_name>/stock/shipment/out/<int:shipment>/delivery_note``
>    Returns the delivery note report for the ``shipment``.

Done.

https://codereview.tryton.org/306561010/diff/341321002/modules/stock_package/...
File modules/stock_package/doc/index.rst (right):

https://codereview.tryton.org/306561010/diff/341321002/modules/stock_package/...
modules/stock_package/doc/index.rst:15: .. toctree::
On 2021/02/10 19:14:48, dave wrote:
> The read method in setup.py might need updating to strip out the toctree
> directive.

Done.

https://codereview.tryton.org/306561010/diff/341321002/modules/stock_package/...
modules/stock_package/doc/index.rst:18: user_application
On 2021/02/10 19:14:48, dave wrote:
> Perhaps use reference.rst here, and a maxdepth of 2?

Done.

https://codereview.tryton.org/306561010/diff/341321002/modules/stock_package/...
File modules/stock_package/doc/user_application.rst (right):

https://codereview.tryton.org/306561010/diff/341321002/modules/stock_package/...
modules/stock_package/doc/user_application.rst:1: Stock Package User Application
On 2021/02/10 19:14:48, dave wrote:
> I suggest perhaps?
> 
> *************
> API Reference
> *************
> 
> Routes
> ======
> 
> The *Stock Package Module* provides some routes for use with
> *User Applications*:
> 
> ``GET`` ``/<database_name>/stock_package/package_types``
>    Returns a list of package types each as a dictionary containing the keys
>    ``id`` and ``name``.
> 
> ``POST`` ``/<database_name>/stock_package/shipments/out/search``
>    Returns a list of waiting and assigned shipments each as a dictionary
>    containing the keys ``id``, ``number`` and ``packed_by``, using the
>    ``warehouse`` from the data.
>    The list is limited to the shipments packed by the either the employee or
>    nobody, except when a ``number`` is provided in the data.
> 
> ``GET`` ``/<database_name>/stock_package/shipment/out/<int:shipment>``
>    Returns the ``shipment`` as a dictionary containing the keys ``id``,
>    ``number``, ``packed_by``, ``customer``, ``delivery_address``, ``moves``,
>    ``packages`` and ``state``.
> 
> ``PUT`` ``/<database_name>/stock_package/shipment/out/<int:shipment>``
>    Updates the ``shipment`` using the ``packed_by``, ``packages`` and
>    ``state`` from the data.
> 
> ``GET``
> ``/<database_name>/stock_package/shipment/out/<int:shipment>/attachments``
>    Returns a list of attachments for the ``shipment`` containing the keys
>    ``id``, ``last_user``, ``last_modification``, ``name`` and ``link``.
> 
> ``GET`` ``/<database_name>/stock_package/attachment/<int:attachment>``
>    Returns the contents of the ``attachment``.
> 
> ``GET`` ``/<database_name>/stock_package/shipment/out/<int:shipment>/notes``
>    Returns a list of notes for the ``shipment`` containing the keys
>    ``id``, ``last_user``, ``last_modification``, ``message`` and
>    ``unread``.
> 
> ``PUT`` ``/<database_name>/stock_package/note/<int:note>``
>    Updates the ``note`` using the ``unread`` from the data.

Done.

https://codereview.tryton.org/306561010/diff/341321002/modules/stock_package_...
File modules/stock_package_shipping/doc/index.rst (right):

https://codereview.tryton.org/306561010/diff/341321002/modules/stock_package_...
modules/stock_package_shipping/doc/index.rst:56: .. toctree::
On 2021/02/10 19:14:49, dave wrote:
> The read method in setup.py might need updating to strip out the toctree
> directive.

Done.

https://codereview.tryton.org/306561010/diff/341321002/modules/stock_package_...
modules/stock_package_shipping/doc/index.rst:59: user_application
On 2021/02/10 19:14:49, dave wrote:
> Perhaps use reference.rst instead, and a maxdepth of 2?

Done.

https://codereview.tryton.org/306561010/diff/341321002/modules/stock_package_...
File modules/stock_package_shipping/doc/user_application.rst (right):

https://codereview.tryton.org/306561010/diff/341321002/modules/stock_package_...
modules/stock_package_shipping/doc/user_application.rst:1: Stock Package
Shipping User Application
On 2021/02/10 19:14:49, dave wrote:
> *************
> API Reference
> *************
> 
> Routes
> ======
> 
> The *Stock Package Shipping Module* provides some routes for use with
> *User Applications*:
> 
> ``POST`` ``/<database_name>/stock_package_shipping/shipments/out/search``
>    Returns a list of packed shipments each as a dictionary containing the
>    keys ``id``, ``number`` and ``done_by`` using the ``warehouse`` from the
>    data.
>    The list is limited to shipments shipped by the either the employee or
>    nobody, except when a ``number`` is provided in the data.
> 
> ``GET``
``/<database_name>/stock_package_shipping/shipment/out/<int:shipment>``
>    Returns the ``shipment`` as a dictionary containing the keys ``id``,
>    ``number``, ``done_by``, ``customer``, ``delivery_address``, ``packages``
>    and ``states``.
> 
> ``PUT``
``/<database_name>/stock_package_shipping/shipment/out/<int:shipment>``
>    Updates the ``shipment`` using the ``done_by`` and ``state`` from the
>    data.
> 
> ``POST``
>
``/<database_name>/stock_package_shipping/shipment/out/<int:shipment>/create_shipping``
>    Runs the *Create Shipping* wizard on the ``shipment``.
> 
> ``GET``
``/<database_name>/stock_package_shipping/package/<int:package>/label``
>    Returns the ``package`` label data.

Done.

reviewbot

flake8 OK URL: https://codereview.tryton.org/306561010

2 years, 9 months ago (2021-02-13 12:13:13 UTC) #18

reviewbot

https://codereview.tryton.org/306561010/diff/332341003/modules/stock_package_shipping_dpd/stock.py#newcode64 modules/stock_package_shipping_dpd/stock.py:64: redefinition of unused 'Package' from line 28 URL: https://codereview.tryton.org/306561010

2 years, 8 months ago (2021-03-23 10:38:14 UTC) #20

reviewbot

flake8 OK URL: https://codereview.tryton.org/306561010

2 years, 8 months ago (2021-03-23 11:05:07 UTC) #22

reviewbot

flake8 OK URL: https://codereview.tryton.org/306561010

2 years, 8 months ago (2021-03-31 09:43:48 UTC) #24

reviewbot

flake8 OK URL: https://codereview.tryton.org/306561010

2 years, 4 months ago (2021-08-03 16:58:33 UTC) #26

reviewbot

flake8 OK URL: https://codereview.tryton.org/306561010

1 year, 12 months ago (2021-12-06 16:03:28 UTC) #30

reviewbot

ERROR: /tmp/reviewbot-57d6z3tz/modules/stock_package/tests/__init__.py Imports are incorrectly sorted and/or formatted. ERROR: /tmp/reviewbot-57d6z3tz/modules/stock_package_shipping/tests/test_shipping.py Imports are incorrectly sorted and/or ...

1 year, 10 months ago (2022-01-20 14:25:42 UTC) #32

reviewbot

checks OK URL: https://codereview.tryton.org/306561010

1 year, 10 months ago (2022-01-20 15:21:01 UTC) #34

acaubet

https://codereview.tryton.org/306561010/diff/378141004/modules/stock_package/routes.py File modules/stock_package/routes.py (right): https://codereview.tryton.org/306561010/diff/378141004/modules/stock_package/routes.py#newcode55 modules/stock_package/routes.py:55: domain.append(('state', '=', 'picked')) picked state is already on the ...

1 year, 4 months ago (2022-07-11 14:32:14 UTC) #35

ced

1 year, 1 month ago (2022-10-10 07:39:19 UTC) #36

checks OK
URL: https://codereview.tryton.org/306561010

Expand All Messages | Collapse All Messages

Issue 306561010: tryton-env: Add stock_package application API

Description

Patch Set 1 #

Patch Set 2 : Add search limit #

Patch Set 3 : Add more search limit #

Patch Set 4 : Use create_shipping to validate #

Patch Set 5 : Set active_ids and active_model to context #

Patch Set 6 : Order by date #

Patch Set 7 : Update to tip #

Patch Set 8 : fix doc #

Patch Set 9 : Allow extending label route #

Patch Set 10 : flake8 #

Patch Set 11 : Update to tip and raise error on unknown product #

Patch Set 12 : #

Patch Set 13 : Use shipping_label_mimetype #

Patch Set 14 : Update to tip and do not remove origin to trigger sale process #

Patch Set 15 : Update to tip, use custom search method #

Patch Set 16 : Fix isort #

Patch Set 17 : Update to tip and remove duplicated state domain #

Messages