Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(225)

Issue 30851002: tryton: Add support for search_* attributes on relational fields (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 7 months ago by nicoe
Modified:
3 months, 3 weeks ago
Reviewers:
pokoli, reviewbot, rietveld-bot, albert, ced
Visibility:
Public.

Description

Searches done on relational fields might use some additional information for the context or the order used. issue6081

Patch Set 1 #

Total comments: 4

Patch Set 2 : Use search_value instead of hard-setting the domain of the WinSearch window #

Total comments: 7

Patch Set 3 : Remove search_domain #

Patch Set 4 : resolve conflicts #

Total comments: 18

Patch Set 5 : fix remarks #

Patch Set 6 : Fix get_context call #

Patch Set 7 : update to tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -27 lines) Patch
M tryton/common/completion.py View 1 2 3 4 5 6 2 chunks +3 lines, -2 lines 0 comments Download
M tryton/gui/window/view_form/model/field.py View 1 2 3 4 5 6 1 chunk +9 lines, -0 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/many2many.py View 1 2 3 4 5 6 2 chunks +3 lines, -2 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/many2one.py View 1 2 3 4 5 6 4 chunks +6 lines, -4 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/one2many.py View 1 2 3 4 5 6 3 chunks +7 lines, -4 lines 0 comments Download
M tryton/gui/window/view_form/view/list_gtk/widget.py View 1 2 3 4 5 6 4 chunks +9 lines, -11 lines 0 comments Download
M tryton/gui/window/win_search.py View 1 2 3 4 5 6 4 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 25
nicoe
1 year, 7 months ago (2016-12-02 17:04:06 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/30851002
1 year, 7 months ago (2016-12-02 17:29:14 UTC) #2
ced
Same remarks for title as in trytond patch. https://tryton-rietveld.appspot.com/30851002/diff/1/tryton/gui/window/view_form/model/field.py File tryton/gui/window/view_form/model/field.py (right): https://tryton-rietveld.appspot.com/30851002/diff/1/tryton/gui/window/view_form/model/field.py#newcode54 tryton/gui/window/view_form/model/field.py:54: def ...
1 year, 7 months ago (2016-12-06 04:20:59 UTC) #3
nicoe
Use search_value instead of hard-setting the domain of the WinSearch window
1 year, 7 months ago (2016-12-13 17:21:15 UTC) #4
nicoe
https://tryton-rietveld.appspot.com/30851002/diff/1/tryton/gui/window/view_form/model/field.py File tryton/gui/window/view_form/model/field.py (right): https://tryton-rietveld.appspot.com/30851002/diff/1/tryton/gui/window/view_form/model/field.py#newcode54 tryton/gui/window/view_form/model/field.py:54: def domain_get(self, record, search=False): On 2016/12/06 04:20:58, ced wrote: ...
1 year, 7 months ago (2016-12-13 17:21:21 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/30851002
1 year, 7 months ago (2016-12-13 17:28:28 UTC) #6
pokoli
https://tryton-rietveld.appspot.com/30851002/diff/20001/tryton/gui/window/view_form/model/field.py File tryton/gui/window/view_form/model/field.py (right): https://tryton-rietveld.appspot.com/30851002/diff/20001/tryton/gui/window/view_form/model/field.py#newcode71 tryton/gui/window/view_form/model/field.py:71: def order_get(self, record): I prefer using get_order, specially if ...
1 year, 7 months ago (2016-12-14 12:48:17 UTC) #7
nicoe
https://tryton-rietveld.appspot.com/30851002/diff/20001/tryton/gui/window/view_form/view/form_gtk/many2one.py File tryton/gui/window/view_form/view/form_gtk/many2one.py (right): https://tryton-rietveld.appspot.com/30851002/diff/20001/tryton/gui/window/view_form/view/form_gtk/many2one.py#newcode145 tryton/gui/window/view_form/view/form_gtk/many2one.py:145: win.screen.search_filter(quote(text) if text else None) On 2016/12/14 12:48:17, pokoli ...
1 year, 7 months ago (2016-12-14 15:41:27 UTC) #8
nicoe
https://tryton-rietveld.appspot.com/30851002/diff/20001/tryton/gui/window/view_form/model/field.py File tryton/gui/window/view_form/model/field.py (right): https://tryton-rietveld.appspot.com/30851002/diff/20001/tryton/gui/window/view_form/model/field.py#newcode71 tryton/gui/window/view_form/model/field.py:71: def order_get(self, record): On 2016/12/14 12:48:17, pokoli wrote: > ...
1 year, 7 months ago (2016-12-14 15:41:50 UTC) #9
ced
https://tryton-rietveld.appspot.com/30851002/diff/20001/tryton/gui/window/view_form/view/form_gtk/many2many.py File tryton/gui/window/view_form/view/form_gtk/many2many.py (right): https://tryton-rietveld.appspot.com/30851002/diff/20001/tryton/gui/window/view_form/view/form_gtk/many2many.py#newcode161 tryton/gui/window/view_form/view/form_gtk/many2many.py:161: search_value=search_value, It is wrong for me to have the ...
1 year, 7 months ago (2016-12-15 08:14:53 UTC) #10
nicoe
Remove search_order
1 year, 7 months ago (2016-12-15 14:33:06 UTC) #11
nicoe
https://tryton-rietveld.appspot.com/30851002/diff/20001/tryton/gui/window/view_form/view/form_gtk/many2one.py File tryton/gui/window/view_form/view/form_gtk/many2one.py (right): https://tryton-rietveld.appspot.com/30851002/diff/20001/tryton/gui/window/view_form/view/form_gtk/many2one.py#newcode145 tryton/gui/window/view_form/view/form_gtk/many2one.py:145: win.screen.search_filter(quote(text) if text else None) On 2016/12/15 08:14:53, ced ...
1 year, 7 months ago (2016-12-15 14:33:08 UTC) #12
reviewbot
patch is not applicable URL: https://codereview.tryton.org/30851002
1 year, 7 months ago (2016-12-15 14:34:44 UTC) #13
reviewbot
flake8 OK URL: https://codereview.tryton.org/30851002
1 year, 6 months ago (2016-12-21 15:03:07 UTC) #14
ced
https://tryton-rietveld.appspot.com/30851002/diff/60001/tryton/gui/window/view_form/model/field.py File tryton/gui/window/view_form/model/field.py (right): https://tryton-rietveld.appspot.com/30851002/diff/60001/tryton/gui/window/view_form/model/field.py#newcode69 tryton/gui/window/view_form/model/field.py:69: return context Is it not better to have a ...
1 year, 6 months ago (2016-12-26 15:55:17 UTC) #15
albert
1 year, 6 months ago (2017-01-04 16:02:19 UTC) #16
nicoe
https://tryton-rietveld.appspot.com/30851002/diff/60001/tryton/gui/window/view_form/model/field.py File tryton/gui/window/view_form/model/field.py (right): https://tryton-rietveld.appspot.com/30851002/diff/60001/tryton/gui/window/view_form/model/field.py#newcode69 tryton/gui/window/view_form/model/field.py:69: return context On 2016/12/26 15:55:16, ced wrote: > Is ...
1 year, 6 months ago (2017-01-12 13:42:27 UTC) #17
reviewbot
flake8 OK URL: https://codereview.tryton.org/30851002
1 year, 6 months ago (2017-01-12 15:17:46 UTC) #18
nicoe
Fix get_context call
1 year, 6 months ago (2017-01-12 17:56:25 UTC) #19
reviewbot
flake8 OK URL: https://codereview.tryton.org/30851002
1 year, 6 months ago (2017-01-12 18:14:44 UTC) #20
ced
LGTM
1 year, 6 months ago (2017-01-13 22:47:53 UTC) #21
nicoe
update to tip
4 months ago (2018-03-15 17:57:53 UTC) #22
reviewbot
https://codereview.tryton.org/30851002/diff/120001/tryton/gui/window/view_form/view/list_gtk/widget.py#newcode822 tryton/gui/window/view_form/view/list_gtk/widget.py:822: E731 do not assign a lambda expression, use a def URL: https://codereview.tryton.org/30851002
4 months ago (2018-03-15 18:12:33 UTC) #23
ced
Still LGTM
3 months, 3 weeks ago (2018-03-21 12:29:11 UTC) #24
rietveld-bot_tryton.org
3 months, 3 weeks ago (2018-03-21 16:58:59 UTC) #25
New changeset c219609b2a1a by Nicolas ?vrard in branch 'default':
Add support for search_* attributes on relational fields
http://hg.tryton.org/tryton/rev/c219609b2a1a
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3870a69