Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(31)

Issue 31881002: purchase_request_quotation: Initial commit

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 months, 2 weeks ago by mrichez
Modified:
3 days, 10 hours ago
Reviewers:
pokoli, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 12

Patch Set 2 : Applying last remarks #

Patch Set 3 : Applying last remarks #

Total comments: 169

Patch Set 4 : applying last comments #

Patch Set 5 : remove property fields #

Patch Set 6 : fixing bug in removal of property fields #

Patch Set 7 : Update to tip #

Patch Set 8 : Update scenario following https://bugs.tryton.org/issue6133 #

Patch Set 9 : Converting report to Flat OpenDocument #

Total comments: 150

Patch Set 10 : Applying Ced's remarks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2832 lines, -0 lines) Patch
A .drone.yml View 1 2 3 4 5 6 1 chunk +51 lines, -0 lines 0 comments Download
A COPYRIGHT View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
A INSTALL View 1 2 3 1 chunk +32 lines, -0 lines 0 comments Download
A LICENSE View 1 chunk +674 lines, -0 lines 0 comments Download
A MANIFEST.in View 1 2 3 4 5 6 7 8 1 chunk +13 lines, -0 lines 0 comments Download
A README View 1 chunk +20 lines, -0 lines 0 comments Download
A __init__.py View 1 2 3 4 5 6 7 8 9 1 chunk +26 lines, -0 lines 0 comments Download
A doc/index.rst View 1 2 3 4 5 6 7 8 9 1 chunk +27 lines, -0 lines 0 comments Download
A purchase.py View 1 2 3 4 5 6 7 8 9 1 chunk +564 lines, -0 lines 0 comments Download
A purchase.xml View 1 2 3 4 5 6 7 8 9 1 chunk +279 lines, -0 lines 0 comments Download
A purchase_request.xml View 1 2 3 4 5 6 7 8 9 1 chunk +26 lines, -0 lines 0 comments Download
A quotation.fodt View 1 2 3 4 5 6 7 8 9 1 chunk +577 lines, -0 lines 0 comments Download
A setup.py View 1 2 3 4 5 6 7 8 1 chunk +117 lines, -0 lines 0 comments Download
A tests/__init__.py View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
A tests/scenario_purchase_request_quotation.rst View 1 2 3 4 5 6 7 8 9 1 chunk +190 lines, -0 lines 0 comments Download
A tests/test_purchase_request_quotation.py View 1 chunk +28 lines, -0 lines 0 comments Download
A tox.ini View 1 chunk +18 lines, -0 lines 0 comments Download
A tryton.cfg View 1 2 3 4 5 6 7 8 9 1 chunk +12 lines, -0 lines 0 comments Download
A view/configuration_form.xml View 1 2 3 4 5 6 7 8 9 1 chunk +10 lines, -0 lines 0 comments Download
A view/purchase_request_form.xml View 1 2 3 4 5 6 7 8 9 1 chunk +11 lines, -0 lines 0 comments Download
A view/purchase_request_quotation_create_ask_suppliers_form.xml View 1 2 3 4 5 6 7 8 9 1 chunk +6 lines, -0 lines 0 comments Download
A view/purchase_request_quotation_create_succeed_form.xml View 1 2 3 4 5 6 7 8 9 1 chunk +9 lines, -0 lines 0 comments Download
A view/purchase_request_quotation_form.xml View 1 2 3 4 5 6 7 8 9 1 chunk +41 lines, -0 lines 0 comments Download
A view/purchase_request_quotation_line_form.xml View 1 2 3 4 5 6 7 8 9 1 chunk +25 lines, -0 lines 0 comments Download
A view/purchase_request_quotation_line_list.xml View 1 2 3 4 5 6 7 8 9 1 chunk +13 lines, -0 lines 0 comments Download
A view/purchase_request_quotation_line_list_sequence.xml View 1 2 3 4 5 6 7 8 9 1 chunk +15 lines, -0 lines 0 comments Download
A view/purchase_request_quotation_line_list_sequence2.xml View 1 2 3 4 5 6 7 8 9 1 chunk +14 lines, -0 lines 0 comments Download
A view/purchase_request_quotation_list.xml View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 33
mrichez
9 months, 2 weeks ago (2017-01-11 08:28:25 UTC) #1
reviewbot
patch is not applicable URL: https://codereview.tryton.org/31881002
9 months, 2 weeks ago (2017-01-11 08:44:02 UTC) #2
pokoli
https://tryton-rietveld.appspot.com/31881002/diff/1/.travis.yml File .travis.yml (right): https://tryton-rietveld.appspot.com/31881002/diff/1/.travis.yml#newcode1 .travis.yml:1: language: python This file is not required as we ...
9 months, 1 week ago (2017-01-13 12:59:47 UTC) #3
mrichez
https://tryton-rietveld.appspot.com/31881002/diff/1/.travis.yml File .travis.yml (right): https://tryton-rietveld.appspot.com/31881002/diff/1/.travis.yml#newcode1 .travis.yml:1: language: python On 2017/01/13 12:59:47, pokoli wrote: > This ...
9 months, 1 week ago (2017-01-16 11:00:49 UTC) #4
mrichez
Applying last remarks
9 months, 1 week ago (2017-01-16 11:01:17 UTC) #5
reviewbot
patch is not applicable URL: https://codereview.tryton.org/31881002
9 months, 1 week ago (2017-01-16 11:10:46 UTC) #6
pokoli
https://tryton-rietveld.appspot.com/31881002/diff/1/purchase.py File purchase.py (right): https://tryton-rietveld.appspot.com/31881002/diff/1/purchase.py#newcode322 purchase.py:322: self.raise_user_warning('warning', 'previous_quotation', { On 2017/01/16 11:00:49, mrichez wrote: > ...
9 months, 1 week ago (2017-01-16 11:37:19 UTC) #7
mrichez
https://tryton-rietveld.appspot.com/31881002/diff/1/purchase.py File purchase.py (right): https://tryton-rietveld.appspot.com/31881002/diff/1/purchase.py#newcode322 purchase.py:322: self.raise_user_warning('warning', 'previous_quotation', { On 2017/01/16 11:37:19, pokoli wrote: > ...
9 months, 1 week ago (2017-01-16 12:55:35 UTC) #8
mrichez
Applying last remarks
9 months, 1 week ago (2017-01-16 15:50:38 UTC) #9
reviewbot
patch is not applicable URL: https://codereview.tryton.org/31881002
9 months, 1 week ago (2017-01-16 16:13:48 UTC) #10
ced
https://tryton-rietveld.appspot.com/31881002/diff/40001/COPYRIGHT File COPYRIGHT (right): https://tryton-rietveld.appspot.com/31881002/diff/40001/COPYRIGHT#newcode3 COPYRIGHT:3: Copyright (C) 2016 SALUC SA update to 2017 https://tryton-rietveld.appspot.com/31881002/diff/40001/INSTALL ...
9 months ago (2017-01-24 15:52:31 UTC) #11
mrichez
https://tryton-rietveld.appspot.com/31881002/diff/40001/COPYRIGHT File COPYRIGHT (right): https://tryton-rietveld.appspot.com/31881002/diff/40001/COPYRIGHT#newcode3 COPYRIGHT:3: Copyright (C) 2016 SALUC SA On 2017/01/24 15:52:27, ced ...
7 months, 1 week ago (2017-03-15 14:45:01 UTC) #12
mrichez
applying last comments
7 months, 1 week ago (2017-03-15 14:46:37 UTC) #13
mrichez
On 2017/03/15 14:46:37, mrichez wrote: > applying last comments Report file quotation.odt is here: https://bugs.tryton.org/file2469/quotation.odt
7 months, 1 week ago (2017-03-15 14:49:27 UTC) #14
reviewbot
https://codereview.tryton.org/31881002/diff/60001/tests/__init__.py#newcode6 tests/__init__.py:6: E501 line too long (102 > 79 characters) URL: https://codereview.tryton.org/31881002
7 months, 1 week ago (2017-03-15 15:00:07 UTC) #15
mrichez
remove property fields
6 months, 3 weeks ago (2017-03-31 12:16:15 UTC) #16
reviewbot
patch is not applicable URL: https://codereview.tryton.org/31881002
6 months, 3 weeks ago (2017-03-31 12:35:41 UTC) #17
mrichez
fixing bug in removal of property fields
6 months, 2 weeks ago (2017-04-10 12:48:02 UTC) #18
reviewbot
https://codereview.tryton.org/31881002/diff/120001/purchase.py#newcode81 purchase.py:81: E302 expected 2 blank lines, found 1 https://codereview.tryton.org/31881002/diff/120001/tests/__init__.py#newcode6 tests/__init__.py:6: E501 line too long ...
6 months, 2 weeks ago (2017-04-10 13:04:15 UTC) #19
mrichez
Update to tip
1 month, 4 weeks ago (2017-08-24 12:02:43 UTC) #20
reviewbot
https://codereview.tryton.org/31881002/diff/130001/tests/__init__.py#newcode6 tests/__init__.py:6: E501 line too long (102 > 79 characters) URL: https://codereview.tryton.org/31881002
1 month, 4 weeks ago (2017-08-24 12:03:13 UTC) #21
mrichez
https://tryton-rietveld.appspot.com/31881002/diff/40001/tests/scenario_purchase_request_quotation.rst File tests/scenario_purchase_request_quotation.rst (right): https://tryton-rietveld.appspot.com/31881002/diff/40001/tests/scenario_purchase_request_quotation.rst#newcode204 tests/scenario_purchase_request_quotation.rst:204: ... i = i + 1 On 2017/01/24 15:52:30, ...
1 week, 4 days ago (2017-10-11 07:22:10 UTC) #22
reviewbot
patch is not applicable URL: https://codereview.tryton.org/31881002
1 week, 4 days ago (2017-10-11 07:38:46 UTC) #23
mrichez
Update scenario following https://bugs.tryton.org/issue6133
1 week, 4 days ago (2017-10-11 07:40:25 UTC) #24
mrichez
Update scenario following https://bugs.tryton.org/issue6133
1 week, 4 days ago (2017-10-11 07:41:30 UTC) #25
reviewbot
https://codereview.tryton.org/31881002/diff/190001/tests/__init__.py#newcode6 tests/__init__.py:6: E501 line too long (102 > 79 characters) URL: https://codereview.tryton.org/31881002
1 week, 4 days ago (2017-10-11 08:16:46 UTC) #26
mrichez
Converting report to Flat OpenDocument
1 week, 4 days ago (2017-10-11 11:16:10 UTC) #27
reviewbot
https://codereview.tryton.org/31881002/diff/210001/tests/__init__.py#newcode6 tests/__init__.py:6: E501 line too long (102 > 79 characters) URL: https://codereview.tryton.org/31881002
1 week, 4 days ago (2017-10-11 11:16:36 UTC) #28
ced
https://codereview.tryton.org/31881002/diff/210001/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/31881002/diff/210001/doc/index.rst#newcode7 doc/index.rst:7: The selection of the quotation is done by taking ...
1 week, 2 days ago (2017-10-13 16:26:06 UTC) #29
ced
https://codereview.tryton.org/31881002/diff/210001/purchase.py File purchase.py (right): https://codereview.tryton.org/31881002/diff/210001/purchase.py#newcode100 purchase.py:100: version_number = fields.Integer('Version Number', readonly=True) On 2017/10/13 16:26:04, ced ...
1 week, 2 days ago (2017-10-13 16:29:31 UTC) #30
mrichez
https://codereview.tryton.org/31881002/diff/210001/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/31881002/diff/210001/doc/index.rst#newcode7 doc/index.rst:7: The selection of the quotation is done by taking ...
3 days, 10 hours ago (2017-10-19 14:04:31 UTC) #31
mrichez
Applying Ced's remarks
3 days, 10 hours ago (2017-10-19 14:05:08 UTC) #32
reviewbot
3 days, 10 hours ago (2017-10-19 14:15:11 UTC) #33
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842