tryton-env: Remove forbidden chars from imported names

issue9829

[reviewbot, 2020-11-13 13:59:24]

patch is not applicable
URL: https://codereview.tryton.org/318821002

[dave, 2020-11-13 15:43:39]

For the commit message I think you might be okay with just:

Strip whitespace on import from country and subdivision names

[2cadz, 2020-11-13 16:09:12]

On 2020/11/13 15:43:39, dave wrote:
> For the commit message I think you might be okay with just:
> 
> Strip whitespace on import from country and subdivision names

It is modified

[ced, 2020-11-16 23:33:12]

https://codereview.tryton.org/318821002/diff/328841003/modules/country/script...
File modules/country/scripts/import_countries.py (right):

https://codereview.tryton.org/318821002/diff/328841003/modules/country/script...
modules/country/scripts/import_countries.py:79: record.name =
gnutranslation.gettext(country.name).strip()
I think we should also replace all forbidden_chars by space.

[reviewbot, 2020-12-07 14:29:26]

patch is not applicable
URL: https://codereview.tryton.org/318821002

[yangoon, 2020-12-09 22:54:56]

https://codereview.tryton.org/318821002/diff/341101002/modules/country/script...
File modules/country/scripts/import_countries.py (right):

https://codereview.tryton.org/318821002/diff/341101002/modules/country/script...
modules/country/scripts/import_countries.py:40: def
_remove_forbidden_chars(string):
As string is a builtin Python module, I would avoid to name variables that way.

[ced, 2020-12-09 23:52:20]

I'm not sure it deserves a changelog entry. It is a requirement because of a new
enforcement, it is not really a new feature.

https://codereview.tryton.org/318821002/diff/341101002/modules/country/script...
File modules/country/scripts/import_countries.py (right):

https://codereview.tryton.org/318821002/diff/341101002/modules/country/script...
modules/country/scripts/import_countries.py:8: from trytond.model.fields import
Char
I think it is better to import after proteus to ensure to not mess-up the
configuration.
It will even better to just import in the remove_forbidden_chars method.

https://codereview.tryton.org/318821002/diff/341101002/modules/country/script...
modules/country/scripts/import_countries.py:40: def
_remove_forbidden_chars(string):
On 2020/12/09 22:54:56, yangoon wrote:
> As string is a builtin Python module, I would avoid to name variables that
way.

I see no real problem and it is already done in other places.

https://codereview.tryton.org/318821002/diff/341101002/modules/country/script...
modules/country/scripts/import_countries.py:40: def
_remove_forbidden_chars(string):
I'm wondering if '_strip_forbidden will not be a better name.

https://codereview.tryton.org/318821002/diff/341101002/modules/country/script...
modules/country/scripts/import_countries.py:41: string = string.strip()
We can simplify the code by just return at the end the string stripped.
Also the replacement could generate a string with ' ' at the borders.

[reviewbot, 2020-12-10 08:55:37]

flake8 OK
URL: https://codereview.tryton.org/318821002

[ced, 2021-01-03 21:44:27]

https://codereview.tryton.org/318821002/diff/339231002/modules/currency/scrip...
File modules/currency/scripts/import_currencies.py (right):

https://codereview.tryton.org/318821002/diff/339231002/modules/currency/scrip...
modules/currency/scripts/import_currencies.py:65: record.name = currency.name
should be applied also here.

[reviewbot, 2021-01-04 21:53:47]

flake8 OK
URL: https://codereview.tryton.org/318821002

[ced, 2021-01-19 21:41:40]

LGTM

[rietveld-bot_tryton.org, 2021-01-19 21:42:59]

New changeset 8da06851200e by Christophe in branch 'default':
Remove forbidden chars from imported names
https://hg.tryton.org/modules/country/rev/8da06851200e

[rietveld-bot_tryton.org, 2021-01-19 21:43:03]

New changeset 35d95390548f by Christophe in branch 'default':
Remove forbidden chars from imported names
https://hg.tryton.org/modules/currency/rev/35d95390548f

[rietveld-bot_tryton.org, 2021-01-19 21:43:11]

New changeset d1b54da33d16 by Christophe in branch 'default':
Remove forbidden chars from imported names
https://hg.tryton.org/tryton-env/rev/d1b54da33d16