Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5)

Issue 318821002: tryton-env: Remove forbidden chars from imported names (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by 2cadz
Modified:
1 year, 4 months ago
Reviewers:
yangoon, rietveld-bot, ced, dave, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removes fobidden chars when importing data (currency and country) #

Total comments: 5

Patch Set 3 : tryton-env: Consideration of comments #

Total comments: 1

Patch Set 4 : ... and on the name of the currency. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M modules/country/scripts/import_countries.py View 1 2 5 chunks +14 lines, -4 lines 0 comments Download
M modules/currency/scripts/import_currencies.py View 1 2 3 3 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 18
2cadz
1 year, 6 months ago (2020-11-13 13:48:04 UTC) #1
reviewbot
patch is not applicable URL: https://codereview.tryton.org/318821002
1 year, 6 months ago (2020-11-13 13:59:24 UTC) #2
dave
For the commit message I think you might be okay with just: Strip whitespace on ...
1 year, 6 months ago (2020-11-13 15:43:39 UTC) #3
2cadz
On 2020/11/13 15:43:39, dave wrote: > For the commit message I think you might be ...
1 year, 6 months ago (2020-11-13 16:09:12 UTC) #4
ced
https://codereview.tryton.org/318821002/diff/328841003/modules/country/scripts/import_countries.py File modules/country/scripts/import_countries.py (right): https://codereview.tryton.org/318821002/diff/328841003/modules/country/scripts/import_countries.py#newcode79 modules/country/scripts/import_countries.py:79: record.name = gnutranslation.gettext(country.name).strip() I think we should also replace ...
1 year, 6 months ago (2020-11-16 23:33:12 UTC) #5
2cadz
1 year, 5 months ago (2020-12-07 14:16:36 UTC) #6
reviewbot
patch is not applicable URL: https://codereview.tryton.org/318821002
1 year, 5 months ago (2020-12-07 14:29:26 UTC) #7
yangoon
https://codereview.tryton.org/318821002/diff/341101002/modules/country/scripts/import_countries.py File modules/country/scripts/import_countries.py (right): https://codereview.tryton.org/318821002/diff/341101002/modules/country/scripts/import_countries.py#newcode40 modules/country/scripts/import_countries.py:40: def _remove_forbidden_chars(string): As string is a builtin Python module, ...
1 year, 5 months ago (2020-12-09 22:54:56 UTC) #8
ced
I'm not sure it deserves a changelog entry. It is a requirement because of a ...
1 year, 5 months ago (2020-12-09 23:52:20 UTC) #9
2cadz
1 year, 5 months ago (2020-12-10 08:32:57 UTC) #10
reviewbot
flake8 OK URL: https://codereview.tryton.org/318821002
1 year, 5 months ago (2020-12-10 08:55:37 UTC) #11
ced
https://codereview.tryton.org/318821002/diff/339231002/modules/currency/scripts/import_currencies.py File modules/currency/scripts/import_currencies.py (right): https://codereview.tryton.org/318821002/diff/339231002/modules/currency/scripts/import_currencies.py#newcode65 modules/currency/scripts/import_currencies.py:65: record.name = currency.name should be applied also here.
1 year, 4 months ago (2021-01-03 21:44:27 UTC) #12
2cadz
1 year, 4 months ago (2021-01-04 21:34:48 UTC) #13
reviewbot
flake8 OK URL: https://codereview.tryton.org/318821002
1 year, 4 months ago (2021-01-04 21:53:47 UTC) #14
ced
LGTM
1 year, 4 months ago (2021-01-19 21:41:40 UTC) #15
rietveld-bot_tryton.org
New changeset 8da06851200e by Christophe in branch 'default': Remove forbidden chars from imported names https://hg.tryton.org/modules/country/rev/8da06851200e
1 year, 4 months ago (2021-01-19 21:42:59 UTC) #16
rietveld-bot_tryton.org
New changeset 35d95390548f by Christophe in branch 'default': Remove forbidden chars from imported names https://hg.tryton.org/modules/currency/rev/35d95390548f
1 year, 4 months ago (2021-01-19 21:43:03 UTC) #17
rietveld-bot_tryton.org
1 year, 4 months ago (2021-01-19 21:43:11 UTC) #18
New changeset d1b54da33d16 by Christophe in branch 'default':
Remove forbidden chars from imported names
https://hg.tryton.org/tryton-env/rev/d1b54da33d16
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted