Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(30)

Issue 31901003: sao: Add support for search_* attributes on relational fields (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 11 months ago by nicoe
Modified:
9 months ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : update to tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -8 lines) Patch
M src/common.js View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/model.js View 1 1 chunk +9 lines, -0 lines 0 comments Download
M src/view/form.js View 1 10 chunks +15 lines, -5 lines 0 comments Download
M src/window.js View 1 4 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 7
nicoe
1 year, 11 months ago (2017-01-12 17:54:28 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/31901003
1 year, 11 months ago (2017-01-12 18:14:28 UTC) #2
ced
LGTM https://tryton-rietveld.appspot.com/31901003/diff/1/src/window.js File src/window.js (right): https://tryton-rietveld.appspot.com/31901003/diff/1/src/window.js#newcode1498 src/window.js:1498: for (var i = 0; i < o.export_fields.length; ...
1 year, 11 months ago (2017-01-13 22:51:07 UTC) #3
nicoe
update to tip
9 months, 1 week ago (2018-03-15 18:03:58 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/31901003
9 months, 1 week ago (2018-03-15 18:12:36 UTC) #5
ced
Still LGTM
9 months ago (2018-03-21 12:30:45 UTC) #6
rietveld-bot_tryton.org
9 months ago (2018-03-21 17:01:45 UTC) #7
New changeset d468bff5895d by Nicolas ?vrard in branch 'default':
Add support for search_* attributes on relational fields
http://hg.tryton.org/sao/rev/d468bff5895d
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766