Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(385)

Issue 32091002: carrier: Add help text (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 2 months ago by xcodinas
Modified:
2 months, 3 weeks ago
Reviewers:
pokoli, rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix remarks #

Total comments: 2

Patch Set 3 : Change tooltip #

Total comments: 4

Patch Set 4 : Add *_country and carrier helps #

Total comments: 7

Patch Set 5 : Fix pokoli remarks #

Total comments: 3

Patch Set 6 : Fix comments #

Total comments: 4

Patch Set 7 : Fix ced comments #

Total comments: 2

Patch Set 8 : Fix remarks #

Total comments: 2

Patch Set 9 : Add second line in from to _country #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M carrier.py View 1 2 3 4 5 6 7 8 2 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 28
xcodinas
1 year, 2 months ago (2017-03-01 12:23:40 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/32091002
1 year, 2 months ago (2017-03-01 12:35:24 UTC) #2
ced
https://tryton-rietveld.appspot.com/32091002/diff/1/carrier.py File carrier.py (right): https://tryton-rietveld.appspot.com/32091002/diff/1/carrier.py#newcode16 carrier.py:16: ondelete='CASCADE', help="The party related to this record.") I do ...
1 year, 2 months ago (2017-03-01 12:49:04 UTC) #3
xcodinas
fix remarks
1 year, 2 months ago (2017-03-02 13:00:46 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/32091002
1 year, 2 months ago (2017-03-02 13:10:20 UTC) #5
ced
https://tryton-rietveld.appspot.com/32091002/diff/20001/carrier.py File carrier.py (right): https://tryton-rietveld.appspot.com/32091002/diff/20001/carrier.py#newcode17 carrier.py:17: help="The party who is going to carry the goods.") ...
1 year, 2 months ago (2017-03-15 22:04:53 UTC) #6
xcodinas
Change tooltip
1 year, 1 month ago (2017-03-27 11:46:14 UTC) #7
reviewbot
flake8 OK URL: https://codereview.tryton.org/32091002
1 year, 1 month ago (2017-03-27 12:00:47 UTC) #8
ced
https://tryton-rietveld.appspot.com/32091002/diff/40001/carrier.py File carrier.py (right): https://tryton-rietveld.appspot.com/32091002/diff/40001/carrier.py#newcode17 carrier.py:17: 'carrier service.') Could be on one line. https://tryton-rietveld.appspot.com/32091002/diff/40001/carrier.py#newcode17 carrier.py:17: ...
1 year, 1 month ago (2017-03-29 21:16:14 UTC) #9
xcodinas
Add *_country and carrier helps
1 year, 1 month ago (2017-04-04 08:48:34 UTC) #10
pokoli
https://tryton-rietveld.appspot.com/32091002/diff/60001/carrier.py File carrier.py (right): https://tryton-rietveld.appspot.com/32091002/diff/60001/carrier.py#newcode16 carrier.py:16: ondelete='CASCADE', help='The party which represents the carrier.') double quotes ...
1 year, 1 month ago (2017-04-04 09:03:59 UTC) #11
reviewbot
flake8 OK URL: https://codereview.tryton.org/32091002
1 year, 1 month ago (2017-04-04 09:07:25 UTC) #12
xcodinas
Fix pokoli remarks
7 months, 3 weeks ago (2017-09-25 15:29:19 UTC) #13
reviewbot
flake8 OK URL: https://codereview.tryton.org/32091002
7 months, 3 weeks ago (2017-09-25 15:44:01 UTC) #14
pokoli
https://tryton-rietveld.appspot.com/32091002/diff/80001/carrier.py File carrier.py (right): https://tryton-rietveld.appspot.com/32091002/diff/80001/carrier.py#newcode21 carrier.py:21: ], help="The product used to invoice the carrier service.") ...
7 months, 3 weeks ago (2017-09-26 07:25:06 UTC) #15
xcodinas
Fix comments
7 months, 3 weeks ago (2017-09-26 07:31:58 UTC) #16
reviewbot
flake8 OK URL: https://codereview.tryton.org/32091002
7 months, 3 weeks ago (2017-09-26 07:40:13 UTC) #17
ced
https://tryton-rietveld.appspot.com/32091002/diff/100001/carrier.py File carrier.py (right): https://tryton-rietveld.appspot.com/32091002/diff/100001/carrier.py#newcode73 carrier.py:73: help="Uncheck to exclude the carrier selection from future use.") ...
7 months, 3 weeks ago (2017-09-27 17:38:21 UTC) #18
xcodinas
Fix ced comments
7 months, 3 weeks ago (2017-09-28 13:52:46 UTC) #19
reviewbot
flake8 OK URL: https://codereview.tryton.org/32091002
7 months, 3 weeks ago (2017-09-28 14:12:34 UTC) #20
ced
https://tryton-rietveld.appspot.com/32091002/diff/120001/carrier.py File carrier.py (right): https://tryton-rietveld.appspot.com/32091002/diff/120001/carrier.py#newcode73 carrier.py:73: help="Uncheck to exclude the carrier criteria from future use.") ...
7 months, 3 weeks ago (2017-09-28 21:14:46 UTC) #21
xcodinas
Fix remarks
7 months, 2 weeks ago (2017-10-04 10:24:14 UTC) #22
reviewbot
flake8 OK URL: https://codereview.tryton.org/32091002
7 months, 2 weeks ago (2017-10-04 10:45:31 UTC) #23
ced
https://codereview.tryton.org/32091002/diff/140001/carrier.py File carrier.py (right): https://codereview.tryton.org/32091002/diff/140001/carrier.py#newcode76 carrier.py:76: help="Apply only to shippings from this country.") Why using ...
6 months ago (2017-11-21 22:48:44 UTC) #24
xcodinas
Add second line in from to _country
3 months ago (2018-02-13 15:21:04 UTC) #25
reviewbot
flake8 OK URL: https://codereview.tryton.org/32091002
3 months ago (2018-02-13 15:50:51 UTC) #26
ced
LGTM
2 months, 3 weeks ago (2018-02-25 22:30:56 UTC) #27
rietveld-bot_tryton.org
2 months, 3 weeks ago (2018-02-26 12:12:22 UTC) #28
New changeset b8e00efd6f5f by Xavier Codinas in branch 'default':
Add help text
http://hg.tryton.org/modules/carrier/rev/b8e00efd6f5f
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922