tryton: Proposal to other menu entries when right click on tabs

Proposal to other menu entries when right click on tabs

[reviewbot, 2020-12-30 18:57:44]

Review's title does not follow the convention:
'^(?P<repository>[A-Za-z_][\w\.-]+)(?P<version> [0-9.]+)?:'
URL: https://codereview.tryton.org/333631002

[reviewbot, 2020-12-31 15:27:04]

flake8 OK
URL: https://codereview.tryton.org/333631002

[Jan, 2020-12-31 15:31:55]

https://codereview.tryton.org/333631002/diff/353081002/tryton/gui/main.py
File tryton/gui/main.py (right):

https://codereview.tryton.org/333631002/diff/353081002/tryton/gui/main.py#new...
tryton/gui/main.py:41: def on_button_press_event(self, widget, event):
Focus page

https://codereview.tryton.org/333631002/diff/353081002/tryton/gui/main.py#new...
tryton/gui/main.py:291: self.notebook.popup_enable()
remove popup_enable

[Jan, 2021-01-02 08:58:39]

https://codereview.tryton.org/333631002/diff/353081002/tryton/gui/main.py
File tryton/gui/main.py (right):

https://codereview.tryton.org/333631002/diff/353081002/tryton/gui/main.py#new...
tryton/gui/main.py:36: class TrytonNotebook(Gtk.Notebook):
Should be bind to the label only

[reviewbot, 2021-01-02 12:17:52]

flake8 OK
URL: https://codereview.tryton.org/333631002

[ced, 2021-01-02 14:25:34]

Probably better to define shortcuts like "Next tab".

https://codereview.tryton.org/333631002/diff/343311002/tryton/gui/main.py
File tryton/gui/main.py (right):

https://codereview.tryton.org/333631002/diff/343311002/tryton/gui/main.py#new...
tryton/gui/main.py:92: popup.append(entry)
I would be better to not reimplement the menu because GtkNotebook has API to
customize the menu label.

[Jan, 2021-01-15 14:01:32]

On 2021/01/02 14:25:34, ced wrote:
> Probably better to define shortcuts like "Next tab".
> 
> https://codereview.tryton.org/333631002/diff/343311002/tryton/gui/main.py
> File tryton/gui/main.py (right):
> 
>
https://codereview.tryton.org/333631002/diff/343311002/tryton/gui/main.py#new...
> tryton/gui/main.py:92: popup.append(entry)
> I would be better to not reimplement the menu because GtkNotebook has API to
> customize the menu label.

Where?

[Jan, 2021-01-15 14:10:02]

On 2021/01/15 14:01:32, Jan wrote:
> On 2021/01/02 14:25:34, ced wrote:
> > Probably better to define shortcuts like "Next tab".
> > 
> > https://codereview.tryton.org/333631002/diff/343311002/tryton/gui/main.py
> > File tryton/gui/main.py (right):
> > 
> >
>
https://codereview.tryton.org/333631002/diff/343311002/tryton/gui/main.py#new...
> > tryton/gui/main.py:92: popup.append(entry)
> > I would be better to not reimplement the menu because GtkNotebook has API to
> > customize the menu label.
> 
> Where?
And otherwise I implemented on tab and not on the whole notebook

[ced, 2021-01-26 21:22:22]

On 2021/01/15 14:10:02, Jan wrote:
> > > I would be better to not reimplement the menu because GtkNotebook has API
to
> > > customize the menu label.
> > 
> > Where?
> And otherwise I implemented on tab and not on the whole notebook

I really think it will be simpler to define a shortcut/menu entry like "Next
tab".
The code will be simpler and easier to maintain.

[ced, 2021-01-26 21:22:39]

On 2021/01/26 21:22:22, ced wrote:
> On 2021/01/15 14:10:02, Jan wrote:
> > > > I would be better to not reimplement the menu because GtkNotebook has
API
> to
> > > > customize the menu label.
> > > 
> > > Where?
> > And otherwise I implemented on tab and not on the whole notebook
> 
> I really think it will be simpler to define a shortcut/menu entry like "Next
> tab".
> The code will be simpler and easier to maintain.

And we could implement it on sao.