Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(438)

Issue 333631002: tryton: Proposal to other menu entries when right click on tabs

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by Jan
Modified:
2 years ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Proposal to other menu entries when right click on tabs

Patch Set 1 #

Patch Set 2 : add tabs to popup #

Total comments: 3

Patch Set 3 : move click detection to tab it self, add close tabs right, fix lot of errors #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -2 lines) Patch
M tryton/gui/main.py View 1 2 4 chunks +90 lines, -2 lines 1 comment Download

Messages

Total messages: 13
Jan
2 years, 1 month ago (2020-12-30 18:56:19 UTC) #1
reviewbot
Review's title does not follow the convention: '^(?P<repository>[A-Za-z_][\w\.-]+)(?P<version> [0-9.]+)?:' URL: https://codereview.tryton.org/333631002
2 years, 1 month ago (2020-12-30 18:57:44 UTC) #2
Jan
2 years, 1 month ago (2020-12-31 15:02:19 UTC) #3
reviewbot
flake8 OK URL: https://codereview.tryton.org/333631002
2 years, 1 month ago (2020-12-31 15:27:04 UTC) #4
Jan
https://codereview.tryton.org/333631002/diff/353081002/tryton/gui/main.py File tryton/gui/main.py (right): https://codereview.tryton.org/333631002/diff/353081002/tryton/gui/main.py#newcode41 tryton/gui/main.py:41: def on_button_press_event(self, widget, event): Focus page https://codereview.tryton.org/333631002/diff/353081002/tryton/gui/main.py#newcode291 tryton/gui/main.py:291: self.notebook.popup_enable() ...
2 years, 1 month ago (2020-12-31 15:31:55 UTC) #5
Jan
https://codereview.tryton.org/333631002/diff/353081002/tryton/gui/main.py File tryton/gui/main.py (right): https://codereview.tryton.org/333631002/diff/353081002/tryton/gui/main.py#newcode36 tryton/gui/main.py:36: class TrytonNotebook(Gtk.Notebook): Should be bind to the label only
2 years, 1 month ago (2021-01-02 08:58:39 UTC) #6
Jan
2 years, 1 month ago (2021-01-02 11:51:01 UTC) #7
reviewbot
flake8 OK URL: https://codereview.tryton.org/333631002
2 years, 1 month ago (2021-01-02 12:17:52 UTC) #8
ced
Probably better to define shortcuts like "Next tab". https://codereview.tryton.org/333631002/diff/343311002/tryton/gui/main.py File tryton/gui/main.py (right): https://codereview.tryton.org/333631002/diff/343311002/tryton/gui/main.py#newcode92 tryton/gui/main.py:92: popup.append(entry) ...
2 years, 1 month ago (2021-01-02 14:25:34 UTC) #9
Jan
On 2021/01/02 14:25:34, ced wrote: > Probably better to define shortcuts like "Next tab". > ...
2 years ago (2021-01-15 14:01:32 UTC) #10
Jan
On 2021/01/15 14:01:32, Jan wrote: > On 2021/01/02 14:25:34, ced wrote: > > Probably better ...
2 years ago (2021-01-15 14:10:02 UTC) #11
ced
On 2021/01/15 14:10:02, Jan wrote: > > > I would be better to not reimplement ...
2 years ago (2021-01-26 21:22:22 UTC) #12
ced
2 years ago (2021-01-26 21:22:39 UTC) #13
On 2021/01/26 21:22:22, ced wrote:
> On 2021/01/15 14:10:02, Jan wrote:
> > > > I would be better to not reimplement the menu because GtkNotebook has
API
> to
> > > > customize the menu label.
> > > 
> > > Where?
> > And otherwise I implemented on tab and not on the whole notebook
> 
> I really think it will be simpler to define a shortcut/menu entry like "Next
> tab".
> The code will be simpler and easier to maintain.

And we could implement it on sao.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted