Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Issue 336611003: sao: Remove type attribute on invisible URL widget (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by ced
Modified:
1 year, 6 months ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

sao: Remove type attribute on invisible URL widget The widget may be filled with invalid content when it is invisible. issue10473

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use _type attribute #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M src/view/form.js View 1 2 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 10
ced
1 year, 6 months ago (2021-07-09 22:50:35 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/336611003
1 year, 6 months ago (2021-07-09 22:52:13 UTC) #2
pokoli
https://codereview.tryton.org/336611003/diff/346611002/src/view/form.js File src/view/form.js (right): https://codereview.tryton.org/336611003/diff/346611002/src/view/form.js#newcode4314 src/view/form.js:4314: this.input.attr('type', 'url'); shouldn't be 'url' changed to this._type?
1 year, 6 months ago (2021-07-12 09:43:16 UTC) #3
ced
https://codereview.tryton.org/336611003/diff/346611002/src/view/form.js File src/view/form.js (right): https://codereview.tryton.org/336611003/diff/346611002/src/view/form.js#newcode4314 src/view/form.js:4314: this.input.attr('type', 'url'); On 2021/07/12 09:43:16, pokoli wrote: > shouldn't ...
1 year, 6 months ago (2021-07-12 11:49:33 UTC) #4
ced
1 year, 6 months ago (2021-07-12 11:49:58 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/336611003
1 year, 6 months ago (2021-07-12 11:54:38 UTC) #6
pokoli
LGTM
1 year, 6 months ago (2021-07-13 07:09:32 UTC) #7
rietveld-bot_tryton.org
New changeset 0690b9561ef9 by Cédric Krier in branch 'default': Remove type attribute on invisible URL ...
1 year, 6 months ago (2021-07-21 21:59:25 UTC) #8
rietveld-bot_tryton.org
New changeset 567bbd33178d by Cédric Krier in branch 'default': Remove type attribute on invisible URL ...
1 year, 6 months ago (2021-07-21 21:59:28 UTC) #9
rietveld-bot_tryton.org
1 year, 6 months ago (2021-08-05 21:59:38 UTC) #10
New changeset 602c0d35425b by Cédric Krier in branch '6.0':
Remove type attribute on invisible URL widget
https://hg.tryton.org/sao/rev/602c0d35425b
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted