account_fr: Fix categorization of 4551 and 4558 accounts

account_fr: Fix categorization of 4551 and 4558 accounts

[ced, 2014-02-10 11:07:41]

Can not read the diff of the patch.
It happens sometimes with rietveld, you must re-upload it on the same issue.

[Paranoid Review Bot, 2014-02-10 11:10:12]

flake8 OK

[Paranoid Review Bot, 2014-02-10 12:10:12]

flake8 OK

[ced, 2014-02-14 00:19:23]

http://codereview.tryton.org/3371002/diff/20001/account_fr.xml
File account_fr.xml (right):

http://codereview.tryton.org/3371002/diff/20001/account_fr.xml#newcode5572
account_fr.xml:5572: <field name="type"
ref="emprunts_dettes_financieres_diverses"/>
But in OE, it is in "Créances : Autres"

http://codereview.tryton.org/3371002/diff/20001/account_fr.xml#newcode5580
account_fr.xml:5580: <field name="type"
ref="emprunts_dettes_financieres_diverses"/>
idem

[RaphaelHertzog, 2014-02-14 07:03:42]

http://codereview.tryton.org/3371002/diff/20001/account_fr.xml
File account_fr.xml (right):

http://codereview.tryton.org/3371002/diff/20001/account_fr.xml#newcode5572
account_fr.xml:5572: <field name="type"
ref="emprunts_dettes_financieres_diverses"/>
On 2014/02/14 00:19:24, ced wrote:
> But in OE, it is in "Créances : Autres"

No, it is in "Créances: Autres" only if the account shows a debit (listed in OE
as "'+:455:D'") but if you look at "Dettes : Emprunts et dettes financières
diverses" in OE you will see that all the accounts in 45* that show a credit are
listed there ("'+:45:C'").

Those accounts should never show a debit because it would mean the associated
has borrowed money from the company and this is forbidden by law. The standard
usage of this account is to hold debts that the company has towards associates
(in my case because my revenues are credited there until I transfer them to my
personal bank account, in other cases because some associate may inject money to
grow the cash flow).

http://codereview.tryton.org/3371002/diff/20001/account_fr.xml#newcode5580
account_fr.xml:5580: <field name="type"
ref="emprunts_dettes_financieres_diverses"/>
On 2014/02/14 00:19:24, ced wrote:
> idem

See above answer.

[ced, 2014-02-14 09:52:31]

LGTM