Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(29)

Issue 340511008: tryton-env: Add option to remove leading and trailing whitespaces from char

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 4 months ago by nicoe
Modified:
2 weeks, 3 days ago
Reviewers:
pokoli, ced, reviewbot
Visibility:
Public.

Description

issue7914 COLLABORATOR=cedric.krier@b2ck.com

Patch Set 1 #

Total comments: 8

Patch Set 2 : Put client logic in Field and set strip on True by default #

Total comments: 5

Patch Set 3 : Update to tip and adapt module code #

Total comments: 13

Patch Set 4 : Fix remarks and remove change in product module #

Total comments: 9

Patch Set 5 : Fix remarks #

Total comments: 12

Patch Set 6 : Strip translated, disable strip in some modules #

Patch Set 7 : Update to tip and fix isort #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -73 lines) Patch
M modules/account_fr_chorus/account.py View 1 2 3 4 5 3 chunks +5 lines, -5 lines 0 comments Download
M modules/account_payment_braintree/account.py View 1 2 3 4 5 6 5 chunks +13 lines, -11 lines 0 comments Download
M modules/account_payment_stripe/payment.py View 1 2 3 4 5 6 8 chunks +17 lines, -14 lines 0 comments Download
M modules/currency/currency.py View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M modules/currency_rs/currency.py View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M modules/marketing_automation/marketing_automation.py View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M modules/party/party.py View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M modules/stock_package_shipping/stock.py View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M modules/stock_package_shipping_dpd/carrier.py View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
M modules/stock_package_shipping_mygls/carrier.py View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M modules/stock_package_shipping_sendcloud/carrier.py View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M modules/timesheet/line.py View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M modules/web_shop/sale.py View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M modules/web_shop_shopify/web.py View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M modules/web_user/user.py View 1 2 3 4 5 2 chunks +4 lines, -3 lines 0 comments Download
M proteus/proteus/__init__.py View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M sao/src/model.js View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M tryton/tryton/gui/window/view_form/model/field.py View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M trytond/CHANGELOG View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M trytond/doc/ref/fields.rst View 1 2 3 4 5 2 chunks +6 lines, -1 line 0 comments Download
M trytond/trytond/ir/configuration.py View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M trytond/trytond/ir/lang.py View 1 2 3 4 5 1 chunk +10 lines, -8 lines 0 comments Download
M trytond/trytond/ir/sequence.py View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M trytond/trytond/ir/session.py View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M trytond/trytond/model/fields/char.py View 1 2 3 4 5 6 5 chunks +19 lines, -1 line 0 comments Download
M trytond/trytond/model/fields/text.py View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M trytond/trytond/model/modelsql.py View 1 2 3 4 5 2 chunks +4 lines, -2 lines 0 comments Download
M trytond/trytond/res/user.py View 1 2 3 4 5 5 chunks +5 lines, -5 lines 0 comments Download
M trytond/trytond/tests/field_char.py View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M trytond/trytond/tests/test_field_char.py View 1 2 3 4 5 2 chunks +76 lines, -0 lines 0 comments Download

Messages

Total messages: 32
nicoe
1 year, 4 months ago (2021-04-02 17:17:13 UTC) #1
nicoe
https://codereview.tryton.org/340511008/diff/345731002/trytond/trytond/backend/sqlite/database.py File trytond/trytond/backend/sqlite/database.py (right): https://codereview.tryton.org/340511008/diff/345731002/trytond/trytond/backend/sqlite/database.py#newcode235 trytond/trytond/backend/sqlite/database.py:235: def params(self): Should be in another change.
1 year, 4 months ago (2021-04-02 17:19:46 UTC) #2
reviewbot
flake8 OK URL: https://codereview.tryton.org/340511008
1 year, 4 months ago (2021-04-02 17:28:23 UTC) #3
ced
I think the strip should be deactivated only on sequence prefix and suffix, party name ...
1 year, 4 months ago (2021-04-05 14:10:24 UTC) #4
pokoli
1 year, 4 months ago (2021-04-06 12:04:50 UTC) #5
nicoe
1 year, 3 months ago (2021-05-11 17:35:05 UTC) #6
nicoe
https://codereview.tryton.org/340511008/diff/345731002/tryton/tryton/gui/window/view_form/view/form_gtk/char.py File tryton/tryton/gui/window/view_form/view/form_gtk/char.py (right): https://codereview.tryton.org/340511008/diff/345731002/tryton/tryton/gui/window/view_form/view/form_gtk/char.py#newcode91 tryton/tryton/gui/window/view_form/view/form_gtk/char.py:91: value = entry.get_text() or '' On 2021/04/05 14:10:24, ced ...
1 year, 3 months ago (2021-05-11 17:35:16 UTC) #7
nicoe
https://codereview.tryton.org/340511008/diff/361891002/trytond/trytond/model/fields/char.py File trytond/trytond/model/fields/char.py (right): https://codereview.tryton.org/340511008/diff/361891002/trytond/trytond/model/fields/char.py#newcode65 trytond/trytond/model/fields/char.py:65: if value is not None and self.strip: This code ...
1 year, 3 months ago (2021-05-11 17:38:52 UTC) #8
reviewbot
flake8 OK URL: https://codereview.tryton.org/340511008
1 year, 3 months ago (2021-05-11 17:44:51 UTC) #9
ced
https://codereview.tryton.org/340511008/diff/361891002/trytond/trytond/model/fields/char.py File trytond/trytond/model/fields/char.py (right): https://codereview.tryton.org/340511008/diff/361891002/trytond/trytond/model/fields/char.py#newcode65 trytond/trytond/model/fields/char.py:65: if value is not None and self.strip: On 2021/05/11 ...
1 year, 3 months ago (2021-05-11 22:45:42 UTC) #10
nicoe
https://codereview.tryton.org/340511008/diff/361891002/trytond/trytond/model/fields/char.py File trytond/trytond/model/fields/char.py (right): https://codereview.tryton.org/340511008/diff/361891002/trytond/trytond/model/fields/char.py#newcode65 trytond/trytond/model/fields/char.py:65: if value is not None and self.strip: On 2021/05/11 ...
1 year, 3 months ago (2021-05-12 07:51:00 UTC) #11
ced
https://codereview.tryton.org/340511008/diff/361891002/trytond/trytond/model/fields/char.py File trytond/trytond/model/fields/char.py (right): https://codereview.tryton.org/340511008/diff/361891002/trytond/trytond/model/fields/char.py#newcode65 trytond/trytond/model/fields/char.py:65: if value is not None and self.strip: On 2021/05/12 ...
1 year, 3 months ago (2021-05-12 08:14:45 UTC) #12
nicoe
https://codereview.tryton.org/340511008/diff/361891002/trytond/trytond/model/fields/char.py File trytond/trytond/model/fields/char.py (right): https://codereview.tryton.org/340511008/diff/361891002/trytond/trytond/model/fields/char.py#newcode65 trytond/trytond/model/fields/char.py:65: if value is not None and self.strip: On 2021/05/12 ...
1 year, 3 months ago (2021-05-12 09:40:18 UTC) #13
nicoe
1 year, 2 months ago (2021-06-10 10:34:16 UTC) #14
pokoli
https://codereview.tryton.org/340511008/diff/344291002/modules/product/product.py File modules/product/product.py (right): https://codereview.tryton.org/340511008/diff/344291002/modules/product/product.py#newcode339 modules/product/product.py:339: "Suffix Code", strip=False, Why deactivating on suffix_code? As the ...
1 year, 2 months ago (2021-06-10 10:41:11 UTC) #15
reviewbot
flake8 OK URL: https://codereview.tryton.org/340511008
1 year, 2 months ago (2021-06-10 11:02:40 UTC) #16
ced
https://codereview.tryton.org/340511008/diff/344291002/modules/product/product.py File modules/product/product.py (right): https://codereview.tryton.org/340511008/diff/344291002/modules/product/product.py#newcode339 modules/product/product.py:339: "Suffix Code", strip=False, On 2021/06/10 10:41:10, pokoli wrote: > ...
1 year, 2 months ago (2021-06-14 22:19:02 UTC) #17
nicoe
https://codereview.tryton.org/340511008/diff/344291002/modules/product/product.py File modules/product/product.py (right): https://codereview.tryton.org/340511008/diff/344291002/modules/product/product.py#newcode339 modules/product/product.py:339: "Suffix Code", strip=False, On 2021/06/14 22:19:02, ced wrote: > ...
1 year, 2 months ago (2021-06-15 16:50:17 UTC) #18
nicoe
1 year, 2 months ago (2021-06-15 16:50:44 UTC) #19
reviewbot
flake8 OK URL: https://codereview.tryton.org/340511008
1 year, 2 months ago (2021-06-15 17:08:38 UTC) #20
ced
https://codereview.tryton.org/340511008/diff/346481024/sao/src/model.js File sao/src/model.js (right): https://codereview.tryton.org/340511008/diff/346481024/sao/src/model.js#newcode1767 sao/src/model.js:1767: Sao.field.Char._super.get.call(this, record, value); must call set https://codereview.tryton.org/340511008/diff/346481024/tryton/tryton/gui/window/view_form/model/field.py File tryton/tryton/gui/window/view_form/model/field.py ...
1 year ago (2021-08-08 16:02:29 UTC) #21
nicoe
11 months, 2 weeks ago (2021-09-02 16:50:48 UTC) #22
nicoe
https://codereview.tryton.org/340511008/diff/346481024/sao/src/model.js File sao/src/model.js (right): https://codereview.tryton.org/340511008/diff/346481024/sao/src/model.js#newcode1767 sao/src/model.js:1767: Sao.field.Char._super.get.call(this, record, value); On 2021/08/08 16:02:29, ced wrote: > ...
11 months, 2 weeks ago (2021-09-02 16:50:52 UTC) #23
ced
https://codereview.tryton.org/340511008/diff/346481024/trytond/trytond/model/fields/char.py File trytond/trytond/model/fields/char.py (right): https://codereview.tryton.org/340511008/diff/346481024/trytond/trytond/model/fields/char.py#newcode29 trytond/trytond/model/fields/char.py:29: context=None, loading=None, autocomplete=None, strip=True): On 2021/09/02 16:50:52, nicoe wrote: ...
11 months, 2 weeks ago (2021-09-02 16:58:00 UTC) #24
reviewbot
flake8 OK URL: https://codereview.tryton.org/340511008
11 months, 2 weeks ago (2021-09-02 17:12:16 UTC) #25
ced
https://codereview.tryton.org/340511008/diff/353881002/sao/src/model.js File sao/src/model.js (right): https://codereview.tryton.org/340511008/diff/353881002/sao/src/model.js#newcode1764 sao/src/model.js:1764: set: function(record, value) { For me it should be ...
10 months, 4 weeks ago (2021-09-22 22:02:00 UTC) #26
ced
https://codereview.tryton.org/340511008/diff/353881002/trytond/trytond/model/fields/char.py File trytond/trytond/model/fields/char.py (right): https://codereview.tryton.org/340511008/diff/353881002/trytond/trytond/model/fields/char.py#newcode67 trytond/trytond/model/fields/char.py:67: if isinstance(value, (Query, Expression)): We should not support SQL ...
9 months, 3 weeks ago (2021-10-23 09:27:38 UTC) #27
ced
https://codereview.tryton.org/340511008/diff/353881002/sao/src/model.js File sao/src/model.js (right): https://codereview.tryton.org/340511008/diff/353881002/sao/src/model.js#newcode1764 sao/src/model.js:1764: set: function(record, value) { On 2021/09/22 22:01:59, ced wrote: ...
1 month, 2 weeks ago (2022-07-02 08:48:48 UTC) #28
ced
1 month, 2 weeks ago (2022-07-02 08:49:26 UTC) #29
reviewbot
ERROR: /tmp/reviewbot-zapzzhla/trytond/trytond/model/fields/char.py Imports are incorrectly sorted and/or formatted. URL: https://codereview.tryton.org/340511008
1 month, 2 weeks ago (2022-07-02 09:17:53 UTC) #30
ced
2 weeks, 3 days ago (2022-07-30 09:21:11 UTC) #31
reviewbot
2 weeks, 3 days ago (2022-07-30 09:44:16 UTC) #32
patch is not applicable
URL: https://codereview.tryton.org/340511008
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted