tryton-env: Add option to remove leading and trailing whitespaces from char

issue7914

COLLABORATOR=cedric.krier@b2ck.com

[nicoe, 2021-04-02 17:19:46]

https://codereview.tryton.org/340511008/diff/345731002/trytond/trytond/backen...
File trytond/trytond/backend/sqlite/database.py (right):

https://codereview.tryton.org/340511008/diff/345731002/trytond/trytond/backen...
trytond/trytond/backend/sqlite/database.py:235: def params(self):
Should be in another change.

[reviewbot, 2021-04-02 17:28:23]

flake8 OK
URL: https://codereview.tryton.org/340511008

[ced, 2021-04-05 14:10:24]

I think the strip should be deactivated only on sequence prefix and suffix,
party name and product suffix.

https://codereview.tryton.org/340511008/diff/345731002/sao/src/view/form.js
File sao/src/view/form.js (right):

https://codereview.tryton.org/340511008/diff/345731002/sao/src/view/form.js#n...
sao/src/view/form.js:1540: return this.input.val();
I would prefer to avoid duplicate code and returns

https://codereview.tryton.org/340511008/diff/345731002/tryton/tryton/gui/wind...
File tryton/tryton/gui/window/view_form/view/form_gtk/char.py (right):

https://codereview.tryton.org/340511008/diff/345731002/tryton/tryton/gui/wind...
tryton/tryton/gui/window/view_form/view/form_gtk/char.py:91: value =
entry.get_text() or ''
Should it not be done here?

Indeed I'm wondering if it should not be managed on the field instead of the
widget.

https://codereview.tryton.org/340511008/diff/345731002/trytond/trytond/model/...
File trytond/trytond/model/fields/char.py (right):

https://codereview.tryton.org/340511008/diff/345731002/trytond/trytond/model/...
trytond/trytond/model/fields/char.py:26: def __init__(self, string='',
size=None, strip=False, help='',
It is safer to add new options at the end.

https://codereview.tryton.org/340511008/diff/345731002/trytond/trytond/model/...
trytond/trytond/model/fields/char.py:26: def __init__(self, string='',
size=None, strip=False, help='',
For me it should be activated by default:
https://bugs.tryton.org/issue7914#msg45266

[nicoe, 2021-05-11 17:35:16]

https://codereview.tryton.org/340511008/diff/345731002/tryton/tryton/gui/wind...
File tryton/tryton/gui/window/view_form/view/form_gtk/char.py (right):

https://codereview.tryton.org/340511008/diff/345731002/tryton/tryton/gui/wind...
tryton/tryton/gui/window/view_form/view/form_gtk/char.py:91: value =
entry.get_text() or ''
On 2021/04/05 14:10:24, ced wrote:
> Should it not be done here?
> 
> Indeed I'm wondering if it should not be managed on the field instead of the
> widget.

Done.

https://codereview.tryton.org/340511008/diff/345731002/trytond/trytond/model/...
File trytond/trytond/model/fields/char.py (right):

https://codereview.tryton.org/340511008/diff/345731002/trytond/trytond/model/...
trytond/trytond/model/fields/char.py:26: def __init__(self, string='',
size=None, strip=False, help='',
On 2021/04/05 14:10:24, ced wrote:
> For me it should be activated by default:
> https://bugs.tryton.org/issue7914#msg45266

Done.

https://codereview.tryton.org/340511008/diff/345731002/trytond/trytond/model/...
trytond/trytond/model/fields/char.py:26: def __init__(self, string='',
size=None, strip=False, help='',
On 2021/04/05 14:10:24, ced wrote:
> It is safer to add new options at the end.

Done.

[nicoe, 2021-05-11 17:38:52]

https://codereview.tryton.org/340511008/diff/361891002/trytond/trytond/model/...
File trytond/trytond/model/fields/char.py (right):

https://codereview.tryton.org/340511008/diff/361891002/trytond/trytond/model/...
trytond/trytond/model/fields/char.py:65: if value is not None and self.strip:
This code is duplicated because we're using the same tests for Char and Char
with translations. In the latter case we set a Literal sql value to a translated
char which will call __set__.

According to me it's a bug. But I don't know if we should: (a) change the test
because it's a behaviour that we don't want to support but it's not worth adding
some code for this, (b) completely forbid this behaviour (setting an SQL
Expression) and raise an exception here in this case

[reviewbot, 2021-05-11 17:44:51]

flake8 OK
URL: https://codereview.tryton.org/340511008

[ced, 2021-05-11 22:45:42]

https://codereview.tryton.org/340511008/diff/361891002/trytond/trytond/model/...
File trytond/trytond/model/fields/char.py (right):

https://codereview.tryton.org/340511008/diff/361891002/trytond/trytond/model/...
trytond/trytond/model/fields/char.py:65: if value is not None and self.strip:
On 2021/05/11 17:38:52, nicoe wrote:
> This code is duplicated because we're using the same tests for Char and Char
> with translations. In the latter case we set a Literal sql value to a
translated
> char which will call __set__.

I do not see which tests you are talking about.

> According to me it's a bug. But I don't know if we should: (a) change the test
> because it's a behaviour that we don't want to support but it's not worth
adding
> some code for this, (b) completely forbid this behaviour (setting an SQL
> Expression) and raise an exception here in this case

For me it is still good to allow using SQL expression for lower CRUD API but for
ActiveRecord usage it does not really make sense.

[nicoe, 2021-05-12 07:51:00]

https://codereview.tryton.org/340511008/diff/361891002/trytond/trytond/model/...
File trytond/trytond/model/fields/char.py (right):

https://codereview.tryton.org/340511008/diff/361891002/trytond/trytond/model/...
trytond/trytond/model/fields/char.py:65: if value is not None and self.strip:
On 2021/05/11 22:45:42, ced wrote:
> On 2021/05/11 17:38:52, nicoe wrote:
> > This code is duplicated because we're using the same tests for Char and Char
> > with translations. In the latter case we set a Literal sql value to a
> translated
> > char which will call __set__.
> 
> I do not see which tests you are talking about.

I wasn't very clear indeed.

test_field_char.py defines a Mixin for testing char fields. This mixin is used
by both the vanilla char field and the char field where translated=True.

In this mixin we test that we can set the value by using a python-sql
Expression.

The issue is that when this test is executed for the translated char field, a
call to set_ids is made which will make something like `translation.value =
value` but value is an Expression. And I don't think it should happen.

I should probably make a bug because the issue is there anyway.
 
> > According to me it's a bug. But I don't know if we should: (a) change the
test
> > because it's a behaviour that we don't want to support but it's not worth
> adding
> > some code for this, (b) completely forbid this behaviour (setting an SQL
> > Expression) and raise an exception here in this case
> 
> For me it is still good to allow using SQL expression for lower CRUD API but
for
> ActiveRecord usage it does not really make sense.

[ced, 2021-05-12 08:14:45]

https://codereview.tryton.org/340511008/diff/361891002/trytond/trytond/model/...
File trytond/trytond/model/fields/char.py (right):

https://codereview.tryton.org/340511008/diff/361891002/trytond/trytond/model/...
trytond/trytond/model/fields/char.py:65: if value is not None and self.strip:
On 2021/05/12 07:51:00, nicoe wrote:
> On 2021/05/11 22:45:42, ced wrote:
> > On 2021/05/11 17:38:52, nicoe wrote:
> > > This code is duplicated because we're using the same tests for Char and
Char
> > > with translations. In the latter case we set a Literal sql value to a
> > translated
> > > char which will call __set__.
> > 
> > I do not see which tests you are talking about.
> 
> I wasn't very clear indeed.
> 
> test_field_char.py defines a Mixin for testing char fields. This mixin is used
> by both the vanilla char field and the char field where translated=True.
> 
> In this mixin we test that we can set the value by using a python-sql
> Expression.

I can not find where this happens?
I only see the case of .create with a SQL expression.

[nicoe, 2021-05-12 09:40:18]

https://codereview.tryton.org/340511008/diff/361891002/trytond/trytond/model/...
File trytond/trytond/model/fields/char.py (right):

https://codereview.tryton.org/340511008/diff/361891002/trytond/trytond/model/...
trytond/trytond/model/fields/char.py:65: if value is not None and self.strip:
On 2021/05/12 08:14:45, ced wrote:
> On 2021/05/12 07:51:00, nicoe wrote:
> > On 2021/05/11 22:45:42, ced wrote:
> > > On 2021/05/11 17:38:52, nicoe wrote:
> > > > This code is duplicated because we're using the same tests for Char and
> Char
> > > > with translations. In the latter case we set a Literal sql value to a
> > > translated
> > > > char which will call __set__.
> > > 
> > > I do not see which tests you are talking about.
> > 
> > I wasn't very clear indeed.
> > 
> > test_field_char.py defines a Mixin for testing char fields. This mixin is
used
> > by both the vanilla char field and the char field where translated=True.
> > 
> > In this mixin we test that we can set the value by using a python-sql
> > Expression.
> 
> I can not find where this happens?
> I only see the case of .create with a SQL expression.

I made an issue it will be easier to discuss the issue :
https://bugs.tryton.org/issue10413

[pokoli, 2021-06-10 10:41:11]

https://codereview.tryton.org/340511008/diff/344291002/modules/product/produc...
File modules/product/product.py (right):

https://codereview.tryton.org/340511008/diff/344291002/modules/product/produc...
modules/product/product.py:339: "Suffix Code", strip=False,
Why deactivating on suffix_code? 

As the code is composed by prefix and suffix I'm wondering if we should keep the
same behaviour on three fields.

https://codereview.tryton.org/340511008/diff/344291002/trytond/trytond/tests/...
File trytond/trytond/tests/test_field_char.py (right):

https://codereview.tryton.org/340511008/diff/344291002/trytond/trytond/tests/...
trytond/trytond/tests/test_field_char.py:533: def test_set_strip(self):
Isn't this redundant with create/rite?

[reviewbot, 2021-06-10 11:02:40]

flake8 OK
URL: https://codereview.tryton.org/340511008

[ced, 2021-06-14 22:19:02]

https://codereview.tryton.org/340511008/diff/344291002/modules/product/produc...
File modules/product/product.py (right):

https://codereview.tryton.org/340511008/diff/344291002/modules/product/produc...
modules/product/product.py:339: "Suffix Code", strip=False,
On 2021/06/10 10:41:10, pokoli wrote:
> Why deactivating on suffix_code? 
> 
> As the code is composed by prefix and suffix I'm wondering if we should keep
the
> same behaviour on three fields. 

Indeed I think we should strip template code and product suffix code at least
they must have the same strip behavior. But not strip any of the code does not
help against trailing space here which is really something we want.

https://codereview.tryton.org/340511008/diff/344291002/trytond/CHANGELOG
File trytond/CHANGELOG (right):

https://codereview.tryton.org/340511008/diff/344291002/trytond/CHANGELOG#newc...
trytond/CHANGELOG:1: * Add option to strip leading and trailing whitespace from
fields.Char
I think it could be simply:

Add strip option to Char field

https://codereview.tryton.org/340511008/diff/344291002/trytond/doc/ref/models...
File trytond/doc/ref/models/fields.rst (right):

https://codereview.tryton.org/340511008/diff/344291002/trytond/doc/ref/models...
trytond/doc/ref/models/fields.rst:289: kept. Defaults to true.
It is strange to describe the `False` value that does nothing instead of what
the `True` value does.

https://codereview.tryton.org/340511008/diff/344291002/trytond/trytond/backen...
File trytond/trytond/backend/sqlite/database.py (right):

https://codereview.tryton.org/340511008/diff/344291002/trytond/trytond/backen...
trytond/trytond/backend/sqlite/database.py:244: return params
Should be in another patch to be backported.

https://codereview.tryton.org/340511008/diff/344291002/trytond/trytond/tests/...
File trytond/trytond/tests/test_field_char.py (right):

https://codereview.tryton.org/340511008/diff/344291002/trytond/trytond/tests/...
trytond/trytond/tests/test_field_char.py:533: def test_set_strip(self):
On 2021/06/10 10:41:10, pokoli wrote:
> Isn't this redundant with create/rite?

No because it is testing __set__ without saving.

https://codereview.tryton.org/340511008/diff/344291002/trytond/trytond/tests/...
trytond/trytond/tests/test_field_char.py:544: char.save()
I think the following is not needed as it just test the create.

[nicoe, 2021-06-15 16:50:17]

https://codereview.tryton.org/340511008/diff/344291002/modules/product/produc...
File modules/product/product.py (right):

https://codereview.tryton.org/340511008/diff/344291002/modules/product/produc...
modules/product/product.py:339: "Suffix Code", strip=False,
On 2021/06/14 22:19:02, ced wrote:
> On 2021/06/10 10:41:10, pokoli wrote:
> > Why deactivating on suffix_code? 
> > 
> > As the code is composed by prefix and suffix I'm wondering if we should keep
> the
> > same behaviour on three fields. 
> 
> Indeed I think we should strip template code and product suffix code at least
> they must have the same strip behavior. But not strip any of the code does not
> help against trailing space here which is really something we want.

Done.

https://codereview.tryton.org/340511008/diff/344291002/trytond/CHANGELOG
File trytond/CHANGELOG (right):

https://codereview.tryton.org/340511008/diff/344291002/trytond/CHANGELOG#newc...
trytond/CHANGELOG:1: * Add option to strip leading and trailing whitespace from
fields.Char
On 2021/06/14 22:19:02, ced wrote:
> I think it could be simply:
> 
> Add strip option to Char field

Done.

https://codereview.tryton.org/340511008/diff/344291002/trytond/doc/ref/models...
File trytond/doc/ref/models/fields.rst (right):

https://codereview.tryton.org/340511008/diff/344291002/trytond/doc/ref/models...
trytond/doc/ref/models/fields.rst:289: kept. Defaults to true.
On 2021/06/14 22:19:02, ced wrote:
> It is strange to describe the `False` value that does nothing instead of what
> the `True` value does.

Done.

https://codereview.tryton.org/340511008/diff/344291002/trytond/trytond/backen...
File trytond/trytond/backend/sqlite/database.py (right):

https://codereview.tryton.org/340511008/diff/344291002/trytond/trytond/backen...
trytond/trytond/backend/sqlite/database.py:244: return params
On 2021/06/14 22:19:02, ced wrote:
> Should be in another patch to be backported.

https://bugs.tryton.org/issue10510

https://codereview.tryton.org/340511008/diff/344291002/trytond/trytond/tests/...
File trytond/trytond/tests/test_field_char.py (right):

https://codereview.tryton.org/340511008/diff/344291002/trytond/trytond/tests/...
trytond/trytond/tests/test_field_char.py:544: char.save()
On 2021/06/14 22:19:02, ced wrote:
> I think the following is not needed as it just test the create.

Done.

[reviewbot, 2021-06-15 17:08:38]

flake8 OK
URL: https://codereview.tryton.org/340511008

[ced, 2021-08-08 16:02:29]

https://codereview.tryton.org/340511008/diff/346481024/sao/src/model.js
File sao/src/model.js (right):

https://codereview.tryton.org/340511008/diff/346481024/sao/src/model.js#newco...
sao/src/model.js:1767: Sao.field.Char._super.get.call(this, record, value);
must call set

https://codereview.tryton.org/340511008/diff/346481024/tryton/tryton/gui/wind...
File tryton/tryton/gui/window/view_form/model/field.py (right):

https://codereview.tryton.org/340511008/diff/346481024/tryton/tryton/gui/wind...
tryton/tryton/gui/window/view_form/model/field.py:209: record, value.strip() if
self.attrs.get('strip') else value)
It is a little bit hard to read to make the strip inside the call.
I think it does not hurt to have:

if self.attrs.get('strip'):
   value = value.strip()
super()

https://codereview.tryton.org/340511008/diff/346481024/trytond/trytond/backen...
File trytond/trytond/backend/sqlite/database.py (right):

https://codereview.tryton.org/340511008/diff/346481024/trytond/trytond/backen...
trytond/trytond/backend/sqlite/database.py:239: if isinstance(self.string, str):
I think it is better to test the other way as the other option is to call params
so we must check that the instance has params:

if isinstance(self.string, Expression):
   params = list(self.string.params)
else:
   params = [self.string]

https://codereview.tryton.org/340511008/diff/346481024/trytond/trytond/model/...
File trytond/trytond/model/fields/char.py (right):

https://codereview.tryton.org/340511008/diff/346481024/trytond/trytond/model/...
trytond/trytond/model/fields/char.py:29: context=None, loading=None,
autocomplete=None, strip=True):
I'm not sure that Text should be stripped.

[nicoe, 2021-09-02 16:50:52]

https://codereview.tryton.org/340511008/diff/346481024/sao/src/model.js
File sao/src/model.js (right):

https://codereview.tryton.org/340511008/diff/346481024/sao/src/model.js#newco...
sao/src/model.js:1767: Sao.field.Char._super.get.call(this, record, value);
On 2021/08/08 16:02:29, ced wrote:
> must call set

Done.

https://codereview.tryton.org/340511008/diff/346481024/tryton/tryton/gui/wind...
File tryton/tryton/gui/window/view_form/model/field.py (right):

https://codereview.tryton.org/340511008/diff/346481024/tryton/tryton/gui/wind...
tryton/tryton/gui/window/view_form/model/field.py:209: record, value.strip() if
self.attrs.get('strip') else value)
On 2021/08/08 16:02:29, ced wrote:
> It is a little bit hard to read to make the strip inside the call.
> I think it does not hurt to have:
> 
> if self.attrs.get('strip'):
>    value = value.strip()
> super()

Done.

https://codereview.tryton.org/340511008/diff/346481024/trytond/trytond/backen...
File trytond/trytond/backend/sqlite/database.py (right):

https://codereview.tryton.org/340511008/diff/346481024/trytond/trytond/backen...
trytond/trytond/backend/sqlite/database.py:239: if isinstance(self.string, str):
On 2021/08/08 16:02:29, ced wrote:
> I think it is better to test the other way as the other option is to call
params
> so we must check that the instance has params:
> 
> if isinstance(self.string, Expression):
>    params = list(self.string.params)
> else:
>    params = [self.string]

Done.

https://codereview.tryton.org/340511008/diff/346481024/trytond/trytond/model/...
File trytond/trytond/model/fields/char.py (right):

https://codereview.tryton.org/340511008/diff/346481024/trytond/trytond/model/...
trytond/trytond/model/fields/char.py:29: context=None, loading=None,
autocomplete=None, strip=True):
On 2021/08/08 16:02:29, ced wrote:
> I'm not sure that Text should be stripped.

I am conflicted because it's not usual to start or end a Text with spaces but
there might be some valid usage.

But it's the same problem for Char fields in the end.

[ced, 2021-09-02 16:58:00]

https://codereview.tryton.org/340511008/diff/346481024/trytond/trytond/model/...
File trytond/trytond/model/fields/char.py (right):

https://codereview.tryton.org/340511008/diff/346481024/trytond/trytond/model/...
trytond/trytond/model/fields/char.py:29: context=None, loading=None,
autocomplete=None, strip=True):
On 2021/09/02 16:50:52, nicoe wrote:
> On 2021/08/08 16:02:29, ced wrote:
> > I'm not sure that Text should be stripped.
> 
> I am conflicted because it's not usual to start or end a Text with spaces but
> there might be some valid usage.
> 
> But it's the same problem for Char fields in the end.

For me it should not be stripped because the user format the text and it is
visible if spaces are added.
Also I do not see why we would strip the beginning of the first line and the end
of the last one but the others.
So for me the feature will not work correctly on Text so it should not be
implemented.

[reviewbot, 2021-09-02 17:12:16]

flake8 OK
URL: https://codereview.tryton.org/340511008

[ced, 2021-09-22 22:02:00]

https://codereview.tryton.org/340511008/diff/353881002/sao/src/model.js
File sao/src/model.js (right):

https://codereview.tryton.org/340511008/diff/353881002/sao/src/model.js#newco...
sao/src/model.js:1764: set: function(record, value) {
For me it should be done in set_client

https://codereview.tryton.org/340511008/diff/353881002/tryton/tryton/gui/wind...
File tryton/tryton/gui/window/view_form/model/field.py (right):

https://codereview.tryton.org/340511008/diff/353881002/tryton/tryton/gui/wind...
tryton/tryton/gui/window/view_form/model/field.py:207: def set(self, record,
value):
Only on set_client

https://codereview.tryton.org/340511008/diff/353881002/trytond/doc/ref/models...
File trytond/doc/ref/models/fields.rst (right):

https://codereview.tryton.org/340511008/diff/353881002/trytond/doc/ref/models...
trytond/doc/ref/models/fields.rst:288: When True, leading and trailing
whitespaces characters are removed from the
When true, leading and ...

https://codereview.tryton.org/340511008/diff/353881002/trytond/doc/ref/models...
trytond/doc/ref/models/fields.rst:289: value. They are kept otherwise. Defaults
to True.
``True``

https://codereview.tryton.org/340511008/diff/353881002/trytond/trytond/model/...
File trytond/trytond/model/fields/char.py (right):

https://codereview.tryton.org/340511008/diff/353881002/trytond/trytond/model/...
trytond/trytond/model/fields/char.py:30: context=None, loading=None,
autocomplete=None, strip=True):
For me strip should be False by default for Text.

[ced, 2021-10-23 09:27:38]

https://codereview.tryton.org/340511008/diff/353881002/trytond/trytond/model/...
File trytond/trytond/model/fields/char.py (right):

https://codereview.tryton.org/340511008/diff/353881002/trytond/trytond/model/...
trytond/trytond/model/fields/char.py:67: if isinstance(value, (Query,
Expression)):
We should not support SQL expression when setting attribute.

[ced, 2022-07-02 08:48:48]

https://codereview.tryton.org/340511008/diff/353881002/sao/src/model.js
File sao/src/model.js (right):

https://codereview.tryton.org/340511008/diff/353881002/sao/src/model.js#newco...
sao/src/model.js:1764: set: function(record, value) {
On 2021/09/22 22:01:59, ced wrote:
> For me it should be done in set_client

Indeed it must be done in set to avoid false detection of change.

https://codereview.tryton.org/340511008/diff/353881002/tryton/tryton/gui/wind...
File tryton/tryton/gui/window/view_form/model/field.py (right):

https://codereview.tryton.org/340511008/diff/353881002/tryton/tryton/gui/wind...
tryton/tryton/gui/window/view_form/model/field.py:207: def set(self, record,
value):
On 2021/09/22 22:01:59, ced wrote:
> Only on set_client

Indeed we must do it in set to avoid detecting modification on unmodified field
with trailing space.

https://codereview.tryton.org/340511008/diff/353881002/trytond/doc/ref/models...
File trytond/doc/ref/models/fields.rst (right):

https://codereview.tryton.org/340511008/diff/353881002/trytond/doc/ref/models...
trytond/doc/ref/models/fields.rst:288: When True, leading and trailing
whitespaces characters are removed from the
On 2021/09/22 22:01:59, ced wrote:
> When true, leading and ...

Done.

https://codereview.tryton.org/340511008/diff/353881002/trytond/doc/ref/models...
trytond/doc/ref/models/fields.rst:289: value. They are kept otherwise. Defaults
to True.
On 2021/09/22 22:01:59, ced wrote:
> ``True``

Done.

https://codereview.tryton.org/340511008/diff/353881002/trytond/trytond/model/...
File trytond/trytond/model/fields/char.py (right):

https://codereview.tryton.org/340511008/diff/353881002/trytond/trytond/model/...
trytond/trytond/model/fields/char.py:30: context=None, loading=None,
autocomplete=None, strip=True):
On 2021/09/22 22:01:59, ced wrote:
> For me strip should be False by default for Text.

Done.

https://codereview.tryton.org/340511008/diff/353881002/trytond/trytond/model/...
trytond/trytond/model/fields/char.py:67: if isinstance(value, (Query,
Expression)):
On 2021/10/23 09:27:38, ced wrote:
> We should not support SQL expression when setting attribute.

Done.

[reviewbot, 2022-07-02 09:17:53]

ERROR: /tmp/reviewbot-zapzzhla/trytond/trytond/model/fields/char.py Imports are
incorrectly sorted and/or formatted.

URL: https://codereview.tryton.org/340511008

[reviewbot, 2022-07-30 09:44:16]

patch is not applicable
URL: https://codereview.tryton.org/340511008

[reviewbot, 2022-09-09 22:09:30]

patch is not applicable
URL: https://codereview.tryton.org/340511008

[reviewbot, 2022-09-09 22:45:17]

patch is not applicable
URL: https://codereview.tryton.org/340511008

[pokoli, 2022-09-12 10:06:24]

https://codereview.tryton.org/340511008/diff/441411003/proteus/proteus/__init...
File proteus/proteus/__init__.py (right):

https://codereview.tryton.org/340511008/diff/441411003/proteus/proteus/__init...
proteus/proteus/__init__.py:148: if self.definition.get('strip') and value:
missing leading and trailing options

[reviewbot, 2022-09-12 10:44:45]

patch is not applicable
URL: https://codereview.tryton.org/340511008

[pokoli, 2022-09-12 12:56:12]

LGTM

[rietveld-bot_tryton.org, 2022-09-19 19:26:30]

New changeset efb5fe29e90d by Cédric Krier in branch 'default':
Add option to remove leading and trailing white spaces from char
https://hg.tryton.org/modules/account_fr_chorus/rev/efb5fe29e90d

[rietveld-bot_tryton.org, 2022-09-19 19:26:34]

New changeset 4a92175f38b0 by Cédric Krier in branch 'default':
Add option to remove leading and trailing white spaces from char
https://hg.tryton.org/modules/account_payment_braintree/rev/4a92175f38b0

[rietveld-bot_tryton.org, 2022-09-19 19:26:41]

New changeset 2348d81854fc by Cédric Krier in branch 'default':
Add option to remove leading and trailing white spaces from char
https://hg.tryton.org/modules/account_payment_stripe/rev/2348d81854fc

[rietveld-bot_tryton.org, 2022-09-19 19:26:46]

New changeset c3c7cf3e6ba5 by Cédric Krier in branch 'default':
Add option to remove leading and trailing white spaces from char
https://hg.tryton.org/modules/currency/rev/c3c7cf3e6ba5

[rietveld-bot_tryton.org, 2022-09-19 19:26:55]

New changeset 9241b14e3383 by Cédric Krier in branch 'default':
Add option to remove leading and trailing white spaces from char
https://hg.tryton.org/modules/currency_rs/rev/9241b14e3383

[rietveld-bot_tryton.org, 2022-09-19 19:27:03]

New changeset 695f23391e69 by Cédric Krier in branch 'default':
Add option to remove leading and trailing white spaces from char
https://hg.tryton.org/modules/marketing_automation/rev/695f23391e69

[rietveld-bot_tryton.org, 2022-09-19 19:27:14]

New changeset 288942e9f597 by Cédric Krier in branch 'default':
Add option to remove leading and trailing white spaces from char
https://hg.tryton.org/modules/party/rev/288942e9f597

[rietveld-bot_tryton.org, 2022-09-19 19:27:22]

New changeset 78fbe23795c1 by Cédric Krier in branch 'default':
Add option to remove leading and trailing white spaces from char
https://hg.tryton.org/modules/product/rev/78fbe23795c1

[rietveld-bot_tryton.org, 2022-09-19 19:27:29]

New changeset f7693a143c69 by Cédric Krier in branch 'default':
Add option to remove leading and trailing white spaces from char
https://hg.tryton.org/modules/stock_package_shipping/rev/f7693a143c69

[rietveld-bot_tryton.org, 2022-09-19 19:27:38]

New changeset 8a7972c1e76e by Cédric Krier in branch 'default':
Add option to remove leading and trailing white spaces from char
https://hg.tryton.org/modules/stock_package_shipping_dpd/rev/8a7972c1e76e

[rietveld-bot_tryton.org, 2022-09-19 19:27:42]

New changeset bb898653d808 by Cédric Krier in branch 'default':
Add option to remove leading and trailing white spaces from char
https://hg.tryton.org/modules/stock_package_shipping_mygls/rev/bb898653d808

[rietveld-bot_tryton.org, 2022-09-19 19:27:45]

New changeset 935edca4f028 by Cédric Krier in branch 'default':
Add option to remove leading and trailing white spaces from char
https://hg.tryton.org/modules/stock_package_shipping_sendcloud/rev/935edca4f028

[rietveld-bot_tryton.org, 2022-09-19 19:27:50]

New changeset 27201d2a76ab by Cédric Krier in branch 'default':
Add option to remove leading and trailing white spaces from char
https://hg.tryton.org/modules/timesheet/rev/27201d2a76ab

[rietveld-bot_tryton.org, 2022-09-19 19:27:54]

New changeset 4991d18e04cc by Cédric Krier in branch 'default':
Add option to remove leading and trailing white spaces from char
https://hg.tryton.org/modules/web_shop/rev/4991d18e04cc

[rietveld-bot_tryton.org, 2022-09-19 19:27:57]

New changeset 7817e8c48d79 by Cédric Krier in branch 'default':
Add option to remove leading and trailing white spaces from char
https://hg.tryton.org/modules/web_shop_shopify/rev/7817e8c48d79

[rietveld-bot_tryton.org, 2022-09-19 19:28:02]

New changeset c2437a65b036 by Cédric Krier in branch 'default':
Add option to remove leading and trailing white spaces from char
https://hg.tryton.org/modules/web_user/rev/c2437a65b036

[rietveld-bot_tryton.org, 2022-09-19 19:28:06]

New changeset e236e6ca4f2e by Cédric Krier in branch 'default':
Add option to remove leading and trailing white spaces from char
https://hg.tryton.org/proteus/rev/e236e6ca4f2e

[rietveld-bot_tryton.org, 2022-09-19 19:28:10]

New changeset 5418e6544383 by Cédric Krier in branch 'default':
Add option to remove leading and trailing white spaces from char
https://hg.tryton.org/sao/rev/5418e6544383

[rietveld-bot_tryton.org, 2022-09-19 19:28:12]

New changeset 75e45071896f by Cédric Krier in branch 'default':
Add option to remove leading and trailing white spaces from char
https://hg.tryton.org/tryton/rev/75e45071896f

[rietveld-bot_tryton.org, 2022-09-19 19:28:16]

New changeset e19329d25a6f by Cédric Krier in branch 'default':
Add option to remove leading and trailing white spaces from char
https://hg.tryton.org/trytond/rev/e19329d25a6f

[rietveld-bot_tryton.org, 2022-09-19 19:28:22]

New changeset 9542c372258d by Cédric Krier in branch 'default':
Add option to remove leading and trailing white spaces from char
https://hg.tryton.org/tryton-env/rev/9542c372258d