Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(423)

Issue 341741060: tryton-env: Reset less often the user sessions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 10 months ago by nicoe
Modified:
4 months ago
Reviewers:
pokoli, rietveld-bot, ced, dave, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 18

Patch Set 2 : Fix remarks #

Total comments: 17

Patch Set 3 : Fix remarks #

Total comments: 7

Patch Set 4 : Fix remarks #

Total comments: 3

Patch Set 5 : Do not reset when last_reset is None #

Patch Set 6 : Restore previous behaviour #

Total comments: 2

Patch Set 7 : Resetting session to it's write_date #

Total comments: 5

Patch Set 8 : Update to tip and fix remarks #

Total comments: 2

Patch Set 9 : Fix remarks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -13 lines) Patch
M trytond/CHANGELOG View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M trytond/trytond/ir/session.py View 1 2 3 4 5 6 7 8 5 chunks +29 lines, -13 lines 0 comments Download

Messages

Total messages: 51
nicoe
1 year, 10 months ago (2021-03-16 10:13:48 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/341741060
1 year, 10 months ago (2021-03-16 10:17:09 UTC) #2
pokoli
I think we need a changelog entry. I think it should talk about caching the ...
1 year, 10 months ago (2021-03-16 13:55:45 UTC) #3
ced
I agree with pokoli, there should be a changelog entry. The commit description could include ...
1 year, 10 months ago (2021-03-25 21:56:02 UTC) #4
nicoe
https://codereview.tryton.org/341741060/diff/341761006/trytond/trytond/ir/session.py File trytond/trytond/ir/session.py (right): https://codereview.tryton.org/341741060/diff/341761006/trytond/trytond/ir/session.py#newcode89 trytond/trytond/ir/session.py:89: session.write_date or datetime.datetime.min) On 2021/03/25 21:56:01, ced wrote: > ...
1 year, 10 months ago (2021-03-31 10:09:43 UTC) #5
nicoe
1 year, 10 months ago (2021-03-31 10:13:01 UTC) #6
ced
https://codereview.tryton.org/341741060/diff/341761006/trytond/trytond/ir/session.py File trytond/trytond/ir/session.py (right): https://codereview.tryton.org/341741060/diff/341761006/trytond/trytond/ir/session.py#newcode89 trytond/trytond/ir/session.py:89: session.write_date or datetime.datetime.min) On 2021/03/31 10:09:43, nicoe wrote: > ...
1 year, 10 months ago (2021-03-31 10:19:33 UTC) #7
reviewbot
flake8 OK URL: https://codereview.tryton.org/341741060
1 year, 10 months ago (2021-03-31 10:25:22 UTC) #8
nicoe
https://codereview.tryton.org/341741060/diff/341761006/trytond/trytond/ir/session.py File trytond/trytond/ir/session.py (right): https://codereview.tryton.org/341741060/diff/341761006/trytond/trytond/ir/session.py#newcode89 trytond/trytond/ir/session.py:89: session.write_date or datetime.datetime.min) On 2021/03/31 10:19:33, ced wrote: > ...
1 year, 10 months ago (2021-03-31 12:04:54 UTC) #9
ced
https://codereview.tryton.org/341741060/diff/341761006/trytond/trytond/ir/session.py File trytond/trytond/ir/session.py (right): https://codereview.tryton.org/341741060/diff/341761006/trytond/trytond/ir/session.py#newcode89 trytond/trytond/ir/session.py:89: session.write_date or datetime.datetime.min) On 2021/03/31 12:04:54, nicoe wrote: > ...
1 year, 10 months ago (2021-03-31 12:20:48 UTC) #10
nicoe
https://codereview.tryton.org/341741060/diff/341761006/trytond/trytond/ir/session.py File trytond/trytond/ir/session.py (right): https://codereview.tryton.org/341741060/diff/341761006/trytond/trytond/ir/session.py#newcode89 trytond/trytond/ir/session.py:89: session.write_date or datetime.datetime.min) On 2021/03/31 12:20:47, ced wrote: > ...
1 year, 10 months ago (2021-03-31 17:58:45 UTC) #11
ced
https://codereview.tryton.org/341741060/diff/341761006/trytond/trytond/ir/session.py File trytond/trytond/ir/session.py (right): https://codereview.tryton.org/341741060/diff/341761006/trytond/trytond/ir/session.py#newcode89 trytond/trytond/ir/session.py:89: session.write_date or datetime.datetime.min) On 2021/03/31 17:58:45, nicoe wrote: > ...
1 year, 10 months ago (2021-03-31 18:09:55 UTC) #12
ced
https://codereview.tryton.org/341741060/diff/340491002/trytond/trytond/ir/session.py File trytond/trytond/ir/session.py (right): https://codereview.tryton.org/341741060/diff/340491002/trytond/trytond/ir/session.py#newcode26 trytond/trytond/ir/session.py:26: _session_timeout_cache = Cache('ir_session.keys', context=False) The Cache name and the ...
1 year, 10 months ago (2021-04-04 17:32:27 UTC) #13
nicoe
https://codereview.tryton.org/341741060/diff/340491002/trytond/trytond/ir/session.py File trytond/trytond/ir/session.py (right): https://codereview.tryton.org/341741060/diff/340491002/trytond/trytond/ir/session.py#newcode26 trytond/trytond/ir/session.py:26: _session_timeout_cache = Cache('ir_session.keys', context=False) On 2021/04/04 17:32:26, ced wrote: ...
1 year, 9 months ago (2021-04-09 12:51:58 UTC) #14
nicoe
1 year, 9 months ago (2021-04-09 12:52:56 UTC) #15
ced
https://codereview.tryton.org/341741060/diff/340491002/trytond/trytond/ir/session.py File trytond/trytond/ir/session.py (right): https://codereview.tryton.org/341741060/diff/340491002/trytond/trytond/ir/session.py#newcode126 trytond/trytond/ir/session.py:126: seconds=config.getint('session', 'timeout') // 6) On 2021/04/09 12:51:57, nicoe wrote: ...
1 year, 9 months ago (2021-04-09 13:05:14 UTC) #16
reviewbot
flake8 OK URL: https://codereview.tryton.org/341741060
1 year, 9 months ago (2021-04-09 13:26:56 UTC) #17
nicoe
https://codereview.tryton.org/341741060/diff/340491002/trytond/trytond/ir/session.py File trytond/trytond/ir/session.py (right): https://codereview.tryton.org/341741060/diff/340491002/trytond/trytond/ir/session.py#newcode126 trytond/trytond/ir/session.py:126: seconds=config.getint('session', 'timeout') // 6) On 2021/04/09 13:05:14, ced wrote: ...
1 year, 9 months ago (2021-04-09 17:01:26 UTC) #18
ced
https://codereview.tryton.org/341741060/diff/340491002/trytond/trytond/ir/session.py File trytond/trytond/ir/session.py (right): https://codereview.tryton.org/341741060/diff/340491002/trytond/trytond/ir/session.py#newcode126 trytond/trytond/ir/session.py:126: seconds=config.getint('session', 'timeout') // 6) On 2021/04/09 17:01:26, nicoe wrote: ...
1 year, 9 months ago (2021-04-09 17:56:48 UTC) #19
nicoe
https://codereview.tryton.org/341741060/diff/340491002/trytond/trytond/ir/session.py File trytond/trytond/ir/session.py (right): https://codereview.tryton.org/341741060/diff/340491002/trytond/trytond/ir/session.py#newcode126 trytond/trytond/ir/session.py:126: seconds=config.getint('session', 'timeout') // 6) On 2021/04/09 17:56:48, ced wrote: ...
1 year, 9 months ago (2021-04-09 18:44:01 UTC) #20
ced
https://codereview.tryton.org/341741060/diff/340491002/trytond/trytond/ir/session.py File trytond/trytond/ir/session.py (right): https://codereview.tryton.org/341741060/diff/340491002/trytond/trytond/ir/session.py#newcode126 trytond/trytond/ir/session.py:126: seconds=config.getint('session', 'timeout') // 6) On 2021/04/09 18:44:01, nicoe wrote: ...
1 year, 9 months ago (2021-04-09 19:21:39 UTC) #21
pokoli
https://codereview.tryton.org/341741060/diff/340491002/trytond/trytond/ir/session.py File trytond/trytond/ir/session.py (right): https://codereview.tryton.org/341741060/diff/340491002/trytond/trytond/ir/session.py#newcode126 trytond/trytond/ir/session.py:126: seconds=config.getint('session', 'timeout') // 6) On 2021/04/09 19:21:39, ced wrote: ...
1 year, 9 months ago (2021-04-09 19:48:25 UTC) #22
nicoe
https://codereview.tryton.org/341741060/diff/340491002/trytond/trytond/ir/session.py File trytond/trytond/ir/session.py (right): https://codereview.tryton.org/341741060/diff/340491002/trytond/trytond/ir/session.py#newcode126 trytond/trytond/ir/session.py:126: seconds=config.getint('session', 'timeout') // 6) On 2021/04/09 19:21:39, ced wrote: ...
1 year, 9 months ago (2021-04-09 21:15:59 UTC) #23
ced
https://codereview.tryton.org/341741060/diff/348161004/trytond/trytond/ir/session.py File trytond/trytond/ir/session.py (right): https://codereview.tryton.org/341741060/diff/348161004/trytond/trytond/ir/session.py#newcode49 trytond/trytond/ir/session.py:49: itertools.chain([records, values], args), 0, None, 2): Why not use ...
1 year, 9 months ago (2021-04-10 15:29:35 UTC) #24
ced
https://codereview.tryton.org/341741060/diff/348161004/trytond/trytond/ir/session.py File trytond/trytond/ir/session.py (right): https://codereview.tryton.org/341741060/diff/348161004/trytond/trytond/ir/session.py#newcode133 trytond/trytond/ir/session.py:133: seconds=config.getint('session', 'timeout') // 6) On 2021/04/10 15:29:35, ced wrote: ...
1 year, 9 months ago (2021-04-12 08:14:26 UTC) #25
nicoe
https://codereview.tryton.org/341741060/diff/348161004/trytond/trytond/ir/session.py File trytond/trytond/ir/session.py (right): https://codereview.tryton.org/341741060/diff/348161004/trytond/trytond/ir/session.py#newcode49 trytond/trytond/ir/session.py:49: itertools.chain([records, values], args), 0, None, 2): On 2021/04/10 15:29:35, ...
1 year, 9 months ago (2021-04-12 17:23:16 UTC) #26
nicoe
1 year, 9 months ago (2021-04-12 17:23:37 UTC) #27
ced
https://codereview.tryton.org/341741060/diff/345881003/trytond/trytond/ir/session.py File trytond/trytond/ir/session.py (right): https://codereview.tryton.org/341741060/diff/345881003/trytond/trytond/ir/session.py#newcode133 trytond/trytond/ir/session.py:133: if last_reset is None or (now - reset_timeout) > ...
1 year, 9 months ago (2021-04-12 17:37:39 UTC) #28
reviewbot
patch is not applicable URL: https://codereview.tryton.org/341741060
1 year, 9 months ago (2021-04-12 17:54:35 UTC) #29
nicoe
1 year, 9 months ago (2021-04-12 19:09:40 UTC) #30
nicoe
https://codereview.tryton.org/341741060/diff/345881003/trytond/trytond/ir/session.py File trytond/trytond/ir/session.py (right): https://codereview.tryton.org/341741060/diff/345881003/trytond/trytond/ir/session.py#newcode133 trytond/trytond/ir/session.py:133: if last_reset is None or (now - reset_timeout) > ...
1 year, 9 months ago (2021-04-12 19:09:48 UTC) #31
reviewbot
flake8 OK URL: https://codereview.tryton.org/341741060
1 year, 9 months ago (2021-04-12 19:20:01 UTC) #32
ced
https://codereview.tryton.org/341741060/diff/345881003/trytond/trytond/ir/session.py File trytond/trytond/ir/session.py (right): https://codereview.tryton.org/341741060/diff/345881003/trytond/trytond/ir/session.py#newcode133 trytond/trytond/ir/session.py:133: if last_reset is None or (now - reset_timeout) > ...
1 year, 9 months ago (2021-04-12 19:39:06 UTC) #33
nicoe
1 year, 9 months ago (2021-04-13 09:28:22 UTC) #34
reviewbot
flake8 OK URL: https://codereview.tryton.org/341741060
1 year, 9 months ago (2021-04-13 09:49:56 UTC) #35
ced
https://codereview.tryton.org/341741060/diff/351691002/trytond/trytond/ir/session.py File trytond/trytond/ir/session.py (right): https://codereview.tryton.org/341741060/diff/351691002/trytond/trytond/ir/session.py#newcode49 trytond/trytond/ir/session.py:49: cls._session_last_reset.set(session.key, None) I think that setting it to None ...
1 year, 9 months ago (2021-04-13 17:00:21 UTC) #36
ced
https://codereview.tryton.org/341741060/diff/351691002/trytond/trytond/ir/session.py File trytond/trytond/ir/session.py (right): https://codereview.tryton.org/341741060/diff/351691002/trytond/trytond/ir/session.py#newcode49 trytond/trytond/ir/session.py:49: cls._session_last_reset.set(session.key, None) On 2021/04/13 17:00:21, ced wrote: > I ...
1 year, 9 months ago (2021-05-03 19:21:47 UTC) #37
nicoe
1 year, 9 months ago (2021-05-07 13:06:50 UTC) #38
reviewbot
flake8 OK URL: https://codereview.tryton.org/341741060
1 year, 9 months ago (2021-05-07 13:23:16 UTC) #39
dave
https://codereview.tryton.org/341741060/diff/361871003/trytond/CHANGELOG File trytond/CHANGELOG (right): https://codereview.tryton.org/341741060/diff/361871003/trytond/CHANGELOG#newcode1 trytond/CHANGELOG:1: * Reset less often the user sessions Perhaps? Reset ...
1 year, 8 months ago (2021-05-10 16:54:06 UTC) #40
ced
https://codereview.tryton.org/341741060/diff/361871003/trytond/CHANGELOG File trytond/CHANGELOG (right): https://codereview.tryton.org/341741060/diff/361871003/trytond/CHANGELOG#newcode1 trytond/CHANGELOG:1: * Reset less often the user sessions On 2021/05/10 ...
1 year, 7 months ago (2021-06-22 23:10:21 UTC) #41
nicoe
6 months, 4 weeks ago (2022-07-07 10:23:40 UTC) #42
nicoe
https://codereview.tryton.org/341741060/diff/361871003/trytond/CHANGELOG File trytond/CHANGELOG (right): https://codereview.tryton.org/341741060/diff/361871003/trytond/CHANGELOG#newcode1 trytond/CHANGELOG:1: * Reset less often the user sessions On 2021/05/10 ...
6 months, 4 weeks ago (2022-07-07 10:23:45 UTC) #43
reviewbot
checks OK URL: https://codereview.tryton.org/341741060
6 months, 4 weeks ago (2022-07-07 10:44:36 UTC) #44
ced
https://codereview.tryton.org/341741060/diff/435481003/trytond/trytond/ir/session.py File trytond/trytond/ir/session.py (right): https://codereview.tryton.org/341741060/diff/435481003/trytond/trytond/ir/session.py#newcode18 trytond/trytond/ir/session.py:18: _session_last_reset = Cache('ir_session.session_timeout', context=False) Why are the name not ...
6 months, 2 weeks ago (2022-07-18 20:37:31 UTC) #45
nicoe
4 months, 3 weeks ago (2022-09-10 21:54:27 UTC) #46
reviewbot
checks OK URL: https://codereview.tryton.org/341741060
4 months, 3 weeks ago (2022-09-10 22:13:39 UTC) #47
ced
LGTM
4 months, 3 weeks ago (2022-09-10 22:29:03 UTC) #48
ced
On 2022/09/10 22:29:03, ced wrote: > LGTM ping
4 months ago (2022-10-02 09:07:09 UTC) #49
rietveld-bot_tryton.org
New changeset 38bd66006727 by Nicolas Évrard in branch 'default': Reset less often the user sessions ...
4 months ago (2022-10-02 22:07:02 UTC) #50
rietveld-bot_tryton.org
4 months ago (2022-10-02 22:07:12 UTC) #51
New changeset 0d577fecd64c by Nicolas Évrard in branch 'default':
Reset less often the user sessions
https://hg.tryton.org/tryton-env/rev/0d577fecd64c
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted