Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(50)

Issue 34351002: trytond: remove digits after comma in the progress bar

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 5 months ago by marcs
Modified:
2 years, 5 months ago
Reviewers:
reviewbot, ced, perilla
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M trytond/ir/module.py View 1 chunk +1 line, -1 line 3 comments Download

Messages

Total messages: 5
marcs
2 years, 5 months ago (2016-10-19 15:21:03 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/34351002
2 years, 5 months ago (2016-10-19 15:23:32 UTC) #2
perilla
https://tryton-rietveld.appspot.com/34351002/diff/1/trytond/ir/module.py File trytond/ir/module.py (right): https://tryton-rietveld.appspot.com/34351002/diff/1/trytond/ir/module.py#newcode426 trytond/ir/module.py:426: percentage = fields.Float('Percentage', (1, 2), readonly=True) (1, 2) -> ...
2 years, 5 months ago (2016-10-19 15:42:18 UTC) #3
perilla
https://tryton-rietveld.appspot.com/34351002/diff/1/trytond/ir/module.py File trytond/ir/module.py (right): https://tryton-rietveld.appspot.com/34351002/diff/1/trytond/ir/module.py#newcode426 trytond/ir/module.py:426: percentage = fields.Float('Percentage', (1, 2), readonly=True) or make percentage ...
2 years, 5 months ago (2016-10-19 15:44:47 UTC) #4
ced
2 years, 5 months ago (2016-10-21 08:58:26 UTC) #5
https://tryton-rietveld.appspot.com/34351002/diff/1/trytond/ir/module.py
File trytond/ir/module.py (right):

https://tryton-rietveld.appspot.com/34351002/diff/1/trytond/ir/module.py#newc...
trytond/ir/module.py:426: percentage = fields.Float('Percentage', (1, 2),
readonly=True)
On 2016/10/19 15:44:47, perilla wrote:
> or make percentage integer?

No, digits attribute is enough but you have to round the value of
default_percentage accordingly.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766