Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(130)

Issue 34361002: purchase: Add customer code for suppliers at party

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 5 months ago by lukio
Modified:
2 years, 3 months ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Added a field customer_code into a new tab Supplier at Party model. Also, added the customer_code at the purchase report. issue5812

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add info to documentation. Add a changelog entry #

Patch Set 3 : Update purchase module to last changes #

Patch Set 4 : Add view/party_form.xml #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
M CHANGELOG View 1 1 chunk +1 line, -0 lines 1 comment Download
M __init__.py View 1 2 chunks +2 lines, -1 line 0 comments Download
M doc/index.rst View 1 2 1 chunk +6 lines, -0 lines 2 comments Download
M party.py View 1 2 1 chunk +9 lines, -1 line 0 comments Download
M party.xml View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M purchase.odt View 1 2 Binary file 0 comments Download
A view/party_form.xml View 3 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 10
lukio
2 years, 5 months ago (2016-10-21 17:09:09 UTC) #1
reviewbot
patch is not applicable URL: https://codereview.tryton.org/34361002
2 years, 5 months ago (2016-10-21 17:28:53 UTC) #2
ced
I think the doc should be updated. Also avoid to use the form: "You can ...
2 years, 4 months ago (2016-10-30 19:49:49 UTC) #3
ced
On 2016/10/30 19:49:49, ced wrote: > I think the doc should be updated. > Also ...
2 years, 4 months ago (2016-10-30 19:50:16 UTC) #4
lukio
Add info to documentation. Add a changelog entry
2 years, 4 months ago (2016-11-11 13:25:25 UTC) #5
reviewbot
patch is not applicable URL: https://codereview.tryton.org/34361002
2 years, 4 months ago (2016-11-11 13:29:08 UTC) #6
lukio
Update purchase module to last changes
2 years, 4 months ago (2016-11-16 18:46:51 UTC) #7
lukio
Add view/party_form.xml
2 years, 4 months ago (2016-11-16 18:47:42 UTC) #8
reviewbot
patch is not applicable URL: https://codereview.tryton.org/34361002
2 years, 4 months ago (2016-11-16 19:00:05 UTC) #9
ced
2 years, 3 months ago (2016-12-10 18:44:46 UTC) #10
https://tryton-rietveld.appspot.com/34361002/diff/60001/CHANGELOG
File CHANGELOG (right):

https://tryton-rietveld.appspot.com/34361002/diff/60001/CHANGELOG#newcode1
CHANGELOG:1: * Add field customer_code on Party
Need to be updated to tip

https://tryton-rietveld.appspot.com/34361002/diff/60001/doc/index.rst
File doc/index.rst (right):

https://tryton-rietveld.appspot.com/34361002/diff/60001/doc/index.rst#newcode75
doc/index.rst:75: - Customer code: The supplier identification of the party.
I think it should be more explicit.
The code of the current company for the party as supplier.

Also I think it will be better to be a help on the field.

https://tryton-rietveld.appspot.com/34361002/diff/60001/doc/index.rst#newcode77
doc/index.rst:77: 
too much empty lines
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766