account: Restrict Income Statement dates to the one in the fiscalyear

COLLABORATOR=sergi@koolpi.com
issue10392

[reviewbot, 2021-06-21 11:06:22]

flake8 OK
URL: https://codereview.tryton.org/344381002

[pokoli, 2021-06-21 11:15:50]

https://codereview.tryton.org/344381002/diff/346551002/account.py
File account.py (right):

https://codereview.tryton.org/344381002/diff/346551002/account.py#newcode2288
account.py:2288: start = fields.Function(fields.Date("start"),
'on_change_with_start')
The field name should be more precise. If this is related to fiscalyear, it
should be fiscalyear_start_date.

https://codereview.tryton.org/344381002/diff/346551002/account.py#newcode2288
account.py:2288: start = fields.Function(fields.Date("start"),
'on_change_with_start')
Please capitalize labels.

https://codereview.tryton.org/344381002/diff/346551002/account.py#newcode2289
account.py:2289: end = fields.Function(fields.Date("end"), 'on_change_with_end')
idem

https://codereview.tryton.org/344381002/diff/346551002/account.py#newcode2298
account.py:2298: depends=['to_date', 'start'])
End should be added as depends. 
Running the test suite should complain about it.

https://codereview.tryton.org/344381002/diff/346551002/account.py#newcode2311
account.py:2311: fiscalyear_cmp = fields.Many2One('account.fiscalyear', 'Fiscal
Year',
The same behaviour should be applied for comparision fiscalyear.

[Davidoff, 2021-06-21 11:22:11]

account: Restrict Income Statement dates to the one in the fiscalyear

[reviewbot, 2021-06-21 11:30:33]

flake8 OK
URL: https://codereview.tryton.org/344381002

[Davidoff, 2021-06-21 11:48:26]

account: Restrict Income Statement dates to the one in the fiscalyear

[reviewbot, 2021-06-21 12:08:06]

flake8 OK
URL: https://codereview.tryton.org/344381002

[pokoli, 2021-06-28 06:14:20]

https://codereview.tryton.org/344381002/diff/334461003/account.py
File account.py (right):

https://codereview.tryton.org/344381002/diff/334461003/account.py#newcode2297
account.py:2297: ('from_date', '>=', Eval('fiscalyear_start_date')),
The restriction should only be tested when  the from date is set (idem for other
date fields).

[Davidoff, 2021-06-28 07:59:06]

account: Restrict Income Statement dates to the one in the fiscalyear

[reviewbot, 2021-06-28 08:01:01]

flake8 OK
URL: https://codereview.tryton.org/344381002

[pokoli, 2021-06-28 09:02:13]

https://codereview.tryton.org/344381002/diff/342591002/account.py
File account.py (right):

https://codereview.tryton.org/344381002/diff/342591002/account.py#newcode2288
account.py:2288: fiscalyear_start_date = fields.Function(fields.Date(
I think it's cleaner to break after fields.Function(

(should be applied to all fields)

https://codereview.tryton.org/344381002/diff/342591002/account.py#newcode2289
account.py:2289: "Fiscalyear Start Date"),
'on_change_with_fiscalyear_start_date')
Fiscalyear -> Fiscal Year
(should be applied to all labels)

https://codereview.tryton.org/344381002/diff/342591002/account.py#newcode2408
account.py:2408: self.end_period = None
I think we should also clear the from and to dates when chaning the fiscalyear.

The same applies for fiscalyear_cmp.

[Davidoff, 2021-06-28 11:31:06]

Add line breaks, separate text in Fiscal Year fields, and force clear from and
to dates when chaning the fiscalyear

[reviewbot, 2021-06-28 11:49:45]

flake8 OK
URL: https://codereview.tryton.org/344381002

[pokoli, 2021-09-30 14:56:01]

I think we should have the same feature on general ledger context

[Davidoff, 2021-10-01 10:01:56]

Apply the same feature on general ledger context

[Davidoff, 2021-10-01 10:04:32]

Apply the same feature on general ledger context

[reviewbot, 2021-10-01 10:08:26]

flake8 OK
URL: https://codereview.tryton.org/344381002

[Davidoff, 2022-04-06 09:47:35]

Update to tip

[pokoli, 2022-04-06 09:52:19]

https://codereview.tryton.org/344381002/diff/382321002/account.py
File account.py (right):

https://codereview.tryton.org/344381002/diff/382321002/account.py#newcode2185
account.py:2185: self.from_date = None
the date should not be cleared if its outside of the fiscalyear

https://codereview.tryton.org/344381002/diff/382321002/account.py#newcode2715
account.py:2715: self.from_date = None
The date should not be cleared if it is not outside of the fiscalyear.

https://codereview.tryton.org/344381002/diff/382321002/account.py#newcode2739
account.py:2739: self.start_period_cmp = None
I think it should follow the same behaviour as on_cahnge_fiscalyear.

[reviewbot, 2022-04-06 10:02:18]

checks OK
URL: https://codereview.tryton.org/344381002

[Davidoff, 2022-04-06 10:40:38]

Not clear from_date nor to_date if they are not outside of the fiscalyear

[reviewbot, 2022-04-06 11:10:17]

https://codereview.tryton.org/344381002/diff/388261002/account.py#newcode2177
account.py:2177:
line too long (87 > 79 characters)

https://codereview.tryton.org/344381002/diff/388261002/account.py#newcode2713
account.py:2713:
line too long (87 > 79 characters)

https://codereview.tryton.org/344381002/diff/388261002/account.py#newcode2750
account.py:2750:
line too long (107 > 79 characters)


URL: https://codereview.tryton.org/344381002

[Davidoff, 2022-04-06 11:14:12]

Fix flake8 errors

[reviewbot, 2022-04-06 11:38:46]

checks OK
URL: https://codereview.tryton.org/344381002