Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

Issue 344381002: account: Restrict Income Statement dates to the one in the fiscalyear

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 1 month ago by Davidoff
Modified:
4 months ago
Reviewers:
pokoli, reviewbot
Visibility:
Public.

Description

COLLABORATOR=sergi@koolpi.com issue10392

Patch Set 1 #

Total comments: 5

Patch Set 2 : account: Restrict Income Statement dates to the one in the fiscalyear #

Patch Set 3 : account: Restrict Income Statement dates to the one in the fiscalyear #

Total comments: 1

Patch Set 4 : account: Restrict Income Statement dates to the one in the fiscalyear #

Total comments: 3

Patch Set 5 : Add line breaks, separate text in Fiscal Year fields, and force clear from and to dates when chanin… #

Patch Set 6 : Apply the same feature on general ledger context #

Patch Set 7 : Apply the same feature on general ledger context #

Patch Set 8 : Update to tip #

Total comments: 3

Patch Set 9 : Not clear from_date nor to_date if they are not outside of the fiscalyear #

Patch Set 10 : Fix flake8 errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -8 lines) Patch
M account.py View 1 2 3 4 5 6 7 8 9 8 chunks +135 lines, -8 lines 0 comments Download

Messages

Total messages: 24
Davidoff
1 year, 1 month ago (2021-06-21 10:58:45 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/344381002
1 year, 1 month ago (2021-06-21 11:06:22 UTC) #2
pokoli
https://codereview.tryton.org/344381002/diff/346551002/account.py File account.py (right): https://codereview.tryton.org/344381002/diff/346551002/account.py#newcode2288 account.py:2288: start = fields.Function(fields.Date("start"), 'on_change_with_start') The field name should be ...
1 year, 1 month ago (2021-06-21 11:15:50 UTC) #3
Davidoff
account: Restrict Income Statement dates to the one in the fiscalyear
1 year, 1 month ago (2021-06-21 11:22:11 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/344381002
1 year, 1 month ago (2021-06-21 11:30:33 UTC) #5
Davidoff
account: Restrict Income Statement dates to the one in the fiscalyear
1 year, 1 month ago (2021-06-21 11:48:26 UTC) #6
reviewbot
flake8 OK URL: https://codereview.tryton.org/344381002
1 year, 1 month ago (2021-06-21 12:08:06 UTC) #7
pokoli
https://codereview.tryton.org/344381002/diff/334461003/account.py File account.py (right): https://codereview.tryton.org/344381002/diff/334461003/account.py#newcode2297 account.py:2297: ('from_date', '>=', Eval('fiscalyear_start_date')), The restriction should only be tested ...
1 year, 1 month ago (2021-06-28 06:14:20 UTC) #8
Davidoff
account: Restrict Income Statement dates to the one in the fiscalyear
1 year, 1 month ago (2021-06-28 07:59:06 UTC) #9
reviewbot
flake8 OK URL: https://codereview.tryton.org/344381002
1 year, 1 month ago (2021-06-28 08:01:01 UTC) #10
pokoli
https://codereview.tryton.org/344381002/diff/342591002/account.py File account.py (right): https://codereview.tryton.org/344381002/diff/342591002/account.py#newcode2288 account.py:2288: fiscalyear_start_date = fields.Function(fields.Date( I think it's cleaner to break ...
1 year, 1 month ago (2021-06-28 09:02:13 UTC) #11
Davidoff
Add line breaks, separate text in Fiscal Year fields, and force clear from and to ...
1 year, 1 month ago (2021-06-28 11:31:06 UTC) #12
reviewbot
flake8 OK URL: https://codereview.tryton.org/344381002
1 year, 1 month ago (2021-06-28 11:49:45 UTC) #13
pokoli
I think we should have the same feature on general ledger context
10 months, 1 week ago (2021-09-30 14:56:01 UTC) #14
Davidoff
Apply the same feature on general ledger context
10 months, 1 week ago (2021-10-01 10:01:56 UTC) #15
Davidoff
Apply the same feature on general ledger context
10 months, 1 week ago (2021-10-01 10:04:32 UTC) #16
reviewbot
flake8 OK URL: https://codereview.tryton.org/344381002
10 months, 1 week ago (2021-10-01 10:08:26 UTC) #17
Davidoff
Update to tip
4 months ago (2022-04-06 09:47:35 UTC) #18
pokoli
https://codereview.tryton.org/344381002/diff/382321002/account.py File account.py (right): https://codereview.tryton.org/344381002/diff/382321002/account.py#newcode2185 account.py:2185: self.from_date = None the date should not be cleared ...
4 months ago (2022-04-06 09:52:19 UTC) #19
reviewbot
checks OK URL: https://codereview.tryton.org/344381002
4 months ago (2022-04-06 10:02:18 UTC) #20
Davidoff
Not clear from_date nor to_date if they are not outside of the fiscalyear
4 months ago (2022-04-06 10:40:38 UTC) #21
reviewbot
https://codereview.tryton.org/344381002/diff/388261002/account.py#newcode2177 account.py:2177: line too long (87 > 79 characters) https://codereview.tryton.org/344381002/diff/388261002/account.py#newcode2713 account.py:2713: line too long (87 ...
4 months ago (2022-04-06 11:10:17 UTC) #22
Davidoff
Fix flake8 errors
4 months ago (2022-04-06 11:14:12 UTC) #23
reviewbot
4 months ago (2022-04-06 11:38:46 UTC) #24
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted