https://codereview.tryton.org/345051002/diff/379701002/view/work_list.xml File view/work_list.xml (right): https://codereview.tryton.org/345051002/diff/379701002/view/work_list.xml#newcode8 view/work_list.xml:8: <field name="cost"/> I'm not sure it is need on ...
https://codereview.tryton.org/345051002/diff/367921003/CHANGELOG File CHANGELOG (right): https://codereview.tryton.org/345051002/diff/367921003/CHANGELOG#newcode1 CHANGELOG:1: * Show cost of production works I think it ...
When costs[cost] is None I recieve the following: Traceback (most recent call last): File "/trytond/wsgi.py", ...
1 year, 4 months ago
(2022-01-26 14:48:09 UTC)
#11
When costs[cost] is None I recieve the following:
Traceback (most recent call last):
File "/trytond/wsgi.py", line 117, in dispatch_request
return endpoint(request, **request.view_args)
File "/trytond/protocols/dispatcher.py", line 47, in rpc
return methods.get(request.rpc_method, _dispatch)(
File "/trytond/wsgi.py", line 84, in auth_required
return wrapped(*args, **kwargs)
File "/trytond/protocols/wrappers.py", line 156, in wrapper
return func(request, pool, *args, **kwargs)
File "/trytond/protocols/dispatcher.py", line 181, in _dispatch
result = rpc.result(meth(*c_args, **c_kwargs))
File "/trytond/model/modelsql.py", line 867, in read
getter_results = field.get(
File "/trytond/model/fields/function.py", line 105, in get
return dict((name, call(name)) for name in names)
File "/trytond/model/fields/function.py", line 105, in <genexpr>
return dict((name, call(name)) for name in names)
File "/trytond/model/fields/function.py", line 98, in call
return method(records, name)
File "/production.py", line 544, in get_cost
costs[cost] = Decimal(str(costs[cost]))
decimal.InvalidOperation: [<class 'decimal.ConversionSyntax'>]
Fault: [<class 'decimal.ConversionSyntax'>]
Don't know which is the best solution but the following fix does the job:
costs[cost] = Decimal(str(costs[cost]))
https://codereview.tryton.org/345051002/diff/376541002/work.py File work.py (right): https://codereview.tryton.org/345051002/diff/376541002/work.py#newcode271 work.py:271: work.id, Sum(cycle.cost), you should Coalesce the cost to 0 ...
1 year, 4 months ago
(2022-01-26 14:50:23 UTC)
#12
https://codereview.tryton.org/345051002/diff/368211002/production.py File production.py (right): https://codereview.tryton.org/345051002/diff/368211002/production.py#newcode43 production.py:43: cost = super(Production, self).get_cost(name) super call should not be ...
1 year, 2 months ago
(2022-03-23 08:40:27 UTC)
#22
https://codereview.tryton.org/345051002/diff/403091003/view/work_list_sequence.xml File view/work_list_sequence.xml (right): https://codereview.tryton.org/345051002/diff/403091003/view/work_list_sequence.xml#newcode8 view/work_list_sequence.xml:8: <field name="cost"/> I would define it as optional="0" https://codereview.tryton.org/345051002/diff/403091003/work.py ...
1 year, 2 months ago
(2022-04-03 17:44:58 UTC)
#25
On 2022/08/11 11:29:58, acaubet wrote: > On 2022/07/16 16:45:51, ced wrote: > > It will ...
6 months, 1 week ago
(2022-11-27 22:40:24 UTC)
#32
On 2022/08/11 11:29:58, acaubet wrote:
> On 2022/07/16 16:45:51, ced wrote:
> > It will be good to update the scenario to test the cost computation on work.
>
> Sorry I don't understand. Is not this
>
https://codereview.tryton.org/345051002/diff/390501002/tests/scenario_product...
> what you are asking for?
I mean testing on different step when adding cycles.
https://codereview.tryton.org/345051002/diff/443461003/work.py File work.py (right): https://codereview.tryton.org/345051002/diff/443461003/work.py#newcode260 work.py:260: for sub_ids in grouped_slice([w.id for w in works]): It ...
6 months, 1 week ago
(2022-11-27 22:40:29 UTC)
#33
Issue 345051002: production_work: Show cost of production works
Created 1 year, 6 months ago by acaubet
Modified 6 months, 1 week ago
Reviewers: reviewbot, pokoli, ced
Base URL:
Comments: 25