Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(77)

Issue 34541002: trytond: Read translations without checking access (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 3 months ago by pokoli
Modified:
2 years, 2 months ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Since changesetde90bf5435ce instance records are used (instead of writing the values) but when they are read with the check_access, as this context is used to save the values they raise incorrect access error. issue6115

Patch Set 1 #

Patch Set 2 : Browse translation instances without _check_acess #

Patch Set 3 : Add test scenario #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -25 lines) Patch
M trytond/ir/translation.py View 1 2 chunks +25 lines, -25 lines 0 comments Download
M trytond/tests/test_modelstorage.py View 1 2 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 11
pokoli
2 years, 3 months ago (2016-12-14 14:41:42 UTC) #1
ced
We need a tests for that.
2 years, 3 months ago (2016-12-14 14:59:39 UTC) #2
reviewbot
flake8 OK URL: https://codereview.tryton.org/34541002
2 years, 3 months ago (2016-12-14 15:06:01 UTC) #3
pokoli
Browse translation instances without _check_acess
2 years, 3 months ago (2016-12-14 15:34:06 UTC) #4
reviewbot
https://codereview.tryton.org/34541002/diff/20001/trytond/ir/translation.py#newcode222 trytond/ir/translation.py:222: E127 continuation line over-indented for visual indent https://codereview.tryton.org/34541002/diff/20001/trytond/ir/translation.py#newcode241 trytond/ir/translation.py:241: E127 continuation line over-indented ...
2 years, 3 months ago (2016-12-14 15:35:55 UTC) #5
ced
Please add a test we should ensure this behaviour stays.
2 years, 3 months ago (2016-12-14 15:38:58 UTC) #6
pokoli
Add test scenario
2 years, 3 months ago (2016-12-14 16:51:11 UTC) #7
reviewbot
https://codereview.tryton.org/34541002/diff/40001/trytond/ir/translation.py#newcode222 trytond/ir/translation.py:222: E127 continuation line over-indented for visual indent https://codereview.tryton.org/34541002/diff/40001/trytond/ir/translation.py#newcode241 trytond/ir/translation.py:241: E127 continuation line over-indented ...
2 years, 3 months ago (2016-12-14 16:55:58 UTC) #8
ced
LGTM but title seems to miss a verb Please commit test in separate commit.
2 years, 3 months ago (2016-12-16 23:02:06 UTC) #9
rietveld-bot_tryton.org
New changeset fa0fe05fbdb4 by Sergi Almacellas Abellana in branch 'default': Read translations without checking access ...
2 years, 3 months ago (2016-12-19 08:42:43 UTC) #10
rietveld-bot_tryton.org
2 years, 2 months ago (2016-12-30 21:17:27 UTC) #11
New changeset cf33acb1c862 by Sergi Almacellas Abellana in branch '4.2':
Read translations without checking access
http://hg.tryton.org/trytond/rev/cf33acb1c862
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766